adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-13 02:42:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat(chromium): skipNetworkIdleEvent is now true by default

Browse Source
This commit is contained in:
Julien Neuhart
2024-09-29 18:04:37 +02:00
parent d970e446a8
commit 1252ea076b
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/modules/chromium/browser_test.go
View File

@@ -379,7 +379,7 @@ func TestChromiumBrowser_pdf(t *testing.T) {
},
},
{
scenario: "skip networkIdle event",
scenario: "do not skip networkIdle event",
browser: newChromiumBrowser(
browserArguments{
binPath: os.Getenv("CHROMIUM_BIN_PATH"),
@@ -404,13 +404,13 @@ func TestChromiumBrowser_pdf(t *testing.T) {
return fs
}(),
options: PdfOptions{
Options: Options{SkipNetworkIdleEvent: true},
Options: Options{SkipNetworkIdleEvent: false},
},
noDeadline: false,
start: true,
expectError: false,
expectedLogEntries: []string{
"skipping network idle event",
"event networkIdle fired",
},
},
{
@@ -1225,6 +1225,7 @@ func TestChromiumBrowser_pdf(t *testing.T) {
"no cookies to set",
"no extra HTTP headers",
"navigate to",
"skipping network idle event",
"default white background not hidden",
"no emulated media type",
"no wait delay",
@@ -1452,7 +1453,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) {
},
},
{
scenario: "skip networkIdle event",
scenario: "do not skip networkIdle event",
browser: newChromiumBrowser(
browserArguments{
binPath: os.Getenv("CHROMIUM_BIN_PATH"),
@@ -1477,13 +1478,13 @@ func TestChromiumBrowser_screenshot(t *testing.T) {
return fs
}(),
options: ScreenshotOptions{
Options: Options{SkipNetworkIdleEvent: true},
Options: Options{SkipNetworkIdleEvent: false},
},
noDeadline: false,
start: true,
expectError: false,
expectedLogEntries: []string{
"skipping network idle event",
"event networkIdle fired",
},
},
{
@@ -2184,6 +2185,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) {
"no user agent override",
"no extra HTTP headers",
"navigate to",
"skipping network idle event",
"default white background not hidden",
"no emulated media type",
"no wait delay",

2
pkg/modules/chromium/chromium.go
View File

@@ -123,7 +123,7 @@ type Options struct {
// DefaultOptions returns the default values for Options.
func DefaultOptions() Options {
return Options{
SkipNetworkIdleEvent: false,
SkipNetworkIdleEvent: true,
FailOnHttpStatusCodes: []int64{499, 599},
FailOnConsoleExceptions: false,
WaitDelay: 0,