diff --git a/pkg/modules/chromium/browser_test.go b/pkg/modules/chromium/browser_test.go index d1c54a44..dfee69ab 100644 --- a/pkg/modules/chromium/browser_test.go +++ b/pkg/modules/chromium/browser_test.go @@ -379,7 +379,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { }, }, { - scenario: "skip networkIdle event", + scenario: "do not skip networkIdle event", browser: newChromiumBrowser( browserArguments{ binPath: os.Getenv("CHROMIUM_BIN_PATH"), @@ -404,13 +404,13 @@ func TestChromiumBrowser_pdf(t *testing.T) { return fs }(), options: PdfOptions{ - Options: Options{SkipNetworkIdleEvent: true}, + Options: Options{SkipNetworkIdleEvent: false}, }, noDeadline: false, start: true, expectError: false, expectedLogEntries: []string{ - "skipping network idle event", + "event networkIdle fired", }, }, { @@ -1225,6 +1225,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { "no cookies to set", "no extra HTTP headers", "navigate to", + "skipping network idle event", "default white background not hidden", "no emulated media type", "no wait delay", @@ -1452,7 +1453,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { }, }, { - scenario: "skip networkIdle event", + scenario: "do not skip networkIdle event", browser: newChromiumBrowser( browserArguments{ binPath: os.Getenv("CHROMIUM_BIN_PATH"), @@ -1477,13 +1478,13 @@ func TestChromiumBrowser_screenshot(t *testing.T) { return fs }(), options: ScreenshotOptions{ - Options: Options{SkipNetworkIdleEvent: true}, + Options: Options{SkipNetworkIdleEvent: false}, }, noDeadline: false, start: true, expectError: false, expectedLogEntries: []string{ - "skipping network idle event", + "event networkIdle fired", }, }, { @@ -2184,6 +2185,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { "no user agent override", "no extra HTTP headers", "navigate to", + "skipping network idle event", "default white background not hidden", "no emulated media type", "no wait delay", diff --git a/pkg/modules/chromium/chromium.go b/pkg/modules/chromium/chromium.go index e5f8f408..735b2700 100644 --- a/pkg/modules/chromium/chromium.go +++ b/pkg/modules/chromium/chromium.go @@ -123,7 +123,7 @@ type Options struct { // DefaultOptions returns the default values for Options. func DefaultOptions() Options { return Options{ - SkipNetworkIdleEvent: false, + SkipNetworkIdleEvent: true, FailOnHttpStatusCodes: []int64{499, 599}, FailOnConsoleExceptions: false, WaitDelay: 0,