add api key e2e tests and improve labels

.github/ISSUE_TEMPLATE/1_bug_report.yml

@@ -1,47 +0,0 @@
-name: Bug Report
-description: "Report a bug"
-body:
-  - type: markdown
-    attributes:
-      value: |
-        Before creating a new bug report, please check that there isn't already a similar issue.
-
-  - type: textarea
-    attributes:
-      label: Description
-      description: A clear and concise description of what the bug is.
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: "Steps To Reproduce"
-      description: How do you trigger this bug? Please walk us through it step by step.
-      value: |
-        1.
-        2.
-        3.
-        ...
-    validations:
-      required: false
-
-  - type: dropdown
-    attributes:
-      label: "Self-hosted or Cloud?"
-      options:
-        - Self-Hosted
-        - solidtime Cloud
-        - Both
-
-  - type: input
-    attributes:
-      label: "Version of solidtime: (for self-hosted)"
-    validations:
-      required: false
-
-  - type: input
-    attributes:
-      label: "solidtime self-hosting guide: (for self-hosted)"
-      description: "Did you use the official guide to self-host solidtime? If yes, which one?"
-    validations:
-      required: false

.github/ISSUE_TEMPLATE/config.yml

@@ -1,8 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: 🚀 Feature Request
-    url: https://github.com/solidtime-io/solidtime/discussions/new?category=feature-requests
-    about: Share ideas for new features
-  - name: ❓ Ask a Question
-    url: https://github.com/solidtime-io/solidtime/discussions/new?category=general
-    about: Ask the community for help

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,8 +0,0 @@
-<!--
-This project is early stage. The structure and APIs are still subject to change and not stable.
-Therefore, we do not currently accept any contributions, unless you are a member of the team.
-
-As soon as we feel comfortable enough that the application structure is stable enough, we will open up the project for contributions.
-
-We do accept contributions in the [documentation repository](https://github.com/solidtime-io/docs) f.e. to add new self-hosting guides.
--->

.github/workflows/build-public.yml

@@ -11,21 +11,10 @@ on:
       - 'docker/prod/**'
   workflow_dispatch:
 
-env:
-  DOCKERHUB_REPO: solidtime/solidtime
-  GHCR_REPO: ghcr.io/solidtime-io/solidtime
-
 name: Build - Public
 jobs:
   build:
-    strategy:
-      matrix:
-        include:
-          - runs-on: "ubuntu-24.04-arm"
-            platform: "linux/arm64"
-          - runs-on: "ubuntu-24.04"
-            platform: "linux/amd64"
-    runs-on: ${{ matrix.runs-on }}
+    runs-on: ubuntu-22.04
     permissions:
       packages: write
       contents: read
@@ -40,7 +29,7 @@ jobs:
           fetch-depth: 0 # Required for WyriHaximus/github-action-get-previous-tag
 
       - name: "Get build"
-        id: release-build
+        id: build
         run: echo "build=$(git rev-parse --short=8 HEAD)" >> "$GITHUB_OUTPUT"
 
       - name: "Get Previous tag (normal push)"
@@ -51,7 +40,7 @@ jobs:
           prefix: "v"
 
       - name: "Get version"
-        id: release-version
+        id: version
         run: |
           if ${{ !startsWith(github.ref, 'refs/tags/v') }}; then
             if ${{ startsWith(steps.previoustag.outputs.tag, 'v') }}; then
@@ -72,23 +61,21 @@ jobs:
           rm .env.production .env.ci .env.example
 
       - name: "Add version to .env"
-        run: sed -i 's/APP_VERSION=0.0.0/APP_VERSION=${{ steps.release-version.outputs.app_version }}/g' .env
+        run: sed -i 's/APP_VERSION=0.0.0/APP_VERSION=${{ steps.version.outputs.app_version }}/g' .env
 
       - name: "Add build to .env"
-        run: sed -i 's/APP_BUILD=0/APP_BUILD=${{ steps.release-build.outputs.build }}/g' .env
+        run: sed -i 's/APP_BUILD=0/APP_BUILD=${{ steps.build.outputs.build }}/g' .env
 
       - name: "Output .env"
         run: cat .env
 
-      - name: "Setup PHP with PECL extension"
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.3'
-          extensions: mbstring, dom, fileinfo, pgsql
-
       - name: "Install dependencies"
-        run: composer install --no-dev --no-ansi --no-interaction --prefer-dist --ignore-platform-reqs --classmap-authoritative
+        uses: php-actions/composer@v6
         if: steps.cache-vendor.outputs.cache-hit != 'true' # Skip if cache hit
+        with:
+          command: install
+          only_args: --no-dev --no-ansi --no-interaction --prefer-dist --ignore-platform-reqs --classmap-authoritative
+          php_version: 8.3
 
       - name: "Use Node.js"
         uses: actions/setup-node@v4
@@ -101,31 +88,29 @@ jobs:
       - name: "Build"
         run: npm run build
 
-      - name: "Prepare"
-        run: |
-          platform=${{ matrix.platform }}
-          echo "PLATFORM_PAIR=${platform//\//-}" >> $GITHUB_ENV
-
-      - name: "Docker meta"
-        id: "meta"
-        uses: docker/metadata-action@v5
-        with:
-          images: |
-            ${{ env.DOCKERHUB_REPO }}
-            ${{ env.GHCR_REPO }}
-
-      - name: "Login to Docker Hub Container Registry"
+      - name: "Login to GitHub Container Registry"
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
-
       - name: "Login to GitHub Container Registry"
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
+      - name: "Docker meta"
+        id: "meta"
+        uses: docker/metadata-action@v5
+        with:
+          images: |
+            solidtime/solidtime
+            ghcr.io/${{ github.repository }}
+          tags: |
+            type=ref,event=branch
+            type=ref,event=pr
+            type=semver,pattern={{version}}
+            type=semver,pattern={{major}}.{{minor}}
 
       - name: "Set up QEMU"
         uses: docker/setup-qemu-action@v3
@@ -133,90 +118,16 @@ jobs:
       - name: "Set up Docker Buildx"
         uses: docker/setup-buildx-action@v3
 
-      - name: "Build and push by digest"
-        id: build
+      - name: "Build and push"
         uses: docker/build-push-action@v6
         with:
           context: .
           file: docker/prod/Dockerfile
           build-args: |
             DOCKER_FILES_BASE_PATH=docker/prod/
-          platforms: ${{ matrix.platform }}
+          platforms: linux/amd64,linux/arm64
+          push: true
+          tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
-          outputs: type=image,"name=${{ env.DOCKERHUB_REPO }},${{ env.GHCR_REPO }}",push-by-digest=true,name-canonical=true,push=true
           cache-from: type=gha
           cache-to: type=gha,mode=max
-
-      - name: "Export digest"
-        run: |
-          mkdir -p ${{ runner.temp }}/digests
-          digest="${{ steps.build.outputs.digest }}"
-          touch "${{ runner.temp }}/digests/${digest#sha256:}"
-
-      - name: "Upload digest"
-        uses: actions/upload-artifact@v4
-        with:
-          name: digests-${{ env.PLATFORM_PAIR }}
-          path: ${{ runner.temp }}/digests/*
-          if-no-files-found: error
-          retention-days: 1
-
-  merge:
-    runs-on: ubuntu-latest
-    permissions:
-      packages: write
-      contents: read
-      attestations: write
-      id-token: write
-    timeout-minutes: 90
-    needs:
-      - build
-    steps:
-      - name: "Download digests"
-        uses: actions/download-artifact@v4
-        with:
-          path: ${{ runner.temp }}/digests
-          pattern: digests-*
-          merge-multiple: true
-
-      - name: "Login to Docker Hub"
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
-
-      - name: "Login to GHCR"
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: "Set up Docker Buildx"
-        uses: docker/setup-buildx-action@v3
-
-      - name: "Docker meta"
-        id: meta
-        uses: docker/metadata-action@v5
-        with:
-          images: |
-            ${{ env.DOCKERHUB_REPO }}
-            ${{ env.GHCR_REPO }}
-          tags: |
-            type=ref,event=branch
-            type=ref,event=pr
-            type=semver,pattern={{version}}
-            type=semver,pattern={{major}}.{{minor}}
-
-      - name: "Create manifest list and push"
-        working-directory: ${{ runner.temp }}/digests
-        run: |
-          docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
-            $(printf '${{ env.DOCKERHUB_REPO }}@sha256:%s ' *)
-          docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
-            $(printf '${{ env.GHCR_REPO }}@sha256:%s ' *)
-
-      - name: "Inspect image"
-        run: |
-          docker buildx imagetools inspect ${{ env.DOCKERHUB_REPO }}:${{ steps.meta.outputs.version }}
-          docker buildx imagetools inspect ${{ env.GHCR_REPO }}:${{ steps.meta.outputs.version }}

.github/workflows/phpunit.yml

@@ -63,7 +63,7 @@ jobs:
         run: php artisan test --stop-on-failure --coverage-text --coverage-clover=coverage.xml
 
       - name: "Upload coverage reports to Codecov"
-        uses: codecov/codecov-action@v5.4.0
+        uses: codecov/codecov-action@v5.3.1
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           slug: solidtime-io/solidtime

app/Console/Commands/Correction/CorrectionPlaceholderMembersCommand.php

@@ -1,59 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Console\Commands\Correction;
-
-use App\Enums\Role;
-use App\Models\Member;
-use App\Models\User;
-use Illuminate\Console\Command;
-use Illuminate\Database\Eloquent\Builder;
-
-class CorrectionPlaceholderMembersCommand extends Command
-{
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
-    protected $signature = 'correction:placeholder-members '.
-        ' { --dry-run : Do not actually save anything to the database, just output what would happen }';
-
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
-    protected $description = 'Sets all members who belong to a placeholder user to role placeholder';
-
-    /**
-     * Execute the console command.
-     */
-    public function handle(): int
-    {
-        $this->comment('Sets all members who belong to a placeholder user to role placeholder...');
-        $dryRun = (bool) $this->option('dry-run');
-        if ($dryRun) {
-            $this->comment('Running in dry-run mode. Nothing will be saved to the database.');
-        }
-
-        $members = Member::query()
-            ->where('role', '!=', Role::Placeholder->value)
-            ->whereHas('user', function (Builder $builder): void {
-                /** @var Builder<User> $builder */
-                $builder->where('is_placeholder', '=', true);
-            })
-            ->get();
-        foreach ($members as $member) {
-            /** @var Member $member */
-            $member->role = Role::Placeholder->value;
-            if (! $dryRun) {
-                $member->save();
-            }
-            $this->line('Set role of member (id='.$member->getKey().') to placeholder');
-        }
-
-        return self::SUCCESS;
-    }
-}

app/Exceptions/Api/ChangingRoleOfPlaceholderIsNotAllowed.php

@@ -1,10 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Exceptions\Api;
-
-class ChangingRoleOfPlaceholderIsNotAllowed extends ApiException
-{
-    public const string KEY = 'changing_role_of_placeholder_is_not_allowed';
-}

app/Exceptions/Api/OnlyPlaceholdersCanBeMergedIntoAnotherMember.php

@@ -1,10 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Exceptions\Api;
-
-class OnlyPlaceholdersCanBeMergedIntoAnotherMember extends ApiException
-{
-    public const string KEY = 'only_placeholders_can_be_merged_into_another_member';
-}

app/Exceptions/Api/ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException.php

@@ -1,10 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Exceptions\Api;
-
-class ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException extends ApiException
-{
-    public const string KEY = 'this_placeholder_can_not_be_invited_use_the_merge_tool_instead_api_exception';
-}

app/Http/Controllers/Api/V1/MemberController.php

@@ -7,17 +7,12 @@ namespace App\Http\Controllers\Api\V1;
 use App\Enums\Role;
 use App\Events\MemberMadeToPlaceholder;
 use App\Exceptions\Api\CanNotRemoveOwnerFromOrganization;
-use App\Exceptions\Api\ChangingRoleOfPlaceholderIsNotAllowed;
 use App\Exceptions\Api\ChangingRoleToPlaceholderIsNotAllowed;
 use App\Exceptions\Api\EntityStillInUseApiException;
 use App\Exceptions\Api\OnlyOwnerCanChangeOwnership;
-use App\Exceptions\Api\OnlyPlaceholdersCanBeMergedIntoAnotherMember;
 use App\Exceptions\Api\OrganizationNeedsAtLeastOneOwner;
-use App\Exceptions\Api\ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException;
-use App\Exceptions\Api\UserIsAlreadyMemberOfOrganizationApiException;
 use App\Exceptions\Api\UserNotPlaceholderApiException;
 use App\Http\Requests\V1\Member\MemberIndexRequest;
-use App\Http\Requests\V1\Member\MemberMergeIntoRequest;
 use App\Http\Requests\V1\Member\MemberUpdateRequest;
 use App\Http\Resources\V1\Member\MemberCollection;
 use App\Http\Resources\V1\Member\MemberResource;
@@ -29,8 +24,6 @@ use App\Service\MemberService;
 use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Resources\Json\JsonResource;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Support\Str;
 
 class MemberController extends Controller
 {
@@ -70,7 +63,6 @@ class MemberController extends Controller
      * @throws OrganizationNeedsAtLeastOneOwner
      * @throws OnlyOwnerCanChangeOwnership
      * @throws ChangingRoleToPlaceholderIsNotAllowed
-     * @throws ChangingRoleOfPlaceholderIsNotAllowed
      *
      * @operationId updateMember
      */
@@ -113,7 +105,7 @@ class MemberController extends Controller
     /**
      * Make a member a placeholder member
      *
-     * @throws AuthorizationException|CanNotRemoveOwnerFromOrganization|ChangingRoleOfPlaceholderIsNotAllowed
+     * @throws AuthorizationException|CanNotRemoveOwnerFromOrganization
      */
     public function makePlaceholder(Organization $organization, Member $member, MemberService $memberService): JsonResponse
     {
@@ -122,9 +114,6 @@ class MemberController extends Controller
         if ($member->role === Role::Owner->value) {
             throw new CanNotRemoveOwnerFromOrganization;
         }
-        if ($member->role === Role::Placeholder->value) {
-            throw new ChangingRoleOfPlaceholderIsNotAllowed;
-        }
 
         $memberService->makeMemberToPlaceholder($member);
 
@@ -133,39 +122,10 @@ class MemberController extends Controller
         return response()->json(null, 204);
     }
 
-    /**
-     * @throws AuthorizationException
-     * @throws OnlyPlaceholdersCanBeMergedIntoAnotherMember
-     * @throws \Throwable
-     *
-     * @operationId mergeMember
-     */
-    public function mergeInto(Organization $organization, Member $member, MemberMergeIntoRequest $request, MemberService $memberService): JsonResponse
-    {
-        $this->checkPermission($organization, 'members:merge-into', $member);
-
-        $user = $member->user;
-        if ($member->role !== Role::Placeholder->value || ! $user->is_placeholder) {
-            throw new OnlyPlaceholdersCanBeMergedIntoAnotherMember;
-        }
-        $memberTo = Member::findOrFail($request->getMemberId());
-
-        DB::transaction(function () use ($organization, $member, $user, $memberTo, $memberService): void {
-            $memberService->assignOrganizationEntitiesToDifferentMember($organization, $member, $memberTo);
-            $member->delete();
-            $user->delete();
-        });
-
-        return response()->json(null, 204);
-    }
-
     /**
      * Invite a placeholder member to become a real member of the organization
      *
-     * @throws AuthorizationException
-     * @throws UserNotPlaceholderApiException
-     * @throws UserIsAlreadyMemberOfOrganizationApiException
-     * @throws ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException
+     * @throws AuthorizationException|UserNotPlaceholderApiException
      *
      * @operationId invitePlaceholder
      */
@@ -178,10 +138,6 @@ class MemberController extends Controller
             throw new UserNotPlaceholderApiException;
         }
 
-        if (Str::endsWith($user->email, '@solidtime-import.test')) {
-            throw new ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException;
-        }
-
         $invitationService->inviteUser($organization, $user->email, Role::Employee);
 
         return response()->json(null, 204);

app/Http/Requests/V1/Member/MemberMergeIntoRequest.php

@@ -1,42 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Http\Requests\V1\Member;
-
-use App\Models\Member;
-use App\Models\Organization;
-use Illuminate\Contracts\Validation\ValidationRule;
-use Illuminate\Database\Eloquent\Builder;
-use Illuminate\Foundation\Http\FormRequest;
-use Korridor\LaravelModelValidationRules\Rules\ExistsEloquent;
-
-/**
- * @property Organization $organization
- */
-class MemberMergeIntoRequest extends FormRequest
-{
-    /**
-     * Get the validation rules that apply to the request.
-     *
-     * @return array<string, array<string|ValidationRule|\Illuminate\Contracts\Validation\Rule>>
-     */
-    public function rules(): array
-    {
-        return [
-            // ID of the member to which the data should be transferred (destination)
-            'member_id' => [
-                'string',
-                ExistsEloquent::make(Member::class, null, function (Builder $builder): Builder {
-                    /** @var Builder<Member> $builder */
-                    return $builder->whereBelongsTo($this->organization, 'organization');
-                })->uuid(),
-            ],
-        ];
-    }
-
-    public function getMemberId(): string
-    {
-        return (string) $this->input('member_id');
-    }
-}

app/Listeners/RemovePlaceholder.php

@@ -6,7 +6,7 @@ namespace App\Listeners;
 
 use App\Models\Member;
 use App\Models\User;
-use App\Service\MemberService;
+use App\Service\UserService;
 use Illuminate\Database\Eloquent\Builder;
 use Laravel\Jetstream\Events\TeamMemberAdded;
 
@@ -17,11 +17,8 @@ class RemovePlaceholder
      */
     public function handle(TeamMemberAdded $event): void
     {
-        $memberService = app(MemberService::class);
-        $member = Member::query()
-            ->whereBelongsTo($event->team, 'organization')
-            ->whereBelongsTo($event->user, 'user')
-            ->firstOrFail();
+        /** @var UserService $userService */
+        $userService = app(UserService::class);
         $placeholders = Member::query()
             ->whereHas('user', function (Builder $query) use ($event): void {
                 /** @var Builder<User> $query */
@@ -35,7 +32,7 @@ class RemovePlaceholder
         foreach ($placeholders as $placeholder) {
             /** @var Member $placeholder */
             $placeholderUser = $placeholder->user;
-            $memberService->assignOrganizationEntitiesToDifferentMember($event->team, $placeholder, $member);
+            $userService->assignOrganizationEntitiesToDifferentUser($event->team, $placeholderUser, $event->user);
             $placeholder->delete();
             $placeholderUser->delete();
         }

app/Models/Member.php

@@ -7,7 +7,6 @@ namespace App\Models;
 use App\Models\Concerns\CustomAuditable;
 use App\Models\Concerns\HasUuids;
 use Database\Factories\MemberFactory;
-use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\HasMany;
@@ -25,8 +24,6 @@ use OwenIt\Auditing\Contracts\Auditable as AuditableContract;
  * @property Carbon|null $updated_at
  * @property-read Organization $organization
  * @property-read User $user
- * @property-read Collection<ProjectMember> $projectMembers
- * @property-read Collection<TimeEntry> $timeEntries
  *
  * @method static MemberFactory factory()
  */
@@ -62,14 +59,6 @@ class Member extends JetstreamMembership implements AuditableContract
         return $this->belongsTo(Organization::class, 'organization_id');
     }
 
-    /**
-     * @return HasMany<TimeEntry>
-     */
-    public function timeEntries(): HasMany
-    {
-        return $this->hasMany(TimeEntry::class, 'member_id');
-    }
-
     /**
      * @return HasMany<ProjectMember>
      */

app/Providers/JetstreamServiceProvider.php

@@ -123,7 +123,6 @@ class JetstreamServiceProvider extends ServiceProvider
             'members:invite-placeholder',
             'members:change-ownership',
             'members:make-placeholder',
-            'members:merge-into',
             'members:update',
             'members:delete',
             'billing',
@@ -175,7 +174,6 @@ class JetstreamServiceProvider extends ServiceProvider
             'members:view',
             'members:update',
             'members:invite-placeholder',
-            'members:merge-into',
             'reports:view',
             'reports:create',
             'reports:update',

app/Service/ColorService.php

@@ -33,11 +33,6 @@ class ColorService
 
     private const string VALID_REGEX = '/^#[0-9a-f]{6}$/';
 
-    public function isBuiltInColor(string $color): bool
-    {
-        return in_array($color, self::COLORS, true);
-    }
-
     public function getRandomColor(?string $seed = null): string
     {
         if ($seed !== null) {

app/Service/Import/Importers/ClockifyTimeEntriesImporter.php

@@ -11,7 +11,6 @@ use App\Models\TimeEntry;
 use Carbon\Exceptions\InvalidFormatException;
 use Exception;
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Str;
 use League\Csv\Exception as CsvException;
 use League\Csv\Reader;
 
@@ -24,7 +23,7 @@ class ClockifyTimeEntriesImporter extends DefaultImporter
      */
     private function getTags(string $tags): array
     {
-        if (Str::trim($tags) === '') {
+        if (trim($tags) === '') {
             return [];
         }
         $tagsParsed = explode(', ', $tags);

app/Service/Import/Importers/GenericProjectsImporter.php

@@ -1,104 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Service\Import\Importers;
-
-use App\Service\ColorService;
-use Carbon\Exceptions\InvalidFormatException;
-use Exception;
-use Illuminate\Support\Carbon;
-use League\Csv\Exception as CsvException;
-use League\Csv\Reader;
-
-class GenericProjectsImporter extends DefaultImporter
-{
-    /**
-     * @var array<string>
-     */
-    private const array REQUIRED_FIELDS = [
-        'name',
-    ];
-
-    /**
-     * @throws ImportException
-     */
-    #[\Override]
-    public function importData(string $data, string $timezone): void
-    {
-        try {
-            $reader = Reader::createFromString($data);
-            $reader->setHeaderOffset(0);
-            $reader->setDelimiter(',');
-            $reader->setEnclosure('"');
-            $reader->setEscape('');
-            $header = $reader->getHeader();
-            $this->validateHeader($header);
-            $records = $reader->getRecords();
-            foreach ($records as $record) {
-                $clientId = null;
-                if (isset($record['client']) && $record['client'] !== '') {
-                    $clientId = $this->clientImportHelper->getKey([
-                        'name' => $record['client'],
-                        'organization_id' => $this->organization->id,
-                    ]);
-                }
-                if ($record['name'] !== '') {
-                    $archivedAt = null;
-                    if (isset($record['archived_at']) && $record['archived_at'] !== '') {
-                        try {
-                            $archivedAt = Carbon::createFromFormat('Y-m-d\TH:i:s\Z', $record['archived_at'], 'UTC');
-                        } catch (InvalidFormatException) {
-                            throw new ImportException('Value of archived_at ("'.$record['archived_at'].'") is invalid');
-                        }
-                    }
-                    $this->projectImportHelper->getKey([
-                        'name' => $record['name'],
-                        'organization_id' => $this->organization->id,
-                    ], [
-                        'color' => isset($record['color']) && $record['color'] !== '' ? $record['color'] : app(ColorService::class)->getRandomColor(),
-                        'billable_rate' => isset($record['billable_rate']) && $record['billable_rate'] !== '' ? (int) $record['billable_rate'] : null,
-                        'is_public' => isset($record['is_public']) && $record['is_public'] === 'true',
-                        'client_id' => $clientId,
-                        'is_billable' => isset($record['billable_default']) && $record['billable_default'] === 'true',
-                        'estimated_time' => isset($record['estimated_time']) && $record['estimated_time'] !== '' && is_numeric($record['estimated_time']) && ((int) $record['estimated_time'] !== 0) ? (int) $record['estimated_time'] : null,
-                        'archived_at' => $archivedAt,
-                    ]);
-                }
-            }
-        } catch (ImportException $exception) {
-            throw $exception;
-        } catch (CsvException $exception) {
-            throw new ImportException('Invalid CSV data');
-        } catch (Exception $exception) {
-            report($exception);
-            throw new ImportException('Unknown error');
-        }
-    }
-
-    /**
-     * @param  array<string>  $header
-     *
-     * @throws ImportException
-     */
-    private function validateHeader(array $header): void
-    {
-        foreach (self::REQUIRED_FIELDS as $requiredField) {
-            if (! in_array($requiredField, $header, true)) {
-                throw new ImportException('Invalid CSV header, missing field: '.$requiredField);
-            }
-        }
-    }
-
-    #[\Override]
-    public function getName(): string
-    {
-        return __('importer.generic_projects.name');
-    }
-
-    #[\Override]
-    public function getDescription(): string
-    {
-        return __('importer.generic_projects.description');
-    }
-}

app/Service/Import/Importers/GenericTimeEntriesImporter.php

@@ -1,208 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Service\Import\Importers;
-
-use App\Enums\Role;
-use App\Jobs\RecalculateSpentTimeForProject;
-use App\Jobs\RecalculateSpentTimeForTask;
-use App\Models\TimeEntry;
-use Carbon\Exceptions\InvalidFormatException;
-use Exception;
-use Illuminate\Support\Carbon;
-use Illuminate\Support\Str;
-use League\Csv\Exception as CsvException;
-use League\Csv\Reader;
-
-class GenericTimeEntriesImporter extends DefaultImporter
-{
-    /**
-     * @var array<string>
-     */
-    private const array REQUIRED_FIELDS = [
-        'description',
-        'billable',
-        'client',
-        'project',
-        'tags',
-        'start',
-        'end',
-        'task',
-        'user_name',
-        'user_email',
-    ];
-
-    /**
-     * @return array<string>
-     *
-     * @throws ImportException
-     */
-    private function getTags(string $tags): array
-    {
-        if (Str::trim($tags) === '') {
-            return [];
-        }
-        $tagsParsed = explode(',', $tags);
-        $tagIds = [];
-        foreach ($tagsParsed as $tagParsed) {
-            $tagId = $this->tagImportHelper->getKey([
-                'name' => Str::trim($tagParsed),
-                'organization_id' => $this->organization->id,
-            ]);
-            $tagIds[] = $tagId;
-        }
-
-        return $tagIds;
-    }
-
-    /**
-     * @throws ImportException
-     */
-    #[\Override]
-    public function importData(string $data, string $timezone): void
-    {
-        try {
-            $reader = Reader::createFromString($data);
-            $reader->setHeaderOffset(0);
-            $reader->setDelimiter(',');
-            $reader->setEnclosure('"');
-            $reader->setEscape('');
-            $header = $reader->getHeader();
-            $this->validateHeader($header);
-            $records = $reader->getRecords();
-            foreach ($records as $record) {
-                $userId = $this->userImportHelper->getKey([
-                    'email' => $record['user_email'],
-                ], [
-                    'name' => $record['user_name'],
-                    'timezone' => 'UTC',
-                    'is_placeholder' => true,
-                ]);
-                $memberId = $this->memberImportHelper->getKey([
-                    'user_id' => $userId,
-                    'organization_id' => $this->organization->getKey(),
-                ], [
-                    'role' => Role::Placeholder->value,
-                ]);
-                $member = $this->memberImportHelper->getModelById($memberId);
-                $clientId = null;
-                if ($record['client'] !== '') {
-                    $clientId = $this->clientImportHelper->getKey([
-                        'name' => $record['client'],
-                        'organization_id' => $this->organization->id,
-                    ]);
-                }
-                $projectId = null;
-                $project = null;
-                $projectMember = null;
-                if ($record['project'] !== '') {
-                    $projectId = $this->projectImportHelper->getKey([
-                        'name' => $record['project'],
-                        'organization_id' => $this->organization->id,
-                    ], [
-                        'client_id' => $clientId,
-                        'is_billable' => false,
-                        'color' => $this->colorService->getRandomColor(),
-                    ]);
-                    $project = $this->projectImportHelper->getModelById($projectId);
-                    $projectMember = $this->projectMemberImportHelper->getModel([
-                        'project_id' => $projectId,
-                        'member_id' => $memberId,
-                    ]);
-                }
-                $taskId = null;
-                if ($record['task'] !== '') {
-                    $taskId = $this->taskImportHelper->getKey([
-                        'name' => $record['task'],
-                        'project_id' => $projectId,
-                        'organization_id' => $this->organization->id,
-                    ]);
-                    $this->taskImportHelper->getModelById($taskId);
-                }
-                $timeEntry = new TimeEntry;
-                $timeEntry->disableAuditing();
-                $timeEntry->user_id = $userId;
-                $timeEntry->member_id = $memberId;
-                $timeEntry->task_id = $taskId;
-                $timeEntry->project_id = $projectId;
-                $timeEntry->client_id = $clientId;
-                $timeEntry->organization_id = $this->organization->id;
-                $timeEntry->description = $record['description'];
-                if (! in_array($record['billable'], ['true', 'false'], true)) {
-                    throw new ImportException('Invalid billable value');
-                }
-                $timeEntry->billable = $record['billable'] === 'true';
-                $timeEntry->tags = $this->getTags($record['tags']);
-                $timeEntry->is_imported = true;
-                try {
-                    $start = Carbon::createFromFormat('Y-m-d\TH:i:s\Z', $record['start'], 'UTC');
-                } catch (InvalidFormatException) {
-                    throw new ImportException('Value of start ("'.$record['start'].'") is invalid');
-                }
-                if ($start === null) {
-                    throw new ImportException('Value of start ("'.$record['start'].'") is invalid');
-                }
-                $timeEntry->start = $start->utc();
-
-                try {
-                    $end = Carbon::createFromFormat('Y-m-d\TH:i:s\Z', $record['end'], 'UTC');
-                } catch (InvalidFormatException) {
-                    throw new ImportException('Value of end ("'.$record['end'].'") is invalid');
-                }
-                if ($end === null) {
-                    throw new ImportException('Value of end ("'.$record['end'].'") is invalid');
-                }
-                $timeEntry->end = $end->utc();
-                $timeEntry->billable_rate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
-                    $timeEntry,
-                    $projectMember,
-                    $project,
-                    $member,
-                    $this->organization
-                );
-                $timeEntry->save();
-                $this->timeEntriesCreated++;
-            }
-            foreach ($this->projectImportHelper->getCachedModels() as $usedProject) {
-                RecalculateSpentTimeForProject::dispatch($usedProject);
-            }
-            foreach ($this->taskImportHelper->getCachedModels() as $usedTask) {
-                RecalculateSpentTimeForTask::dispatch($usedTask);
-            }
-        } catch (ImportException $exception) {
-            throw $exception;
-        } catch (CsvException $exception) {
-            throw new ImportException('Invalid CSV data');
-        } catch (Exception $exception) {
-            report($exception);
-            throw new ImportException('Unknown error');
-        }
-    }
-
-    /**
-     * @param  array<string>  $header
-     *
-     * @throws ImportException
-     */
-    private function validateHeader(array $header): void
-    {
-        foreach (self::REQUIRED_FIELDS as $requiredField) {
-            if (! in_array($requiredField, $header, true)) {
-                throw new ImportException('Invalid CSV header, missing field: '.$requiredField);
-            }
-        }
-    }
-
-    #[\Override]
-    public function getName(): string
-    {
-        return __('importer.generic_time_entries.name');
-    }
-
-    #[\Override]
-    public function getDescription(): string
-    {
-        return __('importer.generic_time_entries.description');
-    }
-}

app/Service/Import/Importers/HarvestClientsImporter.php

@@ -1,76 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Service\Import\Importers;
-
-use Exception;
-use League\Csv\Exception as CsvException;
-use League\Csv\Reader;
-
-class HarvestClientsImporter extends DefaultImporter
-{
-    /**
-     * @var array<string>
-     */
-    private const array REQUIRED_FIELDS = [
-        'Client Name',
-    ];
-
-    /**
-     * @throws ImportException
-     */
-    #[\Override]
-    public function importData(string $data, string $timezone): void
-    {
-        try {
-            $reader = Reader::createFromString($data);
-            $reader->setHeaderOffset(0);
-            $reader->setDelimiter(',');
-            $reader->setEnclosure('"');
-            $reader->setEscape('');
-            $header = $reader->getHeader();
-            $this->validateHeader($header);
-            $records = $reader->getRecords();
-            foreach ($records as $record) {
-                $this->clientImportHelper->getKey([
-                    'name' => $record['Client Name'],
-                    'organization_id' => $this->organization->id,
-                ]);
-            }
-        } catch (ImportException $exception) {
-            throw $exception;
-        } catch (CsvException $exception) {
-            throw new ImportException('Invalid CSV data');
-        } catch (Exception $exception) {
-            report($exception);
-            throw new ImportException('Unknown error');
-        }
-    }
-
-    /**
-     * @param  array<string>  $header
-     *
-     * @throws ImportException
-     */
-    private function validateHeader(array $header): void
-    {
-        foreach (self::REQUIRED_FIELDS as $requiredField) {
-            if (! in_array($requiredField, $header, true)) {
-                throw new ImportException('Invalid CSV header, missing field: '.$requiredField);
-            }
-        }
-    }
-
-    #[\Override]
-    public function getName(): string
-    {
-        return __('importer.harvest_clients.name');
-    }
-
-    #[\Override]
-    public function getDescription(): string
-    {
-        return __('importer.harvest_clients.description');
-    }
-}

app/Service/Import/Importers/HarvestProjectsImporter.php

@@ -1,107 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Service\Import\Importers;
-
-use Exception;
-use Illuminate\Support\Str;
-use League\Csv\Exception as CsvException;
-use League\Csv\Reader;
-
-class HarvestProjectsImporter extends DefaultImporter
-{
-    /**
-     * @var array<string>
-     */
-    private const array REQUIRED_FIELDS = [
-        'Client',
-        'Project',
-        'Budget',
-        'Billable Hours',
-    ];
-
-    /**
-     * @throws ImportException
-     */
-    #[\Override]
-    public function importData(string $data, string $timezone): void
-    {
-        try {
-            $reader = Reader::createFromString($data);
-            $reader->setHeaderOffset(0);
-            $reader->setDelimiter(',');
-            $reader->setEnclosure('"');
-            $reader->setEscape('');
-            $header = $reader->getHeader();
-            $this->validateHeader($header);
-            $records = $reader->getRecords();
-            foreach ($records as $record) {
-                $clientId = null;
-                if ($record['Client'] !== '') {
-                    $clientId = $this->clientImportHelper->getKey([
-                        'name' => $record['Client'],
-                        'organization_id' => $this->organization->id,
-                    ]);
-                }
-                if ($record['Project'] !== '') {
-                    if (! isset($record['Budget']) || ! is_string($record['Budget'])) {
-                        throw new ImportException('The value for "Budget" is invalid');
-                    }
-                    $estimatedTimeField = Str::replace(',', '.', $record['Budget']);
-                    $estimatedTime = $estimatedTimeField !== '' && is_numeric($estimatedTimeField) ? (int) (((float) $estimatedTimeField) * 60 * 60) : null;
-                    if ($estimatedTime === 0) {
-                        $estimatedTime = null;
-                    }
-                    if (! isset($record['Billable Hours']) || ! is_string($record['Billable Hours'])) {
-                        throw new ImportException('The value for "Billable Hours" is invalid');
-                    }
-                    $billableHoursField = Str::replace(',', '.', $record['Billable Hours']);
-                    $billableHours = $billableHoursField !== '' && is_numeric($billableHoursField) ? (int) ((float) $billableHoursField) : null;
-                    $this->projectImportHelper->getKey([
-                        'name' => $record['Project'],
-                        'organization_id' => $this->organization->id,
-                    ], [
-                        'color' => $this->colorService->getRandomColor(),
-                        'client_id' => $clientId,
-                        'estimated_time' => $estimatedTime,
-                        'is_billable' => $billableHours > 0,
-                    ]);
-                }
-            }
-        } catch (ImportException $exception) {
-            throw $exception;
-        } catch (CsvException $exception) {
-            throw new ImportException('Invalid CSV data');
-        } catch (Exception $exception) {
-            report($exception);
-            throw new ImportException('Unknown error');
-        }
-    }
-
-    /**
-     * @param  array<string>  $header
-     *
-     * @throws ImportException
-     */
-    private function validateHeader(array $header): void
-    {
-        foreach (self::REQUIRED_FIELDS as $requiredField) {
-            if (! in_array($requiredField, $header, true)) {
-                throw new ImportException('Invalid CSV header, missing field: '.$requiredField);
-            }
-        }
-    }
-
-    #[\Override]
-    public function getName(): string
-    {
-        return __('importer.harvest_projects.name');
-    }
-
-    #[\Override]
-    public function getDescription(): string
-    {
-        return __('importer.harvest_projects.description');
-    }
-}

app/Service/Import/Importers/HarvestTimeEntriesImporter.php

@@ -1,191 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Service\Import\Importers;
-
-use App\Enums\Role;
-use App\Jobs\RecalculateSpentTimeForProject;
-use App\Jobs\RecalculateSpentTimeForTask;
-use App\Models\TimeEntry;
-use Carbon\Exceptions\InvalidFormatException;
-use Exception;
-use Illuminate\Support\Carbon;
-use Illuminate\Support\Str;
-use League\Csv\Exception as CsvException;
-use League\Csv\Reader;
-use Override;
-
-class HarvestTimeEntriesImporter extends DefaultImporter
-{
-    /**
-     * @var array<string>
-     */
-    private const array REQUIRED_FIELDS = [
-        'Date',
-        'Hours',
-        'Client',
-        'Project',
-        'Task',
-        'Billable?',
-        'First Name',
-        'Last Name',
-        'Notes',
-    ];
-
-    /**
-     * @throws ImportException
-     */
-    #[Override]
-    public function importData(string $data, string $timezone): void
-    {
-        try {
-            $reader = Reader::createFromString($data);
-            $reader->setHeaderOffset(0);
-            $reader->setDelimiter(',');
-            $reader->setEnclosure('"');
-            $reader->setEscape('');
-            $header = $reader->getHeader();
-            $this->validateHeader($header);
-            $records = $reader->getRecords();
-            foreach ($records as $record) {
-                $firstname = $record['First Name'];
-                $lastname = $record['Last Name'];
-                $userId = $this->userImportHelper->getKey([
-                    'email' => Str::slug($firstname).'.'.Str::slug($lastname).'@solidtime-import.test',
-                ], [
-                    'name' => $firstname.' '.$lastname,
-                    'timezone' => 'UTC',
-                    'is_placeholder' => true,
-                ]);
-                $memberId = $this->memberImportHelper->getKey([
-                    'user_id' => $userId,
-                    'organization_id' => $this->organization->getKey(),
-                ], [
-                    'role' => Role::Placeholder->value,
-                ]);
-                $member = $this->memberImportHelper->getModelById($memberId);
-                $clientId = null;
-                if ($record['Client'] !== '') {
-                    $clientId = $this->clientImportHelper->getKey([
-                        'name' => $record['Client'],
-                        'organization_id' => $this->organization->id,
-                    ]);
-                }
-                $projectId = null;
-                $project = null;
-                $projectMember = null;
-                if ($record['Project'] !== '') {
-                    $projectId = $this->projectImportHelper->getKey([
-                        'name' => $record['Project'],
-                        'organization_id' => $this->organization->id,
-                    ], [
-                        'client_id' => $clientId,
-                        'color' => $this->colorService->getRandomColor(),
-                        'is_billable' => true,
-                    ]);
-                    $project = $this->projectImportHelper->getModelById($projectId);
-                    $projectMember = $this->projectMemberImportHelper->getModel([
-                        'project_id' => $projectId,
-                        'member_id' => $memberId,
-                    ]);
-                }
-                $taskId = null;
-                if ($record['Task'] !== '') {
-                    $taskId = $this->taskImportHelper->getKey([
-                        'name' => $record['Task'],
-                        'project_id' => $projectId,
-                        'organization_id' => $this->organization->id,
-                    ]);
-                    $this->taskImportHelper->getModelById($taskId);
-                }
-                $timeEntry = new TimeEntry;
-                $timeEntry->disableAuditing();
-                $timeEntry->user_id = $userId;
-                $timeEntry->member_id = $memberId;
-                $timeEntry->task_id = $taskId;
-                $timeEntry->project_id = $projectId;
-                $timeEntry->client_id = $clientId;
-                $timeEntry->organization_id = $this->organization->id;
-                if (strlen($record['Notes']) > 500) {
-                    throw new ImportException('Time entry note is too long');
-                }
-                $timeEntry->description = $record['Notes'];
-                if (! in_array($record['Billable?'], ['Yes', 'No'], true)) {
-                    throw new ImportException('Invalid billable value');
-                }
-                $timeEntry->billable = $record['Billable?'] === 'Yes';
-                $timeEntry->tags = [];
-                $timeEntry->is_imported = true;
-
-                // Start & End
-                try {
-                    $date = Carbon::createFromFormat('Y-m-d', $record['Date'], $timezone);
-                } catch (InvalidFormatException) {
-                    throw new ImportException('Date ("'.$record['Date'].'") is invalid');
-                }
-                if ($date === null) {
-                    throw new ImportException('Date ("'.$record['Date'].'") is invalid');
-                }
-                if (! isset($record['Hours']) || ! is_string($record['Hours'])) {
-                    throw new ImportException('Hours ("'.($record['Hours'] ?? '<null>').'") is invalid');
-                }
-                $hoursField = Str::replace(',', '.', $record['Hours']);
-                if (! is_numeric($hoursField)) {
-                    throw new ImportException('Hours ("'.$record['Hours'].'") is invalid');
-                }
-                $hours = (float) $hoursField;
-                $timeEntry->start = $date->copy()->startOfDay()->utc();
-                $timeEntry->end = $date->copy()->startOfDay()->addHours($hours)->utc();
-                $timeEntry->billable_rate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
-                    $timeEntry,
-                    $projectMember,
-                    $project,
-                    $member,
-                    $this->organization
-                );
-                $timeEntry->save();
-                $this->timeEntriesCreated++;
-            }
-            foreach ($this->projectImportHelper->getCachedModels() as $usedProject) {
-                RecalculateSpentTimeForProject::dispatch($usedProject);
-            }
-            foreach ($this->taskImportHelper->getCachedModels() as $usedTask) {
-                RecalculateSpentTimeForTask::dispatch($usedTask);
-            }
-        } catch (ImportException $exception) {
-            throw $exception;
-        } catch (CsvException $exception) {
-            throw new ImportException('Invalid CSV data');
-        } catch (Exception $exception) {
-            report($exception);
-            throw new ImportException('Unknown error');
-        }
-    }
-
-    /**
-     * @param  array<string>  $header
-     *
-     * @throws ImportException
-     */
-    private function validateHeader(array $header): void
-    {
-        foreach (self::REQUIRED_FIELDS as $requiredField) {
-            if (! in_array($requiredField, $header, true)) {
-                throw new ImportException('Invalid CSV header, missing field: '.$requiredField);
-            }
-        }
-    }
-
-    #[Override]
-    public function getName(): string
-    {
-        return __('importer.harvest_time_entries.name');
-    }
-
-    #[Override]
-    public function getDescription(): string
-    {
-        return __('importer.harvest_time_entries.description');
-    }
-}

app/Service/Import/Importers/ImporterProvider.php

@@ -15,11 +15,6 @@ class ImporterProvider
         'clockify_time_entries' => ClockifyTimeEntriesImporter::class,
         'clockify_projects' => ClockifyProjectsImporter::class,
         'solidtime' => SolidtimeImporter::class,
-        'harvest_projects' => HarvestProjectsImporter::class,
-        'harvest_time_entries' => HarvestTimeEntriesImporter::class,
-        'harvest_clients' => HarvestClientsImporter::class,
-        'generic_projects' => GenericProjectsImporter::class,
-        'generic_time_entries' => GenericTimeEntriesImporter::class,
     ];
 
     /**

app/Service/Import/Importers/SolidtimeImporter.php

@@ -328,7 +328,7 @@ class SolidtimeImporter extends DefaultImporter
      */
     private function getTags(string $tags): array
     {
-        if (Str::trim($tags) === '') {
+        if (trim($tags) === '') {
             return [];
         }
         $tagsParsed = json_decode($tags);

app/Service/Import/Importers/TogglDataImporter.php

@@ -5,11 +5,8 @@ declare(strict_types=1);
 namespace App\Service\Import\Importers;
 
 use App\Enums\Role;
-use App\Service\TimezoneService;
 use Exception;
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Facades\Log;
-use Illuminate\Support\Str;
 use Override;
 use Spatie\TemporaryDirectory\TemporaryDirectory;
 use ValueError;
@@ -96,22 +93,11 @@ class TogglDataImporter extends DefaultImporter
             }
 
             foreach ($workspaceUsers as $workspaceUser) {
-                $timezone = Str::trim($workspaceUser->timezone);
-                if ($timezone === '') {
-                    $timezone = 'UTC';
-                }
-                if (! app(TimezoneService::class)->isValid($timezone)) {
-                    Log::warning('TogglDateImporter: Invalid timezone', [
-                        'timezone' => $timezone,
-                    ]);
-                    $timezone = 'UTC';
-                }
-
                 $userId = $this->userImportHelper->getKey([
                     'email' => $workspaceUser->email,
                 ], [
                     'name' => $workspaceUser->name,
-                    'timezone' => $timezone,
+                    'timezone' => $workspaceUser->timezone ?? 'UTC',
                     'is_placeholder' => true,
                 ], (string) $workspaceUser->uid);
                 $this->memberImportHelper->getKey([

app/Service/Import/Importers/TogglTimeEntriesImporter.php

@@ -11,7 +11,6 @@ use App\Models\TimeEntry;
 use Carbon\Exceptions\InvalidFormatException;
 use Exception;
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Str;
 use League\Csv\Exception as CsvException;
 use League\Csv\Reader;
 
@@ -24,7 +23,7 @@ class TogglTimeEntriesImporter extends DefaultImporter
      */
     private function getTags(string $tags): array
     {
-        if (Str::trim($tags) === '') {
+        if (trim($tags) === '') {
             return [];
         }
         $tagsParsed = explode(', ', $tags);

app/Service/MemberService.php

@@ -7,18 +7,15 @@ namespace App\Service;
 use App\Enums\Role;
 use App\Events\MemberRemoved;
 use App\Exceptions\Api\CanNotRemoveOwnerFromOrganization;
-use App\Exceptions\Api\ChangingRoleOfPlaceholderIsNotAllowed;
 use App\Exceptions\Api\ChangingRoleToPlaceholderIsNotAllowed;
 use App\Exceptions\Api\EntityStillInUseApiException;
 use App\Exceptions\Api\OnlyOwnerCanChangeOwnership;
 use App\Exceptions\Api\OrganizationNeedsAtLeastOneOwner;
 use App\Models\Member;
 use App\Models\Organization;
-use App\Models\Project;
 use App\Models\ProjectMember;
 use App\Models\TimeEntry;
 use App\Models\User;
-use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Support\Facades\DB;
 use InvalidArgumentException;
 use Laravel\Jetstream\Events\AddingTeamMember;
@@ -78,7 +75,6 @@ class MemberService
      * @throws ChangingRoleToPlaceholderIsNotAllowed
      * @throws OnlyOwnerCanChangeOwnership
      * @throws OrganizationNeedsAtLeastOneOwner
-     * @throws ChangingRoleOfPlaceholderIsNotAllowed
      */
     public function changeRole(Member $member, Organization $organization, Role $newRole, bool $allowOwnerChange): void
     {
@@ -86,9 +82,6 @@ class MemberService
         if ($oldRole === Role::Owner) {
             throw new OrganizationNeedsAtLeastOneOwner;
         }
-        if ($oldRole === Role::Placeholder) {
-            throw new ChangingRoleOfPlaceholderIsNotAllowed;
-        }
         if ($newRole === Role::Placeholder) {
             throw new ChangingRoleToPlaceholderIsNotAllowed;
         }
@@ -103,39 +96,6 @@ class MemberService
         }
     }
 
-    public function assignOrganizationEntitiesToDifferentMember(Organization $organization, Member $fromMember, Member $toMember): void
-    {
-        // Time entries
-        TimeEntry::query()
-            ->whereBelongsTo($organization, 'organization')
-            ->whereBelongsTo($fromMember, 'member')
-            ->update([
-                'user_id' => $toMember->user_id,
-                'member_id' => $toMember->getKey(),
-            ]);
-
-        // Project members
-        ProjectMember::query()
-            ->whereBelongsToOrganization($organization)
-            ->whereBelongsTo($fromMember, 'member')
-            ->whereDoesntHave('project', function (Builder $builder) use ($toMember): void {
-                /** @var Builder<Project> $builder */
-                $builder->whereHas('members', function (Builder $builder) use ($toMember): void {
-                    /** @var Builder<ProjectMember> $builder */
-                    $builder->where('member_id', $toMember->getKey());
-                });
-            })
-            ->update([
-                'user_id' => $toMember->user_id,
-                'member_id' => $toMember->getKey(),
-            ]);
-
-        ProjectMember::query()
-            ->whereBelongsToOrganization($organization)
-            ->whereBelongsTo($fromMember, 'member')
-            ->delete();
-    }
-
     /**
      * Change the ownership of an organization to a new user.
      * The previous owner will be demoted to an admin.
@@ -172,7 +132,7 @@ class MemberService
         $member->role = Role::Placeholder->value;
         $member->save();
 
-        $this->userService->assignOrganizationEntitiesToDifferentUser($member->organization, $user, $placeholderUser);
+        $this->userService->assignOrganizationEntitiesToDifferentMember($member->organization, $user, $placeholderUser, $member);
         if ($makeSureUserHasAtLeastOneOrganization) {
             $this->userService->makeSureUserHasAtLeastOneOrganization($user);
         }

app/Service/UserService.php

@@ -49,10 +49,24 @@ class UserService
     }
 
     /**
-     * This does NOT change the member id.
-     * This should only be used in if you want to change a member to a placeholder!
+     * Assign all organization entities (time entries, project members) from one user to another.
+     * This is useful when a placeholder user is replaced with a real user.
      */
     public function assignOrganizationEntitiesToDifferentUser(Organization $organization, User $fromUser, User $toUser): void
+    {
+        /** @var Member|null $toMember */
+        $toMember = Member::query()
+            ->whereBelongsTo($organization, 'organization')
+            ->whereBelongsTo($toUser, 'user')
+            ->first();
+        if ($toMember === null) {
+            throw new \InvalidArgumentException('User is not a member of the organization');
+        }
+
+        $this->assignOrganizationEntitiesToDifferentMember($organization, $fromUser, $toUser, $toMember);
+    }
+
+    public function assignOrganizationEntitiesToDifferentMember(Organization $organization, User $fromUser, User $toUser, Member $toMember): void
     {
         // Time entries
         TimeEntry::query()
@@ -60,6 +74,7 @@ class UserService
             ->whereBelongsTo($fromUser, 'user')
             ->update([
                 'user_id' => $toUser->getKey(),
+                'member_id' => $toMember->getKey(),
             ]);
 
         // Project members
@@ -68,6 +83,7 @@ class UserService
             ->whereBelongsTo($fromUser, 'user')
             ->update([
                 'user_id' => $toUser->getKey(),
+                'member_id' => $toMember->getKey(),
             ]);
     }
 

config/passport.php

@@ -15,7 +15,7 @@ return [
     |
     */
 
-    'guard' => 'web',
+    'guard' => 'api',
 
     /*
     |--------------------------------------------------------------------------

docker/prod/Dockerfile

@@ -182,7 +182,7 @@ COPY --chown=${USER}:${USER} ${DOCKER_FILES_BASE_PATH}deployment/php.ini /lib/ph
 #    && composer clear-cache
 
 RUN cat .env
-#RUN php artisan env
+RUN php artisan env
 RUN php artisan storage:link
 
 RUN chmod +x /usr/local/bin/start-container

lang/en/exceptions.php

@@ -4,18 +4,15 @@ declare(strict_types=1);
 
 use App\Exceptions\Api\CanNotDeleteUserWhoIsOwnerOfOrganizationWithMultipleMembers;
 use App\Exceptions\Api\CanNotRemoveOwnerFromOrganization;
-use App\Exceptions\Api\ChangingRoleOfPlaceholderIsNotAllowed;
 use App\Exceptions\Api\ChangingRoleToPlaceholderIsNotAllowed;
 use App\Exceptions\Api\EntityStillInUseApiException;
 use App\Exceptions\Api\FeatureIsNotAvailableInFreePlanApiException;
 use App\Exceptions\Api\InactiveUserCanNotBeUsedApiException;
 use App\Exceptions\Api\OnlyOwnerCanChangeOwnership;
-use App\Exceptions\Api\OnlyPlaceholdersCanBeMergedIntoAnotherMember;
 use App\Exceptions\Api\OrganizationHasNoSubscriptionButMultipleMembersException;
 use App\Exceptions\Api\OrganizationNeedsAtLeastOneOwner;
 use App\Exceptions\Api\PdfRendererIsNotConfiguredException;
 use App\Exceptions\Api\PersonalAccessClientIsNotConfiguredException;
-use App\Exceptions\Api\ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException;
 use App\Exceptions\Api\TimeEntryCanNotBeRestartedApiException;
 use App\Exceptions\Api\TimeEntryStillRunningApiException;
 use App\Exceptions\Api\UserIsAlreadyMemberOfOrganizationApiException;
@@ -42,9 +39,6 @@ return [
         PdfRendererIsNotConfiguredException::KEY => 'PDF renderer is not configured',
         FeatureIsNotAvailableInFreePlanApiException::KEY => 'Feature is not available in free plan',
         PersonalAccessClientIsNotConfiguredException::KEY => 'Personal access client is not configured',
-        ChangingRoleOfPlaceholderIsNotAllowed::KEY => 'Changing role of placeholder is not allowed',
-        OnlyPlaceholdersCanBeMergedIntoAnotherMember::KEY => 'Only placeholders can be merged into another member',
-        ThisPlaceholderCanNotBeInvitedUseTheMergeToolInsteadException::KEY => 'This placeholder can not be invited use the merge tool instead',
     ],
     'unknown_error_in_admin_panel' => 'An unknown error occurred. Please check the logs.',
 ];

lang/en/importer.php

@@ -13,14 +13,6 @@ return [
             '<br> 4. Now click Export -> Save as CSV. The Export dropdown is in the header of the export table left of the printer symbol. '.
             '<br><br>Before you import make sure that the Timezone settings in Clockify are the same as in solidtime.',
     ],
-    'generic_projects' => [
-        'name' => 'Generic Projects',
-        'description' => 'If you want to import many projects yourself this importer the right choice. Please see our docs for <a href="https://docs.solidtime.io/user-guide/import">more information about the CSV structure</a>',
-    ],
-    'generic_time_entries' => [
-        'name' => 'Generic Time Entries',
-        'description' => 'If you want to import many time entries yourself this importer the right choice. Please see our docs for <a href="https://docs.solidtime.io/user-guide/import">more information about the CSV structure</a>',
-    ],
     'clockify_projects' => [
         'name' => 'Clockify Projects',
         'description' => '1. Make sure to set the language of Clockify to English in "Preferences -> General".<br>'.
@@ -46,22 +38,4 @@ return [
         'name' => 'Solidtime',
         'description' => '1. Choose the organization you want to export in dropdown in the left top corner<br>2. Click on "Export" in the left navigation under "Admin" (You need to be Admin or Owner of the organization to see this)<br>3. Click on "Export". <br>4. Save the file and upload it here.',
     ],
-    'harvest_clients' => [
-        'name' => 'Harvest Clients',
-        'description' => '1. Go to "Manage" (top navigation)<br>2. Click on the "Clients"'.
-            '<br>3. Click on "Import/Export" and in the dropdown "Export clients to CSV" '.
-            '<br>',
-    ],
-    'harvest_projects' => [
-        'name' => 'Harvest Projects',
-        'description' => '1. Go to "Projects" (top navigation)<br>2. Click on the "Export" button'.
-            '<br>3. Select which projects you would like to export and select CSV format '.
-            '<br><br>Before you import make sure that the Timezone settings in Harvest are the same as in solidtime.',
-    ],
-    'harvest_time_entries' => [
-        'name' => 'Harvest Time Entries',
-        'description' => '1. Go to Settings (right top corner)<br>2. Click on "Import/Export" in the left navigation'.
-            '<br>3. Now click on "Export all time" '.
-            '<br><br>Before you import make sure that the Timezone settings in Harvest are the same as in solidtime.',
-    ],
 ];

resources/js/Components/Common/Member/MemberMergeModal.vue

@@ -1,109 +0,0 @@
-<script setup lang="ts">
-import SecondaryButton from '@/packages/ui/src/Buttons/SecondaryButton.vue';
-import DialogModal from '@/packages/ui/src/DialogModal.vue';
-import { ref } from 'vue';
-import {api, type Member} from '@/packages/api/src';
-import PrimaryButton from '@/packages/ui/src/Buttons/PrimaryButton.vue';
-import MemberCombobox from "@/Components/Common/Member/MemberCombobox.vue";
-import {UserIcon, ArrowRightIcon} from "@heroicons/vue/24/solid";
-import {Badge} from "@/packages/ui/src";
-import { useMutation } from '@tanstack/vue-query';
-import {getCurrentOrganizationId} from "@/utils/useUser";
-import {useNotificationsStore} from "@/utils/notification";
-const { handleApiRequestNotifications, addNotification } = useNotificationsStore();
-
-const show = defineModel('show', { default: false });
-const saving = ref(false);
-
-const props = defineProps<{
-    member: Member;
-}>();
-
-const newMember = ref<string>('');
-
-const mergeMember = useMutation({
-    mutationFn: async (newMemberId: string) => {
-        const organizationId = getCurrentOrganizationId();
-        if (organizationId === null) {
-            throw new Error('No current organization id - create report');
-        }
-        return await api.mergeMember({
-            member_id: newMemberId,
-        }, {
-            params: {
-                organization: organizationId,
-                member: props.member.id
-            },
-        });
-    },
-});
-
-async function submit() {
-    const newMemberId = newMember.value;
-    if(newMemberId !== ''){
-        saving.value = true;
-        await handleApiRequestNotifications(
-            () =>
-                mergeMember.mutateAsync(newMemberId),
-            'Members successfully merged!',
-            'There was an error merging the members.',
-            () => {
-                show.value = false;
-            }
-        );
-    }
-    else{
-        addNotification(
-            'error',
-            'Please select a member to merge into.',
-        );
-    }
-
-}
-
-</script>
-
-<template>
-    <DialogModal closeable :show="show" @close="show = false">
-        <template #title>
-            <div class="flex space-x-2">
-                <span> Merge Member </span>
-            </div>
-        </template>
-
-        <template #content>
-            <p>Merging the user <strong>{{ member.name }} </strong> into another one will transfer all time entries to the new user. <strong>This cannot be reverted!</strong></p>
-            <div class="py-5 flex flex-col md:flex-row gap-6 items-center">
-                <div class="flex-1">
-                    <Badge class="flex w-full text-base text-left space-x-3 px-3 text-text-secondary font-normal cursor py-1.5">
-                        <UserIcon class="relative z-10 w-4 text-muted"></UserIcon>
-                        <div class="flex-1 font-medium truncate">
-                            {{ member.name }}
-                        </div>
-                    </Badge>
-                </div>
-                <div>
-                    <ArrowRightIcon class="relative z-10 w-4 text-muted"></ArrowRightIcon>
-                </div>
-                <div class="flex-1">
-                    <MemberCombobox
-                        v-model="newMember"
-                    ></MemberCombobox>
-                </div>
-            </div>
-        </template>
-        <template #footer>
-            <SecondaryButton @click="show = false"> Cancel</SecondaryButton>
-
-            <PrimaryButton
-                class="ms-3"
-                :class="{ 'opacity-25': saving }"
-                :disabled="saving"
-                @click="submit()">
-                Merge Member
-            </PrimaryButton>
-        </template>
-    </DialogModal>
-</template>
-
-<style scoped></style>

resources/js/Components/Common/Member/MemberMoreOptionsDropdown.vue

@@ -1,18 +1,16 @@
 <script setup lang="ts">
-import { TrashIcon, PencilSquareIcon, ArrowDownOnSquareStackIcon } from '@heroicons/vue/20/solid';
+import { TrashIcon, PencilSquareIcon } from '@heroicons/vue/20/solid';
 import type { Member } from '@/packages/api/src';
-import {canDeleteMembers, canMergeMembers, canUpdateMembers} from '@/utils/permissions';
+import { canDeleteMembers, canUpdateMembers } from '@/utils/permissions';
 import MoreOptionsDropdown from '@/packages/ui/src/MoreOptionsDropdown.vue';
 
 const emit = defineEmits<{
     delete: [];
     edit: [];
-    merge: [];
 }>();
 const props = defineProps<{
     member: Member;
 }>();
-
 </script>
 
 <template>
@@ -38,15 +36,6 @@ const props = defineProps<{
                 <TrashIcon class="w-5 text-icon-active"></TrashIcon>
                 <span>Delete</span>
             </button>
-            <button
-                v-if="props.member.role === 'placeholder' && canMergeMembers()"
-                :aria-label="'Merge Member ' + props.member.name"
-                data-testid="member_merge"
-                class="flex items-center space-x-3 w-full px-3 py-2.5 text-start text-sm font-medium leading-5 text-white hover:bg-card-background-active focus:outline-none focus:bg-card-background-active transition duration-150 ease-in-out"
-                @click="emit('merge')">
-                <ArrowDownOnSquareStackIcon class="w-5 text-icon-active"></ArrowDownOnSquareStackIcon>
-                <span>Merge</span>
-            </button>
         </div>
     </MoreOptionsDropdown>
 </template>

resources/js/Components/Common/Member/MemberTableRow.vue

@@ -10,18 +10,16 @@ import { getCurrentOrganizationId } from '@/utils/useUser';
 import { useNotificationsStore } from '@/utils/notification';
 import { canInvitePlaceholderMembers } from '@/utils/permissions';
 import { useMembersStore } from '@/utils/useMembers';
-import {computed, ref} from 'vue';
+import { ref } from 'vue';
 import MemberEditModal from '@/Components/Common/Member/MemberEditModal.vue';
 import { getOrganizationCurrencyString } from '@/utils/money';
 import { formatCents } from '@/packages/ui/src/utils/money';
-import MemberMergeModal from "@/Components/Common/Member/MemberMergeModal.vue";
 
 const props = defineProps<{
     member: Member;
 }>();
 
 const showEditMemberModal = ref(false);
-const showMergeMemberModal = ref(false);
 
 function removeMember() {
     useMembersStore().removeMember(props.member.id);
@@ -47,11 +45,6 @@ async function invitePlaceholder(id: string) {
         );
     }
 }
-
-const userHasValidMailAddress = computed(() => {
-    return !props.member.email.endsWith('@solidtime-import.test');
-})
-
 </script>
 
 <template>
@@ -94,8 +87,7 @@ const userHasValidMailAddress = computed(() => {
             <SecondaryButton
                 v-if="
                     member.is_placeholder === true &&
-                    canInvitePlaceholderMembers() &&
-                    userHasValidMailAddress
+                    canInvitePlaceholderMembers()
                 "
                 size="small"
                 @click="invitePlaceholder(member.id)"
@@ -104,14 +96,11 @@ const userHasValidMailAddress = computed(() => {
             <MemberMoreOptionsDropdown
                 :member="member"
                 @edit="showEditMemberModal = true"
-                @delete="removeMember"
-                @merge="showMergeMemberModal = true"
-            ></MemberMoreOptionsDropdown>
+                @delete="removeMember"></MemberMoreOptionsDropdown>
         </div>
         <MemberEditModal
             v-model:show="showEditMemberModal"
             :member="member"></MemberEditModal>
-        <MemberMergeModal v-model:show="showMergeMemberModal" :member="member"></MemberMergeModal>
     </TableRow>
 </template>
 

resources/js/Pages/Profile/Partials/ApiTokensForm.vue

@@ -45,6 +45,7 @@ async function createApiToken(){
         (response) => {
             createApiTokenForm.name = '';
             displayingToken.value = true;
+            // @ts-expect-error temporary fix until openapi docs type is fixed
             newToken.value = response.data.access_token;
         }
     );
@@ -116,7 +117,7 @@ const deleteApiTokenMutation = useMutation({
     mutationFn: async (apiTokenId: string) => {
         return await api.deleteApiToken(undefined, {
             params: {
-                apiToken: apiTokenId,
+                apiTokenId: apiTokenId,
             },
         });
     },
@@ -129,7 +130,7 @@ const revokeApiTokenMutation = useMutation({
     mutationFn: async (apiTokenId: string) => {
         return await api.revokeApiToken(undefined, {
             params: {
-                apiToken: apiTokenId,
+                apiTokenId: apiTokenId,
             },
         });
     },

resources/js/packages/api/src/openapi.json.client.ts

@@ -5,9 +5,9 @@ const ApiTokenResource = z
     .object({
         id: z.string(),
         name: z.string(),
-        revoked: z.boolean(),
-        scopes: z.array(z.string()),
-        created_at: z.string(),
+        revoked: z.string(),
+        scopes: z.string(),
+        created_at: z.union([z.string(), z.null()]),
         expires_at: z.union([z.string(), z.null()]),
     })
     .passthrough();
@@ -15,17 +15,7 @@ const ApiTokenCollection = z.array(ApiTokenResource);
 const ApiTokenStoreRequest = z
     .object({ name: z.string().min(1).max(255) })
     .passthrough();
-const ApiTokenWithAccessTokenResource = z
-    .object({
-        id: z.string(),
-        name: z.string(),
-        revoked: z.boolean(),
-        scopes: z.array(z.string()),
-        created_at: z.string(),
-        expires_at: z.union([z.string(), z.null()]),
-        access_token: z.string(),
-    })
-    .passthrough();
+const ApiTokenWithAccessTokenResource = z.string();
 const ClientResource = z
     .object({
         id: z.string(),
@@ -73,10 +63,6 @@ const MemberUpdateRequest = z
     .object({ role: Role, billable_rate: z.union([z.number(), z.null()]) })
     .partial()
     .passthrough();
-const MemberMergeIntoRequest = z
-    .object({ member_id: z.string() })
-    .partial()
-    .passthrough();
 const OrganizationResource = z
     .object({
         id: z.string(),
@@ -94,28 +80,6 @@ const OrganizationUpdateRequest = z
         employees_can_see_billable_rates: z.boolean().optional(),
     })
     .passthrough();
-const VersionRequest = z
-    .object({
-        version: z.string().max(255),
-        build: z.string().max(255),
-        url: z.string().max(255),
-    })
-    .passthrough();
-const TelemetryRequest = z
-    .object({
-        version: z.string().max(255),
-        build: z.string().max(255),
-        url: z.string().max(255).url(),
-        user_count: z.number().int(),
-        organization_count: z.number().int(),
-        audit_count: z.number().int(),
-        project_count: z.number().int(),
-        project_member_count: z.number().int(),
-        client_count: z.number().int(),
-        task_count: z.number().int(),
-        time_entry_count: z.number().int(),
-    })
-    .passthrough();
 const ProjectResource = z
     .object({
         id: z.string(),
@@ -522,11 +486,8 @@ export const schemas = {
     MemberResource,
     Role,
     MemberUpdateRequest,
-    MemberMergeIntoRequest,
     OrganizationResource,
     OrganizationUpdateRequest,
-    VersionRequest,
-    TelemetryRequest,
     ProjectResource,
     ProjectStoreRequest,
     ProjectUpdateRequest,
@@ -1199,71 +1160,6 @@ const endpoints = makeApi([
             },
         ],
     },
-    {
-        method: 'post',
-        path: '/v1/organizations/:organization/member/:member/merge-into',
-        alias: 'mergeMember',
-        requestFormat: 'json',
-        parameters: [
-            {
-                name: 'body',
-                type: 'Body',
-                schema: z
-                    .object({ member_id: z.string() })
-                    .partial()
-                    .passthrough(),
-            },
-            {
-                name: 'organization',
-                type: 'Path',
-                schema: z.string(),
-            },
-            {
-                name: 'member',
-                type: 'Path',
-                schema: z.string(),
-            },
-        ],
-        response: z.null(),
-        errors: [
-            {
-                status: 400,
-                description: `API exception`,
-                schema: z
-                    .object({
-                        error: z.boolean(),
-                        key: z.string(),
-                        message: z.string(),
-                    })
-                    .passthrough(),
-            },
-            {
-                status: 401,
-                description: `Unauthenticated`,
-                schema: z.object({ message: z.string() }).passthrough(),
-            },
-            {
-                status: 403,
-                description: `Authorization error`,
-                schema: z.object({ message: z.string() }).passthrough(),
-            },
-            {
-                status: 404,
-                description: `Not found`,
-                schema: z.object({ message: z.string() }).passthrough(),
-            },
-            {
-                status: 422,
-                description: `Validation error`,
-                schema: z
-                    .object({
-                        message: z.string(),
-                        errors: z.record(z.array(z.string())),
-                    })
-                    .passthrough(),
-            },
-        ],
-    },
     {
         method: 'get',
         path: '/v1/organizations/:organization/members',
@@ -3498,58 +3394,6 @@ If the group parameters are all set to `null` or are all missing, the
             },
         ],
     },
-    {
-        method: 'post',
-        path: '/v1/ping/telemetry',
-        alias: 'v1.ping.telemetry',
-        requestFormat: 'json',
-        parameters: [
-            {
-                name: 'body',
-                type: 'Body',
-                schema: TelemetryRequest,
-            },
-        ],
-        response: z.object({ success: z.boolean() }).passthrough(),
-        errors: [
-            {
-                status: 422,
-                description: `Validation error`,
-                schema: z
-                    .object({
-                        message: z.string(),
-                        errors: z.record(z.array(z.string())),
-                    })
-                    .passthrough(),
-            },
-        ],
-    },
-    {
-        method: 'post',
-        path: '/v1/ping/version',
-        alias: 'v1.ping.version',
-        requestFormat: 'json',
-        parameters: [
-            {
-                name: 'body',
-                type: 'Body',
-                schema: VersionRequest,
-            },
-        ],
-        response: z.object({ version: z.string() }).passthrough(),
-        errors: [
-            {
-                status: 422,
-                description: `Validation error`,
-                schema: z
-                    .object({
-                        message: z.string(),
-                        errors: z.record(z.array(z.string())),
-                    })
-                    .passthrough(),
-            },
-        ],
-    },
     {
         method: 'get',
         path: '/v1/public/reports',
@@ -3627,17 +3471,6 @@ Please note that the access token is only shown in this response and cannot be r
             .object({ data: ApiTokenWithAccessTokenResource })
             .passthrough(),
         errors: [
-            {
-                status: 400,
-                description: `API exception`,
-                schema: z
-                    .object({
-                        error: z.boolean(),
-                        key: z.string(),
-                        message: z.string(),
-                    })
-                    .passthrough(),
-            },
             {
                 status: 401,
                 description: `Unauthenticated`,
@@ -3662,29 +3495,18 @@ Please note that the access token is only shown in this response and cannot be r
     },
     {
         method: 'delete',
-        path: '/v1/users/me/api-tokens/:apiToken',
+        path: '/v1/users/me/api-tokens/:apiTokenId',
         alias: 'deleteApiToken',
         requestFormat: 'json',
         parameters: [
             {
-                name: 'apiToken',
+                name: 'apiTokenId',
                 type: 'Path',
                 schema: z.string(),
             },
         ],
         response: z.null(),
         errors: [
-            {
-                status: 400,
-                description: `API exception`,
-                schema: z
-                    .object({
-                        error: z.boolean(),
-                        key: z.string(),
-                        message: z.string(),
-                    })
-                    .passthrough(),
-            },
             {
                 status: 401,
                 description: `Unauthenticated`,
@@ -3695,38 +3517,22 @@ Please note that the access token is only shown in this response and cannot be r
                 description: `Authorization error`,
                 schema: z.object({ message: z.string() }).passthrough(),
             },
-            {
-                status: 404,
-                description: `Not found`,
-                schema: z.object({ message: z.string() }).passthrough(),
-            },
         ],
     },
     {
         method: 'post',
-        path: '/v1/users/me/api-tokens/:apiToken/revoke',
+        path: '/v1/users/me/api-tokens/:apiTokenId/revoke',
         alias: 'revokeApiToken',
         requestFormat: 'json',
         parameters: [
             {
-                name: 'apiToken',
+                name: 'apiTokenId',
                 type: 'Path',
                 schema: z.string(),
             },
         ],
         response: z.null(),
         errors: [
-            {
-                status: 400,
-                description: `API exception`,
-                schema: z
-                    .object({
-                        error: z.boolean(),
-                        key: z.string(),
-                        message: z.string(),
-                    })
-                    .passthrough(),
-            },
             {
                 status: 401,
                 description: `Unauthenticated`,
@@ -3737,11 +3543,6 @@ Please note that the access token is only shown in this response and cannot be r
                 description: `Authorization error`,
                 schema: z.object({ message: z.string() }).passthrough(),
             },
-            {
-                status: 404,
-                description: `Not found`,
-                schema: z.object({ message: z.string() }).passthrough(),
-            },
         ],
     },
     {

resources/js/packages/ui/src/Input/DatePicker.vue

@@ -8,7 +8,6 @@ import { twMerge } from 'tailwind-merge';
 
 const props = defineProps<{
     class?: string;
-    tabindex?: string;
 }>();
 
 // This has to be a localized timestamp, not UTC
@@ -51,7 +50,6 @@ const emit = defineEmits(['changed']);
         <input
             id="start"
             ref="datePicker"
-            :tabindex="tabindex"
             :class="
                 twMerge(
                     'bg-input-background border text-white border-input-border focus-visible:outline-0 focus-visible:border-input-border-active focus-visible:ring-0 rounded-md',

resources/js/packages/ui/src/Tag/TagDropdown.vue

@@ -6,7 +6,6 @@ import TagCreateModal from '@/packages/ui/src/Tag/TagCreateModal.vue';
 import MultiselectDropdownItem from '@/packages/ui/src/Input/MultiselectDropdownItem.vue';
 import type { Tag } from '@/packages/api/src';
 import type { Placement } from '@floating-ui/vue';
-import {UseFocusTrap} from "@vueuse/integrations/useFocusTrap/component";
 
 const props = withDefaults(
     defineProps<{
@@ -178,50 +177,46 @@ const showCreateTagModal = ref(false);
             <slot name="trigger"></slot>
         </template>
         <template #content>
-            <UseFocusTrap
-                v-if="open"
-                :options="{ immediate: true, allowOutsideClick: true }">
-                <input
-                    ref="searchInput"
-                    :value="searchValue"
-                    data-testid="tag_dropdown_search"
-                    class="bg-card-background border-0 placeholder-muted text-sm text-white py-2.5 focus:ring-0 border-b border-card-background-separator focus:border-card-background-separator w-full"
-                    placeholder="Search for a Tag..."
-                    @input="updateSearchValue"
-                    @keydown.enter="addTagIfNoneExists"
-                    @keydown.up.prevent="moveHighlightUp"
-                    @keydown.down.prevent="moveHighlightDown" />
-                <div ref="dropdownViewport" class="w-60 max-h-60 overflow-y-scroll">
-                    <div
-                        v-for="tag in filteredTags"
-                        :key="tag.id"
-                        role="option"
-                        :value="tag.id"
-                        :class="{
+            <input
+                ref="searchInput"
+                :value="searchValue"
+                data-testid="tag_dropdown_search"
+                class="bg-card-background border-0 placeholder-muted text-sm text-white py-2.5 focus:ring-0 border-b border-card-background-separator focus:border-card-background-separator w-full"
+                placeholder="Search for a Tag..."
+                @input="updateSearchValue"
+                @keydown.enter="addTagIfNoneExists"
+                @keydown.up.prevent="moveHighlightUp"
+                @keydown.down.prevent="moveHighlightDown" />
+            <div ref="dropdownViewport" class="w-60 max-h-60 overflow-y-scroll">
+                <div
+                    v-for="tag in filteredTags"
+                    :key="tag.id"
+                    role="option"
+                    :value="tag.id"
+                    :class="{
                         'bg-card-background-active':
                             tag.id === highlightedItemId,
                     }"
-                        data-testid="tag_dropdown_entries"
-                        :data-tag-id="tag.id">
-                        <MultiselectDropdownItem
-                            :selected="isTagSelected(tag.id)"
-                            :name="tag.name"
-                            @click="toggleTag(tag.id)"></MultiselectDropdownItem>
-                    </div>
+                    data-testid="tag_dropdown_entries"
+                    :data-tag-id="tag.id">
+                    <MultiselectDropdownItem
+                        :selected="isTagSelected(tag.id)"
+                        :name="tag.name"
+                        @click="toggleTag(tag.id)"></MultiselectDropdownItem>
                 </div>
-                <div class="hover:bg-card-background-active rounded-b-lg">
-                    <button
-                        class="text-white w-full flex space-x-3 items-center px-4 py-3 text-xs font-semibold border-t border-card-background-separator"
-                        @click="
+            </div>
+            <div class="hover:bg-card-background-active rounded-b-lg">
+                <button
+                    class="text-white w-full flex space-x-3 items-center px-4 py-3 text-xs font-semibold border-t border-card-background-separator"
+                    @click="
                         open = false;
                         showCreateTagModal = true;
                     ">
-                        <PlusCircleIcon
-                            class="w-5 flex-shrink-0 text-icon-default"></PlusCircleIcon>
-                        <span>Create new Tag</span>
-                    </button>
-                </div>
-            </UseFocusTrap>
+                    <PlusCircleIcon
+                        class="w-5 flex-shrink-0 text-icon-default"></PlusCircleIcon>
+                    <span>Create new Tag</span>
+                </button>
+            </div>
         </template>
     </Dropdown>
 </template>

resources/js/packages/ui/src/TimeEntry/TimeEntryCreateModal.vue

@@ -18,6 +18,7 @@ import type {
     Client,
     CreateTimeEntryBody,
 } from '@/packages/api/src';
+import TimePicker from '@/packages/ui/src/Input/TimePicker.vue';
 import { getOrganizationCurrencyString } from '@/utils/money';
 import { canCreateProjects } from '@/utils/permissions';
 import TagDropdown from '@/packages/ui/src/Tag/TagDropdown.vue';
@@ -29,7 +30,6 @@ import DurationHumanInput from '@/packages/ui/src/Input/DurationHumanInput.vue';
 
 import { InformationCircleIcon } from '@heroicons/vue/20/solid';
 import type { Tag, Task } from '@/packages/api/src';
-import TimePickerSimple from "@/packages/ui/src/Input/TimePickerSimple.vue";
 
 const show = defineModel('show', { default: false });
 const saving = ref(false);
@@ -244,34 +244,30 @@ type BillableOption = {
                 <div class="">
                     <InputLabel>Start</InputLabel>
                     <div class="flex flex-col items-center space-y-2 mt-1">
-                        <TimePickerSimple
-
+                        <TimePicker
                             v-model="localStart"
-                            size="large"></TimePickerSimple>
+                            size="large"></TimePicker>
                         <DatePicker
                             v-model="localStart"
-                            tabindex="1"
                             class="text-xs text-text-tertiary max-w-28 px-1.5 py-1.5"></DatePicker>
                     </div>
                 </div>
                 <div class="">
                     <InputLabel>End</InputLabel>
                     <div class="flex flex-col items-center space-y-2 mt-1">
-                        <TimePickerSimple
+                        <TimePicker
                             v-model="localEnd"
-                            size="large"></TimePickerSimple>
+                            size="large"></TimePicker>
                         <DatePicker
                             v-model="localEnd"
-                            tabindex="1"
                             class="text-xs text-text-tertiary max-w-28 px-1.5 py-1.5"></DatePicker>
                     </div>
                 </div>
             </div>
         </template>
         <template #footer>
-            <SecondaryButton tabindex="2" @click="show = false"> Cancel</SecondaryButton>
+            <SecondaryButton @click="show = false"> Cancel</SecondaryButton>
             <PrimaryButton
-                tabindex="2"
                 class="ms-3"
                 :class="{ 'opacity-25': saving }"
                 :disabled="saving"

resources/js/utils/permissions.ts

@@ -77,10 +77,6 @@ export function canDeleteMembers() {
     return currentUserHasPermission('members:delete');
 }
 
-export function canMergeMembers() {
-    return currentUserHasPermission('members:merge-into');
-}
-
 export function canInvitePlaceholderMembers() {
     return currentUserHasPermission('members:invite-placeholder');
 }

resources/testfiles/generic_projects_import_test_1.csv

@@ -1,4 +0,0 @@
-name,color,billable_rate,is_public,client,billable_default,estimated_time,archived_at
-"Project for Big Company",,10001,false,"Big Company",true,,
-"Project without Client",#ef5350,,false,,false,1000,
-"Project (Archived)",#6a407f,,true,"Some client",true,0,2024-08-25T10:00:00Z

resources/testfiles/generic_time_entries_import_test_1.csv

@@ -1,3 +0,0 @@
-description,billable,client,project,tags,start,end,task,user_name,user_email
-"","false","","Project without Client","Development, Backend","2024-03-04T09:23:52Z","2024-03-04T09:23:52Z","","Peter Tester","peter.test@email.test"
-"Working hard","true","Big Company","Project for Big Company","","2024-03-04T09:23:00Z","2024-03-04T10:23:01Z","Task 1","Peter Tester","peter.test@email.test"

resources/testfiles/harvest_clients_import_test_1.csv

@@ -1,3 +0,0 @@
-Client Name,Address
-Example Client,""
-"\\ 🔥 Special characters  """"""`!@#$%^&*()_+\-=\[\]{};':""\\|,.''<>\/?~ \\\",""

resources/testfiles/harvest_projects_import_test_1.csv

@@ -1,3 +0,0 @@
-Client,Project,Project Code,Start Date,End Date,Project Notes,Total Hours,Billable Hours,Billable Amount,Budget By,Budget,Budget Spent,Budget Remaining,Total Costs,Team Costs,Expenses
-Example Client,Example Project,,"","",This is an example project to help you trial Harvest. You can track time to this project and see what insights you can get from our reports! Feel free to make any edits you want to this project or even delete it.,"20,01","20,01","2.001,0",Hours,"50,0","20,01","29,99","0,0","0,0","0,0"
-"\\ 🔥 Special characters client """"""`!@#$%^&*()_+\-=\[\]{};':""\\|,.''<>\/?~ \\\","\\ 🔥 Special characters project """"""`!@#$%^&*()_+\-=\[\]{};':""\\|,.''<>\/?~ \\\",,"","",,"0,0","0,0","0,0",Hours,"0,0","0,0","50,0","0,0","0,0","0,0"

resources/testfiles/harvest_time_entries_import_test_1.csv

@@ -1,3 +0,0 @@
-Date,Client,Project,Project Code,Task,Notes,Hours,Billable?,Invoiced?,Approved?,First Name,Last Name,Roles,Employee?,Billable Rate,Billable Amount,Cost Rate,Cost Amount,Currency,External Reference URL
-2024-03-04,,Project without Client,,,"","20,0",No,No,No,Peter,Tester,,Yes,"100,0","2.000,0","0,0","0,0",Euro - EUR,
-2024-03-04,Big Company,Project for Big Company,,Task 1,Working hard,"0,01",Yes,No,No,Peter,Tester,,Yes,"100,0","1,0","0,0","0,0",Euro - EUR,

resources/testfiles/toggl_data_import_test_2/clients.json

@@ -1,16 +0,0 @@
-[
-    {
-        "archived": false,
-        "creator_id": 201,
-        "id": 301,
-        "name": "Big Company",
-        "wid": 0
-    },
-    {
-        "archived": true,
-        "creator_id": 201,
-        "id": 302,
-        "name": "Other Company (Archived)",
-        "wid": 0
-    }
-]

resources/testfiles/toggl_data_import_test_2/projects.json

@@ -1,86 +0,0 @@
-[
-    {
-        "active": true,
-        "actual_hours": null,
-        "actual_seconds": null,
-        "auto_estimates": false,
-        "billable": false,
-        "cid": null,
-        "client_id": null,
-        "color": "#ef5350",
-        "currency": "EUR",
-        "estimated_hours": null,
-        "estimated_seconds": null,
-        "fixed_fee": null,
-        "guid": "",
-        "id": 401,
-        "is_private": true,
-        "name": "Project without Client",
-        "rate": null,
-        "rate_last_updated": null,
-        "recurring": false,
-        "recurring_parameters": null,
-        "start_date": "2020-01-01",
-        "status": "active",
-        "template": false,
-        "template_id": null,
-        "wid": 0,
-        "workspace_id": 0
-    },
-    {
-        "active": true,
-        "actual_hours": null,
-        "actual_seconds": null,
-        "auto_estimates": false,
-        "billable": true,
-        "cid": 301,
-        "client_id": 301,
-        "color": "#ec407a",
-        "currency": null,
-        "estimated_hours": null,
-        "estimated_seconds": null,
-        "fixed_fee": null,
-        "guid": "",
-        "id": 402,
-        "is_private": true,
-        "name": "Project for Big Company",
-        "rate": 100.01,
-        "rate_last_updated": null,
-        "recurring": false,
-        "recurring_parameters": null,
-        "start_date": "2020-01-01",
-        "status": "active",
-        "template": false,
-        "template_id": null,
-        "wid": 0,
-        "workspace_id": 0
-    },
-    {
-        "active": false,
-        "actual_hours": null,
-        "actual_seconds": null,
-        "auto_estimates": false,
-        "billable": true,
-        "cid": 302,
-        "client_id": 302,
-        "color": "#6a407f",
-        "currency": null,
-        "estimated_hours": null,
-        "estimated_seconds": null,
-        "fixed_fee": null,
-        "guid": "",
-        "id": 403,
-        "is_private": false,
-        "name": "Project (Archived)",
-        "rate": null,
-        "rate_last_updated": null,
-        "recurring": false,
-        "recurring_parameters": null,
-        "start_date": "2020-01-01",
-        "status": "active",
-        "template": false,
-        "template_id": null,
-        "wid": 0,
-        "workspace_id": 0
-    }
-]

resources/testfiles/toggl_data_import_test_2/projects_users/401.json

@@ -1 +0,0 @@
-[]

resources/testfiles/toggl_data_import_test_2/projects_users/402.json

@@ -1,14 +0,0 @@
-[
-    {
-        "gid": null,
-        "group_id": null,
-        "id": 801,
-        "labour_cost": null,
-        "manager": true,
-        "project_id": 402,
-        "rate": 100.02,
-        "rate_last_updated": null,
-        "user_id": 2001,
-        "workspace_id": 0
-    }
-]

resources/testfiles/toggl_data_import_test_2/projects_users/403.json

@@ -1 +0,0 @@
-[]

resources/testfiles/toggl_data_import_test_2/tags.json

@@ -1,14 +0,0 @@
-[
-    {
-        "creator_id": 0,
-        "id": 501,
-        "name": "Development",
-        "workspace_id": 0
-    },
-    {
-        "creator_id": 0,
-        "id": 502,
-        "name": "Backend",
-        "workspace_id": 0
-    }
-]

resources/testfiles/toggl_data_import_test_2/tasks/401.json

@@ -1 +0,0 @@
-[]

resources/testfiles/toggl_data_import_test_2/tasks/402.json

@@ -1,24 +0,0 @@
-[
-    {
-        "active": true,
-        "estimated_seconds": 0,
-        "id": 601,
-        "name": "Task 1",
-        "project_id": 402,
-        "recurring": false,
-        "tracked_seconds": 0,
-        "user_id": null,
-        "workspace_id": 0
-    },
-    {
-        "active": false,
-        "estimated_seconds": 0,
-        "id": 602,
-        "name": "Task 2",
-        "project_id": 403,
-        "recurring": false,
-        "tracked_seconds": 0,
-        "user_id": null,
-        "workspace_id": 0
-    }
-]

resources/testfiles/toggl_data_import_test_2/tasks/403.json

@@ -1 +0,0 @@
-[]

resources/testfiles/toggl_data_import_test_2/workspace_users.json

@@ -1,19 +0,0 @@
-[
-    {
-        "active": true,
-        "admin": true,
-        "email": "peter.test@email.test",
-        "group_ids": [],
-        "id": 201,
-        "inactive": false,
-        "labour_cost": null,
-        "name": "Peter Tester",
-        "rate": null,
-        "rate_last_updated": null,
-        "role": "admin",
-        "timezone": "Etc/UTC",
-        "uid": 2001,
-        "wid": 0,
-        "working_hours_in_minutes": null
-    }
-]

routes/api.php

@@ -51,7 +51,6 @@ Route::prefix('v1')->name('v1.')->group(static function (): void {
             Route::delete('/members/{member}', [MemberController::class, 'destroy'])->name('destroy');
             Route::post('/members/{member}/invite-placeholder', [MemberController::class, 'invitePlaceholder'])->name('invite-placeholder');
             Route::post('/members/{member}/make-placeholder', [MemberController::class, 'makePlaceholder'])->name('make-placeholder');
-            Route::post('member/{member}/merge-into', [MemberController::class, 'mergeInto'])->name('merge-into');
         });
 
         // User routes

tests/Unit/Console/Commands/Correction/CorrectionPlaceholderMembersCommandTest.php

@@ -1,68 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tests\Unit\Console\Commands\Correction;
-
-use App\Console\Commands\Correction\CorrectionPlaceholderMembersCommand;
-use App\Enums\Role;
-use App\Models\Member;
-use App\Models\Organization;
-use App\Models\User;
-use Illuminate\Console\Command;
-use Illuminate\Support\Facades\Artisan;
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\UsesClass;
-use Tests\TestCaseWithDatabase;
-
-#[CoversClass(CorrectionPlaceholderMembersCommand::class)]
-#[UsesClass(CorrectionPlaceholderMembersCommand::class)]
-class CorrectionPlaceholderMembersCommandTest extends TestCaseWithDatabase
-{
-    public function test_sets_member_role_to_placeholder_if_user_is_placeholder(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $user1 = User::factory()->placeholder()->create();
-        $member1 = Member::factory()->forOrganization($organization)->forUser($user1)->role(Role::Admin)->create();
-        $user2 = User::factory()->create();
-        $member2 = Member::factory()->forOrganization($organization)->forUser($user2)->role(Role::Admin)->create();
-
-        // Act
-        $exitCode = $this->withoutMockingConsoleOutput()->artisan('correction:placeholder-members');
-
-        // Assert
-        $this->assertSame(Command::SUCCESS, $exitCode);
-        $output = Artisan::output();
-        $member1->refresh();
-        $this->assertSame(Role::Placeholder->value, $member1->role);
-        $member2->refresh();
-        $this->assertSame(Role::Admin->value, $member2->role);
-        $this->assertSame("Sets all members who belong to a placeholder user to role placeholder...\n".
-            'Set role of member (id='.$member1->getKey().") to placeholder\n", $output);
-    }
-
-    public function test_sets_member_role_to_placeholder_if_user_is_placeholder_dry_run(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $user1 = User::factory()->placeholder()->create();
-        $member1 = Member::factory()->forOrganization($organization)->forUser($user1)->role(Role::Admin)->create();
-        $user2 = User::factory()->create();
-        $member2 = Member::factory()->forOrganization($organization)->forUser($user2)->role(Role::Admin)->create();
-
-        // Act
-        $exitCode = $this->withoutMockingConsoleOutput()->artisan('correction:placeholder-members --dry-run');
-
-        // Assert
-        $this->assertSame(Command::SUCCESS, $exitCode);
-        $output = Artisan::output();
-        $member1->refresh();
-        $this->assertSame(Role::Admin->value, $member1->role);
-        $member2->refresh();
-        $this->assertSame(Role::Admin->value, $member2->role);
-        $this->assertSame("Sets all members who belong to a placeholder user to role placeholder...\n".
-            "Running in dry-run mode. Nothing will be saved to the database.\n".
-            'Set role of member (id='.$member1->getKey().") to placeholder\n", $output);
-    }
-}

tests/Unit/Endpoint/Api/V1/MemberEndpointTest.php

@@ -194,216 +194,6 @@ class MemberEndpointTest extends ApiEndpointTestAbstract
         $response->assertJsonPath('message', 'Only owner can change ownership');
     }
 
-    public function test_update_member_fails_if_user_tries_to_change_the_role_of_a_placeholder(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:update',
-        ]);
-        $user = User::factory()->placeholder()->create();
-        $member = Member::factory()->forOrganization($data->organization)->forUser($user)->role(Role::Placeholder)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->putJson(route('api.v1.members.update', [$data->organization->getKey(), $member->getKey()]), [
-            'role' => Role::Admin->value,
-        ]);
-
-        // Assert
-        $response->assertStatus(400);
-        $response->assertExactJson([
-            'error' => true,
-            'key' => 'changing_role_of_placeholder_is_not_allowed',
-            'message' => 'Changing role of placeholder is not allowed',
-        ]);
-    }
-
-    public function test_merge_into_fails_if_url_member_is_not_part_of_organization(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:merge-into',
-        ]);
-        $userSource = User::factory()->placeholder()->create();
-        $memberSource = Member::factory()->forUser($userSource)->role(Role::Placeholder)->create();
-
-        $userDestination = User::factory()->create();
-        $memberDestination = Member::factory()->forUser($userDestination)->forOrganization($data->organization)->role(Role::Admin)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.merge-into', [$data->organization->getKey(), $memberSource->getKey()]), [
-            'member_id' => $memberDestination->getKey(),
-        ]);
-
-        // Assert
-        $response->assertForbidden();
-    }
-
-    public function test_merge_into_returns_validation_error_if_member_in_body_does_not_belong_to_organization(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:merge-into',
-        ]);
-        $userSource = User::factory()->placeholder()->create();
-        $memberSource = Member::factory()->forUser($userSource)->forOrganization($data->organization)->role(Role::Placeholder)->create();
-
-        $userDestination = User::factory()->create();
-        $memberDestination = Member::factory()->forUser($userDestination)->role(Role::Admin)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.merge-into', [$data->organization->getKey(), $memberSource->getKey()]), [
-            'member_id' => $memberDestination->getKey(),
-        ]);
-
-        // Assert
-        $response->assertStatus(422);
-        $response->assertExactJson([
-            'errors' => [
-                'member_id' => [
-                    'The resource does not exist.',
-                ],
-            ],
-            'message' => 'The resource does not exist.',
-        ]);
-    }
-
-    public function test_merge_into_fails_if_from_member_is_not_a_placeholder(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:merge-into',
-        ]);
-        $userSource = User::factory()->placeholder()->create();
-        $memberSource = Member::factory()->forUser($userSource)->forOrganization($data->organization)->role(Role::Admin)->create();
-
-        $userDestination = User::factory()->create();
-        $memberDestination = Member::factory()->forUser($userDestination)->forOrganization($data->organization)->role(Role::Admin)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.merge-into', [$data->organization->getKey(), $memberSource->getKey()]), [
-            'member_id' => $memberDestination->getKey(),
-        ]);
-
-        // Assert
-        $response->assertStatus(400);
-        $response->assertExactJson([
-            'error' => true,
-            'key' => 'only_placeholders_can_be_merged_into_another_member',
-            'message' => 'Only placeholders can be merged into another member',
-        ]);
-    }
-
-    public function test_merge_into_fails_if_user_has_no_permission_to_merge_members(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([]);
-        $userSource = User::factory()->placeholder()->create();
-        $memberSource = Member::factory()->forUser($userSource)->forOrganization($data->organization)->role(Role::Placeholder)->create();
-
-        $userDestination = User::factory()->create();
-        $memberDestination = Member::factory()->forUser($userDestination)->forOrganization($data->organization)->role(Role::Admin)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.merge-into', [$data->organization->getKey(), $memberSource->getKey()]), [
-            'member_id' => $memberDestination->getKey(),
-        ]);
-
-        // Assert
-        $response->assertForbidden();
-    }
-
-    public function test_merge_into_assigns_resources_of_source_member_to_destination_member_and_deletes_member(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:merge-into',
-        ]);
-        $userSource = User::factory()->placeholder()->create();
-        $memberSource = Member::factory()->forUser($userSource)->forOrganization($data->organization)->role(Role::Placeholder)->create();
-        TimeEntry::factory()->forMember($memberSource)->createMany(3);
-        $project = Project::factory()->forOrganization($data->organization)->create();
-        ProjectMember::factory()->forMember($memberSource)->forProject($project)->create();
-
-        $userDestination = User::factory()->create();
-        $memberDestination = Member::factory()->forUser($userDestination)->forOrganization($data->organization)->role(Role::Admin)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.merge-into', [$data->organization->getKey(), $memberSource->getKey()]), [
-            'member_id' => $memberDestination->getKey(),
-        ]);
-
-        // Assert
-        $response->assertStatus(204);
-        $this->assertSame('', $response->getContent());
-        $this->assertDatabaseMissing(Member::class, [
-            'id' => $memberSource->getKey(),
-        ]);
-        $this->assertDatabaseMissing(User::class, [
-            'id' => $userSource->getKey(),
-        ]);
-        $memberDestination->refresh();
-        $this->assertCount(3, $memberDestination->timeEntries);
-        $this->assertCount(1, $memberDestination->projectMembers);
-        $this->assertDatabaseHas(ProjectMember::class, [
-            'project_id' => $project->getKey(),
-            'member_id' => $memberDestination->getKey(),
-            'user_id' => $userDestination->getKey(),
-        ]);
-    }
-
-    public function test_merge_into_assigns_resources_of_source_member_to_destination_member_and_deletes_member_with_existing_destination_resources(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:merge-into',
-        ]);
-        $userSource = User::factory()->placeholder()->create();
-        $memberSource = Member::factory()->forUser($userSource)->forOrganization($data->organization)->role(Role::Placeholder)->create();
-        TimeEntry::factory()->forMember($memberSource)->createMany(3);
-        $project = Project::factory()->forOrganization($data->organization)->create();
-        ProjectMember::factory()->forMember($memberSource)->forProject($project)->create([
-            'billable_rate' => 32100,
-        ]);
-
-        $userDestination = User::factory()->create();
-        $memberDestination = Member::factory()->forUser($userDestination)->forOrganization($data->organization)->role(Role::Admin)->create();
-        ProjectMember::factory()->forMember($memberDestination)->forProject($project)->create([
-            'billable_rate' => 12300,
-        ]);
-        TimeEntry::factory()->forMember($memberDestination)->createMany(3);
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->withoutExceptionHandling()->postJson(route('api.v1.members.merge-into', [$data->organization->getKey(), $memberSource->getKey()]), [
-            'member_id' => $memberDestination->getKey(),
-        ]);
-
-        // Assert
-        $response->assertStatus(204);
-        $this->assertSame('', $response->getContent());
-        $this->assertDatabaseMissing(Member::class, [
-            'id' => $memberSource->getKey(),
-        ]);
-        $this->assertDatabaseMissing(User::class, [
-            'id' => $userSource->getKey(),
-        ]);
-        $memberDestination->refresh();
-        $this->assertCount(6, $memberDestination->timeEntries);
-        $this->assertCount(1, $memberDestination->projectMembers);
-        $this->assertDatabaseHas(ProjectMember::class, [
-            'project_id' => $project->getKey(),
-            'billable_rate' => 12300,
-            'member_id' => $memberDestination->getKey(),
-            'user_id' => $userDestination->getKey(),
-        ]);
-    }
-
     public function test_update_member_fails_if_user_tries_to_change_role_of_the_current_owner(): void
     {
         // Arrange
@@ -491,7 +281,6 @@ class MemberEndpointTest extends ApiEndpointTestAbstract
 
     public function test_invite_placeholder_succeeds_if_data_is_valid(): void
     {
-        // Arrange
         $data = $this->createUserWithPermission([
             'members:invite-placeholder',
         ]);
@@ -512,38 +301,6 @@ class MemberEndpointTest extends ApiEndpointTestAbstract
         $response->assertStatus(204);
     }
 
-    public function test_invite_placeholder_fails_if_the_placeholder_has_a_invalid_email_from_an_import(): void
-    {
-        // Arrange
-        $data = $this->createUserWithPermission([
-            'members:invite-placeholder',
-        ]);
-        $user = User::factory()->create([
-            'is_placeholder' => true,
-            'email' => 'some.user@solidtime-import.test',
-        ]);
-        $member = Member::factory()
-            ->forUser($user)
-            ->forOrganization($data->organization)
-            ->role(Role::Placeholder)
-            ->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.invite-placeholder', [
-            'organization' => $data->organization->getKey(),
-            'member' => $member->getKey(),
-        ]));
-
-        // Assert
-        $response->assertStatus(400);
-        $response->assertExactJson([
-            'error' => true,
-            'key' => 'this_placeholder_can_not_be_invited_use_the_merge_tool_instead_api_exception',
-            'message' => 'This placeholder can not be invited use the merge tool instead',
-        ]);
-    }
-
     public function test_destroy_member_fails_if_user_has_no_permission_to_delete_members(): void
     {
         // Arrange
@@ -698,34 +455,6 @@ class MemberEndpointTest extends ApiEndpointTestAbstract
         Event::assertNotDispatched(MemberMadeToPlaceholder::class);
     }
 
-    public function test_make_placeholder_fails_if_user_is_already_a_placeholder(): void
-    {
-        // Arrange
-        Event::fake([
-            MemberMadeToPlaceholder::class,
-        ]);
-        $data = $this->createUserWithPermission([
-            'members:make-placeholder',
-        ]);
-        $user = User::factory()->placeholder()->create();
-        $member = Member::factory()->forUser($user)->forOrganization($data->organization)->role(Role::Placeholder)->create();
-        Passport::actingAs($data->user);
-
-        // Act
-        $response = $this->postJson(route('api.v1.members.make-placeholder', [
-            'organization' => $data->organization->getKey(),
-            'member' => $member->getKey(),
-        ]));
-
-        // Assert
-        $response->assertStatus(400);
-        $response->assertExactJson([
-            'error' => true,
-            'key' => 'changing_role_of_placeholder_is_not_allowed',
-            'message' => 'Changing role of placeholder is not allowed',
-        ]);
-    }
-
     public function test_make_placeholder_fails_if_member_is_owner(): void
     {
         // Arrange

tests/Unit/Service/Import/Importers/GenericProjectsImporterTest.php

@@ -1,87 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tests\Unit\Service\Import\Importers;
-
-use App\Models\Client;
-use App\Models\Organization;
-use App\Models\Project;
-use App\Models\Task;
-use App\Service\ColorService;
-use App\Service\Import\Importers\DefaultImporter;
-use App\Service\Import\Importers\GenericProjectsImporter;
-use App\Service\Import\Importers\ImportException;
-use Illuminate\Support\Facades\Storage;
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\UsesClass;
-
-#[CoversClass(GenericProjectsImporter::class)]
-#[CoversClass(ImportException::class)]
-#[CoversClass(DefaultImporter::class)]
-#[UsesClass(GenericProjectsImporter::class)]
-class GenericProjectsImporterTest extends ImporterTestAbstract
-{
-    public function test_import_of_test_file_succeeds(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $timezone = 'Europe/Vienna';
-        $importer = new GenericProjectsImporter;
-        $importer->init($organization);
-        $data = Storage::disk('testfiles')->get('generic_projects_import_test_1.csv');
-
-        // Act
-        $importer->importData($data, $timezone);
-        $report = $importer->getReport();
-
-        // Assert
-        $clients = Client::all();
-        $this->assertCount(2, $clients);
-        $client1 = $clients->firstWhere('name', 'Big Company');
-        $this->assertNotNull($client1);
-        $client2 = $clients->firstWhere('name', 'Some client');
-        $this->assertNotNull($client2);
-        $projects = Project::all();
-        $this->assertCount(3, $projects);
-        // Project 1
-        $project1 = $projects->firstWhere('name', 'Project for Big Company');
-        $this->assertNotNull($project1);
-        $this->assertTrue(app(ColorService::class)->isBuiltInColor($project1->color));
-        $this->assertSame(10001, $project1->billable_rate);
-        $this->assertFalse($project1->is_public);
-        $this->assertSame($client1->getKey(), $project1->client_id);
-        $this->assertTrue($project1->is_billable);
-        $this->assertSame(null, $project1->estimated_time);
-        $this->assertNull($project1->archived_at);
-        // Project 2
-        $project2 = $projects->firstWhere('name', 'Project without Client');
-        $this->assertNotNull($project2);
-        $this->assertSame('#ef5350', $project2->color);
-        $this->assertSame(null, $project2->billable_rate);
-        $this->assertFalse($project2->is_public);
-        $this->assertSame(null, $project2->client_id);
-        $this->assertFalse($project2->is_billable);
-        $this->assertSame(1000, $project2->estimated_time);
-        $this->assertSame(null, $project2->archived_at);
-        $project3 = $projects->firstWhere('name', 'Project (Archived)');
-        $this->assertNotNull($project3);
-        $this->assertSame('#6a407f', $project3->color);
-        $this->assertSame(null, $project3->billable_rate);
-        $this->assertTrue($project3->is_public);
-        $this->assertSame($client2->getKey(), $project3->client_id);
-        $this->assertTrue($project3->is_billable);
-        $this->assertSame(null, $project3->estimated_time);
-        $this->assertSame('2024-08-25T10:00:00Z', $project3->archived_at->toIso8601ZuluString());
-
-        $tasks = Task::all();
-        $this->assertCount(0, $tasks);
-
-        $this->assertSame(0, $report->timeEntriesCreated);
-        $this->assertSame(0, $report->tagsCreated);
-        $this->assertSame(0, $report->tasksCreated);
-        $this->assertSame(0, $report->usersCreated);
-        $this->assertSame(3, $report->projectsCreated);
-        $this->assertSame(2, $report->clientsCreated);
-    }
-}

tests/Unit/Service/Import/Importers/GenericTimeEntriesImporterTest.php

@@ -1,71 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tests\Unit\Service\Import\Importers;
-
-use App\Models\Organization;
-use App\Service\Import\Importers\DefaultImporter;
-use App\Service\Import\Importers\GenericTimeEntriesImporter;
-use App\Service\Import\Importers\ImportException;
-use Illuminate\Support\Facades\Storage;
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\UsesClass;
-
-#[CoversClass(GenericTimeEntriesImporter::class)]
-#[CoversClass(ImportException::class)]
-#[CoversClass(DefaultImporter::class)]
-#[UsesClass(GenericTimeEntriesImporter::class)]
-class GenericTimeEntriesImporterTest extends ImporterTestAbstract
-{
-    public function test_import_of_test_file_succeeds(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $timezone = 'Europe/Vienna';
-        $importer = new GenericTimeEntriesImporter;
-        $importer->init($organization);
-        $data = Storage::disk('testfiles')->get('generic_time_entries_import_test_1.csv');
-
-        // Act
-        $importer->importData($data, $timezone);
-        $report = $importer->getReport();
-
-        // Assert
-        $testScenario = $this->checkTestScenarioAfterImportExcludingTimeEntries();
-        $this->checkTimeEntries($testScenario);
-        $this->assertSame(2, $report->timeEntriesCreated);
-        $this->assertSame(2, $report->tagsCreated);
-        $this->assertSame(1, $report->tasksCreated);
-        $this->assertSame(1, $report->usersCreated);
-        $this->assertSame(2, $report->projectsCreated);
-        $this->assertSame(1, $report->clientsCreated);
-    }
-
-    public function test_import_of_test_file_twice_succeeds(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $timezone = 'Europe/Vienna';
-        $importer = new GenericTimeEntriesImporter;
-        $importer->init($organization);
-        $data = Storage::disk('testfiles')->get('generic_time_entries_import_test_1.csv');
-        $importer->importData($data, $timezone);
-        $importer = new GenericTimeEntriesImporter;
-        $importer->init($organization);
-
-        // Act
-        $importer->importData($data, $timezone);
-        $report = $importer->getReport();
-
-        // Assert
-        $testScenario = $this->checkTestScenarioAfterImportExcludingTimeEntries();
-        $this->checkTimeEntries($testScenario, true);
-        $this->assertSame(2, $report->timeEntriesCreated);
-        $this->assertSame(0, $report->tagsCreated);
-        $this->assertSame(0, $report->tasksCreated);
-        $this->assertSame(0, $report->usersCreated);
-        $this->assertSame(0, $report->projectsCreated);
-        $this->assertSame(0, $report->clientsCreated);
-    }
-}

tests/Unit/Service/Import/Importers/HarvestClientsImporterTest.php

@@ -1,43 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tests\Unit\Service\Import\Importers;
-
-use App\Models\Client;
-use App\Models\Organization;
-use App\Service\Import\Importers\DefaultImporter;
-use App\Service\Import\Importers\HarvestClientsImporter;
-use App\Service\Import\Importers\ImportException;
-use Illuminate\Support\Facades\Storage;
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\UsesClass;
-
-#[CoversClass(HarvestClientsImporter::class)]
-#[CoversClass(ImportException::class)]
-#[CoversClass(DefaultImporter::class)]
-#[UsesClass(HarvestClientsImporter::class)]
-class HarvestClientsImporterTest extends ImporterTestAbstract
-{
-    public function test_import_of_test_file_succeeds(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $timezone = 'Europe/Vienna';
-        $importer = new HarvestClientsImporter;
-        $importer->init($organization);
-        $data = Storage::disk('testfiles')->get('harvest_clients_import_test_1.csv');
-
-        // Act
-        $importer->importData($data, $timezone);
-
-        // Assert
-        $clients = Client::query()->whereBelongsTo($organization, 'organization')->get();
-        $this->assertCount(2, $clients);
-        $client1 = $clients->where('name', 'Example Client')->first();
-        $this->assertNotNull($client1);
-        // Client name in Harvest: \\ 🔥 Special characters """`!@#$%^&*()_+\-=\[\]{};':"\\|,.''<>\/?~ \\\
-        $client2 = $clients->where('name', '\\\\ 🔥 Special characters  """`!@#$%^&*()_+\-=\[\]{};\':"\\\\|,.\'\'<>\/?~ \\\\\\')->first();
-        $this->assertNotNull($client2);
-    }
-}

tests/Unit/Service/Import/Importers/HarvestProjectsImporterTest.php

@@ -1,61 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tests\Unit\Service\Import\Importers;
-
-use App\Models\Client;
-use App\Models\Organization;
-use App\Models\Project;
-use App\Service\Import\Importers\DefaultImporter;
-use App\Service\Import\Importers\HarvestProjectsImporter;
-use App\Service\Import\Importers\ImportException;
-use Illuminate\Support\Facades\Storage;
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\UsesClass;
-
-#[CoversClass(HarvestProjectsImporter::class)]
-#[CoversClass(ImportException::class)]
-#[CoversClass(DefaultImporter::class)]
-#[UsesClass(HarvestProjectsImporter::class)]
-class HarvestProjectsImporterTest extends ImporterTestAbstract
-{
-    public function test_import_of_test_file_succeeds(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $timezone = 'Europe/Vienna';
-        $importer = new HarvestProjectsImporter;
-        $importer->init($organization);
-        $data = Storage::disk('testfiles')->get('harvest_projects_import_test_1.csv');
-
-        // Act
-        $importer->importData($data, $timezone);
-
-        // Assert
-        $clients = Client::query()->whereBelongsTo($organization, 'organization')->get();
-        $this->assertCount(2, $clients);
-        /** @var Client|null $client1 */
-        $client1 = $clients->where('name', 'Example Client')->first();
-        $this->assertNotNull($client1);
-        // Client name in Harvest: \\ 🔥 Special characters client """`!@#$%^&*()_+\-=\[\]{};':"\\|,.''<>\/?~ \\\
-        /** @var Client|null $client2 */
-        $client2 = $clients->where('name', '\\\\ 🔥 Special characters client """`!@#$%^&*()_+\-=\[\]{};\':"\\\\|,.\'\'<>\/?~ \\\\\\')->first();
-        $this->assertNotNull($client2);
-
-        $projects = Project::query()->whereBelongsTo($organization, 'organization')->get();
-        $this->assertCount(2, $projects);
-        /** @var Project|null $project1 */
-        $project1 = $projects->where('name', 'Example Project')->first();
-        $this->assertNotNull($project1);
-        $this->assertSame($client1->getKey(), $project1->client_id);
-        $this->assertSame(50 * 60 * 60, $project1->estimated_time); // 50h
-        $this->assertSame(true, $project1->is_billable);
-        /** @var Project|null $project2 */
-        $project2 = $projects->where('name', '\\\\ 🔥 Special characters project """`!@#$%^&*()_+\-=\[\]{};\':"\\\\|,.\'\'<>\/?~ \\\\\\')->first();
-        $this->assertNotNull($project2);
-        $this->assertSame($client2->getKey(), $project2->client_id);
-        $this->assertSame(null, $project2->estimated_time);
-        $this->assertSame(false, $project2->is_billable);
-    }
-}

tests/Unit/Service/Import/Importers/HarvestTimeEntriesImporterTest.php

@@ -1,110 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Tests\Unit\Service\Import\Importers;
-
-use App\Enums\Role;
-use App\Models\Client;
-use App\Models\Member;
-use App\Models\Organization;
-use App\Models\Project;
-use App\Models\Tag;
-use App\Models\Task;
-use App\Models\TimeEntry;
-use App\Models\User;
-use App\Service\Import\Importers\DefaultImporter;
-use App\Service\Import\Importers\HarvestTimeEntriesImporter;
-use App\Service\Import\Importers\ImportException;
-use Illuminate\Support\Facades\Storage;
-use PHPUnit\Framework\Attributes\CoversClass;
-use PHPUnit\Framework\Attributes\UsesClass;
-
-#[CoversClass(HarvestTimeEntriesImporter::class)]
-#[CoversClass(ImportException::class)]
-#[CoversClass(DefaultImporter::class)]
-#[UsesClass(HarvestTimeEntriesImporter::class)]
-class HarvestTimeEntriesImporterTest extends ImporterTestAbstract
-{
-    public function test_import_of_test_file_succeeds(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $timezone = 'Europe/Vienna';
-        $importer = new HarvestTimeEntriesImporter;
-        $importer->init($organization);
-        $data = Storage::disk('testfiles')->get('harvest_time_entries_import_test_1.csv');
-
-        // Act
-        $importer->importData($data, $timezone);
-        $report = $importer->getReport();
-
-        // Assert
-        $users = User::all();
-        $this->assertCount(2, $users);
-        $user1 = $users->firstWhere('name', 'Peter Tester');
-        $this->assertNotNull($user1);
-        $this->assertSame(null, $user1->password);
-        $this->assertSame('Peter Tester', $user1->name);
-        $this->assertSame('peter.tester@solidtime-import.test', $user1->email);
-        $members = Member::all();
-        $this->assertCount(1, $members);
-        $member1 = $members->firstWhere('user_id', $user1->getKey());
-        $this->assertNotNull($member1);
-        $this->assertSame(Role::Placeholder->value, $member1->role);
-        $clients = Client::all();
-        $this->assertCount(1, $clients);
-        $client1 = $clients->firstWhere('name', 'Big Company');
-        $this->assertNotNull($client1);
-        $this->assertNull($client1->archived_at);
-        $projects = Project::with(['members'])->get();
-        $this->assertCount(2, $projects);
-        /** @var Project|null $project1 */
-        $project1 = $projects->firstWhere('name', 'Project without Client');
-        $this->assertNotNull($project1);
-        $this->assertNull($project1->client_id);
-        /** @var Project|null $project2 */
-        $project2 = $projects->firstWhere('name', 'Project for Big Company');
-        $this->assertNotNull($project2);
-        $this->assertSame($client1->getKey(), $project2->client_id);
-        $project3 = null;
-        // Project without Client
-        $this->assertSame(false, $project1->is_public);
-        // Project for Big Company
-        $this->assertSame(false, $project2->is_public);
-        $tasks = Task::all();
-        $this->assertCount(1, $tasks);
-        $task1 = $tasks->firstWhere('name', 'Task 1');
-        $this->assertNotNull($task1);
-        $this->assertNull($task1->done_at);
-        $this->assertSame($project2->getKey(), $task1->project_id);
-        $tags = Tag::all();
-        $this->assertCount(0, $tags);
-
-        $timeEntries = TimeEntry::all();
-        $this->assertCount(2, $timeEntries);
-        $timeEntry1 = $timeEntries->firstWhere('description', '');
-        $this->assertNotNull($timeEntry1);
-        $this->assertSame('', $timeEntry1->description);
-        $this->assertSame('2024-03-03 23:00:00', $timeEntry1->start->toDateTimeString());
-        $this->assertSame('2024-03-04 19:00:00', $timeEntry1->end->toDateTimeString());
-        $this->assertFalse($timeEntry1->billable);
-        $this->assertTrue($timeEntry1->is_imported);
-        $this->assertSame([], $timeEntry1->tags);
-        $timeEntry2 = $timeEntries->firstWhere('description', 'Working hard');
-        $this->assertNotNull($timeEntry2);
-        $this->assertSame('Working hard', $timeEntry2->description);
-        $this->assertSame('2024-03-03 23:00:00', $timeEntry2->start->toDateTimeString());
-        $this->assertSame('2024-03-03 23:00:36', $timeEntry2->end->toDateTimeString());
-        $this->assertTrue($timeEntry2->billable);
-        $this->assertTrue($timeEntry2->is_imported);
-        $this->assertSame([], $timeEntry2->tags);
-
-        $this->assertSame(2, $report->timeEntriesCreated);
-        $this->assertSame(0, $report->tagsCreated);
-        $this->assertSame(1, $report->tasksCreated);
-        $this->assertSame(1, $report->usersCreated);
-        $this->assertSame(2, $report->projectsCreated);
-        $this->assertSame(1, $report->clientsCreated);
-    }
-}

tests/Unit/Service/Import/Importers/ImporterProviderTest.php

@@ -42,11 +42,6 @@ class ImporterProviderTest extends TestCase
             'clockify_time_entries',
             'clockify_projects',
             'solidtime',
-            'harvest_projects',
-            'harvest_time_entries',
-            'harvest_clients',
-            'generic_projects',
-            'generic_time_entries',
         ], $keys);
     }
 }

tests/Unit/Service/Import/Importers/TogglDataImporterTest.php

@@ -5,7 +5,6 @@ declare(strict_types=1);
 namespace Tests\Unit\Service\Import\Importers;
 
 use App\Models\Organization;
-use App\Models\User;
 use App\Service\Import\Importers\DefaultImporter;
 use App\Service\Import\Importers\ImportException;
 use App\Service\Import\Importers\TogglDataImporter;
@@ -89,30 +88,4 @@ class TogglDataImporterTest extends ImporterTestAbstract
         $this->assertSame(0, $report->projectsCreated);
         $this->assertSame(0, $report->clientsCreated);
     }
-
-    public function test_import_of_user_with_unknown_timezone_will_be_mapped_to_utc(): void
-    {
-        // Arrange
-        $zipPath = $this->createTestZip('toggl_data_import_test_2');
-        $timezone = 'Europe/Vienna';
-        $organization = Organization::factory()->create();
-        $importer = new TogglDataImporter;
-        $importer->init($organization);
-        $data = file_get_contents($zipPath);
-
-        // Act
-        $importer->importData($data, $timezone);
-        $report = $importer->getReport();
-
-        // Assert
-        $this->assertSame(0, $report->timeEntriesCreated);
-        $this->assertSame(2, $report->tagsCreated);
-        $this->assertSame(2, $report->tasksCreated);
-        $this->assertSame(1, $report->usersCreated);
-        $this->assertSame(3, $report->projectsCreated);
-        $this->assertSame(2, $report->clientsCreated);
-        $user = User::query()->where('email', '=', 'peter.test@email.test')->first();
-        $this->assertSame('UTC', $user->timezone);
-        $this->assertTrue($user->is_placeholder);
-    }
 }

tests/Unit/Service/MemberServiceTest.php

@@ -113,94 +113,4 @@ class MemberServiceTest extends TestCaseWithDatabase
         $this->assertSame($otherMember->getKey(), $otherTimeEntry->member_id);
         $this->assertSame(1, $otherUser->organizations()->count());
     }
-
-    public function test_assign_organization_entities_to_different_member_without_any_entries(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $project = Project::factory()->forOrganization($organization)->create();
-        $otherUser = User::factory()->create();
-        $fromUser = User::factory()->create();
-        $toUser = User::factory()->create();
-        $otherUserMember = Member::factory()->forOrganization($organization)->forUser($otherUser)->create();
-        $fromUserMember = Member::factory()->forOrganization($organization)->forUser($fromUser)->create();
-        $toUserMember = Member::factory()->forOrganization($organization)->forUser($toUser)->create();
-        TimeEntry::factory()->forOrganization($organization)->forMember($otherUserMember)->createMany(3);
-        TimeEntry::factory()->forOrganization($organization)->forMember($fromUserMember)->createMany(3);
-        ProjectMember::factory()->forProject($project)->forMember($otherUserMember)->create();
-        ProjectMember::factory()->forProject($project)->forMember($fromUserMember)->create();
-
-        // Act
-        $this->memberService->assignOrganizationEntitiesToDifferentMember($organization, $fromUserMember, $toUserMember);
-
-        // Assert
-        $this->assertSame(3, TimeEntry::query()->whereBelongsTo($toUser, 'user')->count());
-        $this->assertSame(3, TimeEntry::query()->whereBelongsTo($otherUser, 'user')->count());
-        $this->assertSame(0, TimeEntry::query()->whereBelongsTo($fromUser, 'user')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($toUser, 'user')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($otherUser, 'user')->count());
-        $this->assertSame(0, ProjectMember::query()->whereBelongsTo($fromUser, 'user')->count());
-
-        $this->assertSame(3, TimeEntry::query()->whereBelongsTo($toUserMember, 'member')->count());
-        $this->assertSame(3, TimeEntry::query()->whereBelongsTo($otherUserMember, 'member')->count());
-        $this->assertSame(0, TimeEntry::query()->whereBelongsTo($fromUserMember, 'member')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($toUserMember, 'member')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($otherUserMember, 'member')->count());
-        $this->assertSame(0, ProjectMember::query()->whereBelongsTo($fromUserMember, 'member')->count());
-    }
-
-    public function test_assign_organization_entities_to_different_member_with_entries(): void
-    {
-        // Arrange
-        $organization = Organization::factory()->create();
-        $project = Project::factory()->forOrganization($organization)->create();
-        $otherUser = User::factory()->create();
-        $fromUser = User::factory()->create();
-        $toUser = User::factory()->create();
-        $otherUserMember = Member::factory()->forOrganization($organization)->forUser($otherUser)->create();
-        $fromUserMember = Member::factory()->forOrganization($organization)->forUser($fromUser)->create();
-        $toUserMember = Member::factory()->forOrganization($organization)->forUser($toUser)->create();
-        TimeEntry::factory()->forOrganization($organization)->forMember($otherUserMember)->createMany(3);
-        TimeEntry::factory()->forOrganization($organization)->forMember($fromUserMember)->createMany(3);
-        TimeEntry::factory()->forOrganization($organization)->forMember($toUserMember)->createMany(3);
-        ProjectMember::factory()->forProject($project)->forMember($otherUserMember)->create([
-            'billable_rate' => 1,
-        ]);
-        ProjectMember::factory()->forProject($project)->forMember($fromUserMember)->create([
-            'billable_rate' => 2,
-        ]);
-        ProjectMember::factory()->forProject($project)->forMember($toUserMember)->create([
-            'billable_rate' => 3,
-        ]);
-
-        // Act
-        $this->memberService->assignOrganizationEntitiesToDifferentMember($organization, $fromUserMember, $toUserMember);
-
-        // Assert
-        $this->assertSame(6, TimeEntry::query()->whereBelongsTo($toUser, 'user')->count());
-        $this->assertSame(3, TimeEntry::query()->whereBelongsTo($otherUser, 'user')->count());
-        $this->assertSame(0, TimeEntry::query()->whereBelongsTo($fromUser, 'user')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($toUser, 'user')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($otherUser, 'user')->count());
-        $this->assertSame(0, ProjectMember::query()->whereBelongsTo($fromUser, 'user')->count());
-
-        $this->assertSame(6, TimeEntry::query()->whereBelongsTo($toUserMember, 'member')->count());
-        $this->assertSame(3, TimeEntry::query()->whereBelongsTo($otherUserMember, 'member')->count());
-        $this->assertSame(0, TimeEntry::query()->whereBelongsTo($fromUserMember, 'member')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($toUserMember, 'member')->count());
-        $this->assertSame(1, ProjectMember::query()->whereBelongsTo($otherUserMember, 'member')->count());
-        $this->assertSame(0, ProjectMember::query()->whereBelongsTo($fromUserMember, 'member')->count());
-
-        $this->assertDatabaseCount(ProjectMember::class, 2);
-        $this->assertDatabaseHas(ProjectMember::class, [
-            'project_id' => $project->id,
-            'member_id' => $toUserMember->id,
-            'billable_rate' => 3,
-        ]);
-        $this->assertDatabaseHas(ProjectMember::class, [
-            'project_id' => $project->id,
-            'member_id' => $otherUserMember->id,
-            'billable_rate' => 1,
-        ]);
-    }
 }

tests/Unit/Service/UserServiceTest.php

@@ -59,6 +59,22 @@ class UserServiceTest extends TestCase
         $this->assertSame(0, ProjectMember::query()->whereBelongsTo($fromUser, 'user')->count());
     }
 
+    public function test_assign_organization_entities_to_different_user_fails_if_new_user_is_not_member_of_organization(): void
+    {
+        // Arrange
+        $organization = Organization::factory()->create();
+        $fromUser = User::factory()->create();
+        $toUser = User::factory()->create();
+        $fromUserMember = Member::factory()->forOrganization($organization)->forUser($fromUser)->create();
+
+        // Act
+        try {
+            $this->userService->assignOrganizationEntitiesToDifferentUser($organization, $fromUser, $toUser);
+        } catch (\InvalidArgumentException $e) {
+            $this->assertSame('User is not a member of the organization', $e->getMessage());
+        }
+    }
+
     public function test_change_ownership_changes_ownership_of_organization_to_new_user(): void
     {
         // Arrange