mirror of
https://github.com/solidtime-io/solidtime.git
synced 2026-06-15 05:22:44 +01:00
Compare commits
5 Commits
b3785f0aa6
...
feature/us
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
4ff8a72f0b | ||
|
|
4790693017 | ||
|
|
3caf7438b5 | ||
|
|
d929d31847 | ||
|
|
d7bb36d50f |
@@ -50,6 +50,9 @@ class OrganizationController extends Controller
|
||||
if ($request->getName() !== null) {
|
||||
$organization->name = $request->getName();
|
||||
}
|
||||
if ($request->getCurrency() !== null) {
|
||||
$organization->currency = $request->getCurrency();
|
||||
}
|
||||
if ($request->getEmployeesCanSeeBillableRates() !== null) {
|
||||
$organization->employees_can_see_billable_rates = $request->getEmployeesCanSeeBillableRates();
|
||||
}
|
||||
|
||||
54
app/Http/Controllers/Web/OtherBrowserSessionsController.php
Normal file
54
app/Http/Controllers/Web/OtherBrowserSessionsController.php
Normal file
@@ -0,0 +1,54 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace App\Http\Controllers\Web;
|
||||
|
||||
use Illuminate\Contracts\Auth\StatefulGuard;
|
||||
use Illuminate\Http\RedirectResponse;
|
||||
use Illuminate\Http\Request;
|
||||
use Illuminate\Routing\Controller;
|
||||
use Illuminate\Support\Facades\DB;
|
||||
use Illuminate\Validation\ValidationException;
|
||||
use Laravel\Fortify\Actions\ConfirmPassword;
|
||||
|
||||
class OtherBrowserSessionsController extends Controller
|
||||
{
|
||||
/**
|
||||
* Log the user out of their other browser sessions across all devices.
|
||||
*/
|
||||
public function destroy(Request $request, StatefulGuard $guard): RedirectResponse
|
||||
{
|
||||
$password = (string) $request->string('password');
|
||||
|
||||
$confirmed = app(ConfirmPassword::class)($guard, $request->user(), $password);
|
||||
|
||||
if (! $confirmed) {
|
||||
throw ValidationException::withMessages([
|
||||
'password' => __('The password is incorrect.'),
|
||||
]);
|
||||
}
|
||||
|
||||
$guard->logoutOtherDevices($password);
|
||||
|
||||
$this->deleteOtherSessionRecords($request);
|
||||
|
||||
return back(303);
|
||||
}
|
||||
|
||||
/**
|
||||
* Delete the other browser session records from storage.
|
||||
*/
|
||||
protected function deleteOtherSessionRecords(Request $request): void
|
||||
{
|
||||
if (config('session.driver') !== 'database') {
|
||||
return;
|
||||
}
|
||||
|
||||
DB::connection(config('session.connection'))
|
||||
->table(config('session.table', 'sessions'))
|
||||
->where('user_id', $request->user()->getAuthIdentifier())
|
||||
->where('id', '!=', $request->session()->getId())
|
||||
->delete();
|
||||
}
|
||||
}
|
||||
@@ -11,6 +11,7 @@ use App\Enums\NumberFormat;
|
||||
use App\Enums\TimeFormat;
|
||||
use App\Http\Requests\V1\BaseFormRequest;
|
||||
use App\Models\Organization;
|
||||
use App\Rules\CurrencyRule;
|
||||
use Illuminate\Validation\Rule;
|
||||
|
||||
/**
|
||||
@@ -21,7 +22,7 @@ class OrganizationUpdateRequest extends BaseFormRequest
|
||||
/**
|
||||
* Get the validation rules that apply to the request.
|
||||
*
|
||||
* @return array<string, array<string|\Illuminate\Contracts\Validation\Rule>>
|
||||
* @return array<string, array<string|\Illuminate\Contracts\Validation\Rule|\Illuminate\Contracts\Validation\ValidationRule>>
|
||||
*/
|
||||
public function rules(): array
|
||||
{
|
||||
@@ -30,6 +31,10 @@ class OrganizationUpdateRequest extends BaseFormRequest
|
||||
'string',
|
||||
'max:255',
|
||||
],
|
||||
'currency' => [
|
||||
'string',
|
||||
new CurrencyRule,
|
||||
],
|
||||
'billable_rate' => array_merge(
|
||||
[
|
||||
'nullable',
|
||||
@@ -68,6 +73,11 @@ class OrganizationUpdateRequest extends BaseFormRequest
|
||||
return $this->has('name') ? (string) $this->input('name') : null;
|
||||
}
|
||||
|
||||
public function getCurrency(): ?string
|
||||
{
|
||||
return $this->has('currency') ? (string) $this->input('currency') : null;
|
||||
}
|
||||
|
||||
public function getNumberFormat(): ?NumberFormat
|
||||
{
|
||||
return $this->has('number_format') ? NumberFormat::from($this->input('number_format')) : null;
|
||||
|
||||
@@ -12,7 +12,7 @@ import {
|
||||
createRunningTimeEntryWithStartViaApi,
|
||||
createTaskViaApi,
|
||||
createProjectWithClientViaApi,
|
||||
updateUserProfileViaWeb,
|
||||
updateUserProfileViaApi,
|
||||
updateOrganizationSettingViaApi,
|
||||
} from './utils/api';
|
||||
|
||||
@@ -1803,28 +1803,22 @@ test.describe('Click-Drag Selection to Create', () => {
|
||||
// =============================================
|
||||
|
||||
test.describe('Timezone & Localization', () => {
|
||||
test('week start day: monday shows Mon as first column', async ({ page }) => {
|
||||
// Navigate to calendar first to load Inertia page props
|
||||
test('week start day: monday shows Mon as first column', async ({ page, ctx }) => {
|
||||
await updateUserProfileViaApi(ctx, { week_start: 'monday' });
|
||||
await goToCalendar(page);
|
||||
await updateUserProfileViaWeb(page, { week_start: 'monday' });
|
||||
await page.reload();
|
||||
await expect(page.locator('.fc')).toBeVisible();
|
||||
|
||||
const firstHeader = page.locator('.fc-col-header-cell').first();
|
||||
await expect(firstHeader).toContainText('Mon');
|
||||
});
|
||||
|
||||
test('week start day: sunday shows Sun as first column', async ({ page }) => {
|
||||
test('week start day: sunday shows Sun as first column', async ({ page, ctx }) => {
|
||||
await updateUserProfileViaApi(ctx, { week_start: 'sunday' });
|
||||
await goToCalendar(page);
|
||||
await updateUserProfileViaWeb(page, { week_start: 'sunday' });
|
||||
await page.reload();
|
||||
await expect(page.locator('.fc')).toBeVisible();
|
||||
|
||||
const firstHeader = page.locator('.fc-col-header-cell').first();
|
||||
await expect(firstHeader).toContainText('Sun');
|
||||
|
||||
// Reset to monday for other tests
|
||||
await updateUserProfileViaWeb(page, { week_start: 'monday' });
|
||||
});
|
||||
|
||||
test('12-hour time format shows AM/PM on slot labels', async ({ page, ctx }) => {
|
||||
|
||||
@@ -348,7 +348,7 @@ test.describe('Command Palette', () => {
|
||||
const newOrgName = 'TestOrg' + Math.floor(Math.random() * 10000);
|
||||
|
||||
// Create a new organization
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/teams/create');
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/organizations/create');
|
||||
await page.getByLabel('Organization Name').fill(newOrgName);
|
||||
await page.getByRole('button', { name: 'Create' }).click();
|
||||
|
||||
@@ -393,7 +393,7 @@ test.describe('Command Palette', () => {
|
||||
const newOrgName = 'GroupTestOrg' + Math.floor(Math.random() * 10000);
|
||||
|
||||
// Create a new organization to ensure we have multiple
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/teams/create');
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/organizations/create');
|
||||
await page.getByLabel('Organization Name').fill(newOrgName);
|
||||
await page.getByRole('button', { name: 'Create' }).click();
|
||||
await expect(page.getByTestId('dashboard_view')).toBeVisible({ timeout: 10000 });
|
||||
|
||||
@@ -55,6 +55,33 @@ test('test that organization name can be updated', async ({ page }) => {
|
||||
);
|
||||
});
|
||||
|
||||
test('test that organization currency can be updated', async ({ page }) => {
|
||||
await goToOrganizationSettings(page);
|
||||
await page.getByLabel('Currency', { exact: true }).selectOption('USD');
|
||||
await Promise.all([
|
||||
page.waitForRequest(
|
||||
(request) =>
|
||||
request.url().includes('/api/v1/organizations/') &&
|
||||
request.method() === 'PUT' &&
|
||||
request.postDataJSON().currency === 'USD'
|
||||
),
|
||||
page.waitForResponse(
|
||||
async (response) =>
|
||||
response.url().includes('/api/v1/organizations/') &&
|
||||
response.request().method() === 'PUT' &&
|
||||
response.status() === 200 &&
|
||||
(await response.json()).data.currency === 'USD'
|
||||
),
|
||||
page
|
||||
.locator('form')
|
||||
.filter({ hasText: 'Organization Name' })
|
||||
.getByRole('button', { name: 'Save' })
|
||||
.click(),
|
||||
]);
|
||||
await page.reload();
|
||||
await expect(page.getByLabel('Currency', { exact: true })).toHaveValue('USD');
|
||||
});
|
||||
|
||||
test('test that organization billable rate can be updated with all existing time entries', async ({
|
||||
page,
|
||||
}) => {
|
||||
@@ -387,7 +414,7 @@ test('test that format settings persist after page reload', async ({ page }) =>
|
||||
|
||||
test.describe('Organization Create, Delete & Switch', () => {
|
||||
async function createOrganization(page, name: string) {
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/teams/create');
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/organizations/create');
|
||||
await page.getByLabel('Organization Name').fill(name);
|
||||
await Promise.all([
|
||||
page.waitForResponse(
|
||||
@@ -413,7 +440,7 @@ test.describe('Organization Create, Delete & Switch', () => {
|
||||
});
|
||||
|
||||
test('does not create an organization when the name is empty', async ({ page }) => {
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/teams/create');
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/organizations/create');
|
||||
|
||||
// The form posts to the API, which rejects the empty name with a 422.
|
||||
await Promise.all([
|
||||
@@ -427,8 +454,7 @@ test.describe('Organization Create, Delete & Switch', () => {
|
||||
]);
|
||||
|
||||
// Validation failed, so we stay on the create form and never reach a
|
||||
// dashboard. ('/teams/create' redirects to '/organizations/create', so
|
||||
// assert on the form rather than the URL.)
|
||||
// dashboard. Assert on the form rather than the URL.
|
||||
await expect(page.getByText('Organization Details')).toBeVisible();
|
||||
await expect(page.getByRole('alert')).toContainText('The name field is required.');
|
||||
await expect(page.getByLabel('Organization Name')).toHaveAttribute('aria-invalid', 'true');
|
||||
@@ -505,7 +531,7 @@ test.describe('Organization Create, Delete & Switch', () => {
|
||||
|
||||
test.describe('Admin Organization Settings Access', () => {
|
||||
test('admin can see and edit organization settings', async ({ ctx, admin }) => {
|
||||
await admin.page.goto(PLAYWRIGHT_BASE_URL + '/teams/' + ctx.orgId);
|
||||
await admin.page.goto(PLAYWRIGHT_BASE_URL + '/organizations/' + ctx.orgId);
|
||||
|
||||
// Organization Name section is visible
|
||||
await expect(
|
||||
@@ -542,7 +568,7 @@ test.describe('Admin Organization Settings Access', () => {
|
||||
|
||||
test.describe('Employee Organization Settings Restrictions', () => {
|
||||
test('employee can see org name but not editable settings', async ({ ctx, employee }) => {
|
||||
await employee.page.goto(PLAYWRIGHT_BASE_URL + '/teams/' + ctx.orgId);
|
||||
await employee.page.goto(PLAYWRIGHT_BASE_URL + '/organizations/' + ctx.orgId);
|
||||
|
||||
// Organization Name section is visible (but inputs are disabled)
|
||||
await expect(
|
||||
|
||||
192
e2e/two-factor.spec.ts
Normal file
192
e2e/two-factor.spec.ts
Normal file
@@ -0,0 +1,192 @@
|
||||
import { test, expect } from '../playwright/fixtures';
|
||||
import { PLAYWRIGHT_BASE_URL, TEST_USER_PASSWORD } from '../playwright/config';
|
||||
import { generateTotpCode, generateInvalidTotpCode } from './utils/totp';
|
||||
import type { Page } from '@playwright/test';
|
||||
|
||||
async function goToProfilePage(page: Page) {
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/user/profile');
|
||||
}
|
||||
|
||||
/**
|
||||
* ConfirmsPassword only opens the dialog when the password has not been
|
||||
* confirmed recently, so fill it only when it actually shows up.
|
||||
*/
|
||||
async function confirmPasswordIfPrompted(page: Page) {
|
||||
const dialog = page.getByRole('dialog');
|
||||
const appeared = await dialog
|
||||
.waitFor({ state: 'visible', timeout: 2500 })
|
||||
.then(() => true)
|
||||
.catch(() => false);
|
||||
if (appeared) {
|
||||
await dialog.getByPlaceholder('Password').fill(TEST_USER_PASSWORD);
|
||||
await dialog.getByRole('button', { name: 'Confirm' }).click();
|
||||
await expect(dialog).not.toBeVisible();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Enables 2FA from the profile page and returns the TOTP secret (setup key)
|
||||
* and the recovery codes fetched right after enabling.
|
||||
*/
|
||||
async function enableTwoFactor(page: Page): Promise<{ secret: string; recoveryCodes: string[] }> {
|
||||
await goToProfilePage(page);
|
||||
await page
|
||||
.getByText('You have not enabled two factor authentication.')
|
||||
.locator('..')
|
||||
.getByRole('button', { name: 'Enable' })
|
||||
.click();
|
||||
|
||||
const dialog = page.getByRole('dialog');
|
||||
await expect(dialog).toBeVisible();
|
||||
|
||||
const recoveryCodesResponse = page.waitForResponse(
|
||||
(response) =>
|
||||
response.url().includes('/user/two-factor-recovery-codes') &&
|
||||
response.request().method() === 'GET'
|
||||
);
|
||||
await dialog.getByPlaceholder('Password').fill(TEST_USER_PASSWORD);
|
||||
await dialog.getByRole('button', { name: 'Confirm' }).click();
|
||||
|
||||
await expect(page.getByRole('heading', { name: 'Finish enabling two factor' })).toBeVisible();
|
||||
const recoveryCodes: string[] = await (await recoveryCodesResponse).json();
|
||||
|
||||
const setupKeyText = await page.getByText('Setup Key:').textContent();
|
||||
const secret = setupKeyText!.replace('Setup Key:', '').trim();
|
||||
expect(secret.length).toBeGreaterThan(0);
|
||||
|
||||
return { secret, recoveryCodes };
|
||||
}
|
||||
|
||||
/**
|
||||
* Confirms a freshly enabled 2FA setup with a valid TOTP code.
|
||||
*/
|
||||
async function confirmTwoFactor(page: Page, secret: string) {
|
||||
await page.getByLabel('Code').fill(generateTotpCode(secret));
|
||||
await page.getByRole('button', { name: 'Confirm', exact: true }).click();
|
||||
await confirmPasswordIfPrompted(page);
|
||||
await expect(page.getByText('You have enabled two factor authentication.')).toBeVisible();
|
||||
}
|
||||
|
||||
async function logout(page: Page) {
|
||||
await page.getByTestId('current_user_button').click();
|
||||
await page.getByText('Log Out', { exact: true }).click();
|
||||
await page.waitForURL(PLAYWRIGHT_BASE_URL + '/login');
|
||||
}
|
||||
|
||||
/**
|
||||
* Reads the email of the current user from the profile form, waiting until
|
||||
* the user query has populated it.
|
||||
*/
|
||||
async function getProfileEmail(page: Page): Promise<string> {
|
||||
await goToProfilePage(page);
|
||||
const emailInput = page.getByLabel('Email', { exact: true });
|
||||
await expect(emailInput).toHaveValue(/@/);
|
||||
return await emailInput.inputValue();
|
||||
}
|
||||
|
||||
async function loginUntilTwoFactorChallenge(page: Page, email: string) {
|
||||
await page.goto(PLAYWRIGHT_BASE_URL + '/login');
|
||||
await page.getByLabel('Email').fill(email);
|
||||
await page.getByLabel('Password').fill(TEST_USER_PASSWORD);
|
||||
await page.getByRole('button', { name: 'Log in' }).click();
|
||||
await page.waitForURL(PLAYWRIGHT_BASE_URL + '/two-factor-challenge');
|
||||
}
|
||||
|
||||
test('test that 2FA can be confirmed with a TOTP code and shows recovery codes', async ({
|
||||
page,
|
||||
}) => {
|
||||
const { secret, recoveryCodes } = await enableTwoFactor(page);
|
||||
await confirmTwoFactor(page, secret);
|
||||
|
||||
await expect(page.getByText('Store these recovery codes')).toBeVisible();
|
||||
expect(recoveryCodes.length).toBeGreaterThan(0);
|
||||
for (const code of recoveryCodes) {
|
||||
await expect(page.getByText(code)).toBeVisible();
|
||||
}
|
||||
|
||||
// The confirmed state survives a reload
|
||||
await page.reload();
|
||||
await expect(page.getByText('You have enabled two factor authentication.')).toBeVisible();
|
||||
});
|
||||
|
||||
test('test that 2FA confirmation fails with an invalid TOTP code', async ({ page }) => {
|
||||
const { secret } = await enableTwoFactor(page);
|
||||
|
||||
await page.getByLabel('Code').fill(generateInvalidTotpCode(secret));
|
||||
await page.getByRole('button', { name: 'Confirm', exact: true }).click();
|
||||
await confirmPasswordIfPrompted(page);
|
||||
|
||||
await expect(page.getByRole('alert')).toContainText(
|
||||
'The provided two factor authentication code was invalid.'
|
||||
);
|
||||
await expect(page.getByRole('heading', { name: 'Finish enabling two factor' })).toBeVisible();
|
||||
});
|
||||
|
||||
test('test that recovery codes can be regenerated', async ({ page }) => {
|
||||
const { secret, recoveryCodes } = await enableTwoFactor(page);
|
||||
await confirmTwoFactor(page, secret);
|
||||
|
||||
const newCodesResponse = page.waitForResponse(
|
||||
(response) =>
|
||||
response.url().includes('/user/two-factor-recovery-codes') &&
|
||||
response.request().method() === 'GET'
|
||||
);
|
||||
await page.getByRole('button', { name: 'Regenerate Recovery Codes' }).click();
|
||||
await confirmPasswordIfPrompted(page);
|
||||
const newCodes: string[] = await (await newCodesResponse).json();
|
||||
|
||||
expect(newCodes).not.toEqual(recoveryCodes);
|
||||
await expect(page.getByText(newCodes[0])).toBeVisible();
|
||||
await expect(page.getByText(recoveryCodes[0])).not.toBeVisible();
|
||||
});
|
||||
|
||||
test('test that 2FA can be disabled', async ({ page }) => {
|
||||
const { secret } = await enableTwoFactor(page);
|
||||
await confirmTwoFactor(page, secret);
|
||||
|
||||
await page.getByRole('button', { name: 'Disable' }).click();
|
||||
await confirmPasswordIfPrompted(page);
|
||||
await expect(page.getByText('You have not enabled two factor authentication.')).toBeVisible();
|
||||
|
||||
// The disabled state survives a reload
|
||||
await page.reload();
|
||||
await expect(page.getByText('You have not enabled two factor authentication.')).toBeVisible();
|
||||
});
|
||||
|
||||
test('test that login challenges for a TOTP code and rejects an invalid code', async ({ page }) => {
|
||||
const email = await getProfileEmail(page);
|
||||
|
||||
const { secret } = await enableTwoFactor(page);
|
||||
await confirmTwoFactor(page, secret);
|
||||
await logout(page);
|
||||
|
||||
await loginUntilTwoFactorChallenge(page, email);
|
||||
|
||||
await page.getByLabel('Code').fill(generateInvalidTotpCode(secret));
|
||||
await page.getByRole('button', { name: 'Log in' }).click();
|
||||
await expect(page.getByRole('alert')).toContainText(
|
||||
'The provided two factor authentication code was invalid.'
|
||||
);
|
||||
|
||||
// Fortify rejects replayed codes, and the current window's code was
|
||||
// already consumed when confirming the setup — use the next window's
|
||||
// code, which the +/- 1 step verification window also accepts.
|
||||
await page.getByLabel('Code').fill(generateTotpCode(secret, Date.now() + 30_000));
|
||||
await page.getByRole('button', { name: 'Log in' }).click();
|
||||
await expect(page.getByTestId('dashboard_view')).toBeVisible();
|
||||
});
|
||||
|
||||
test('test that login works with a recovery code', async ({ page }) => {
|
||||
const email = await getProfileEmail(page);
|
||||
|
||||
const { secret, recoveryCodes } = await enableTwoFactor(page);
|
||||
await confirmTwoFactor(page, secret);
|
||||
await logout(page);
|
||||
|
||||
await loginUntilTwoFactorChallenge(page, email);
|
||||
|
||||
await page.getByRole('button', { name: 'Use a recovery code' }).click();
|
||||
await page.getByLabel('Recovery Code').fill(recoveryCodes[0]);
|
||||
await page.getByRole('button', { name: 'Log in' }).click();
|
||||
await expect(page.getByTestId('dashboard_view')).toBeVisible();
|
||||
});
|
||||
@@ -641,10 +641,13 @@ export async function updateOrganizationCurrencyViaWeb(
|
||||
const xsrfCookie = cookies.find((c) => c.name === 'XSRF-TOKEN');
|
||||
const xsrfToken = xsrfCookie ? decodeURIComponent(xsrfCookie.value) : '';
|
||||
|
||||
const response = await page.request.put(`${PLAYWRIGHT_BASE_URL}/teams/${ctx.orgId}`, {
|
||||
headers: { 'X-XSRF-TOKEN': xsrfToken },
|
||||
data: { name, currency },
|
||||
});
|
||||
const response = await page.request.put(
|
||||
`${PLAYWRIGHT_BASE_URL}/api/v1/organizations/${ctx.orgId}`,
|
||||
{
|
||||
headers: { 'X-XSRF-TOKEN': xsrfToken },
|
||||
data: { name, currency },
|
||||
}
|
||||
);
|
||||
expect(response.status()).toBe(200);
|
||||
}
|
||||
|
||||
@@ -801,53 +804,23 @@ export async function getCurrentUserViaApi(ctx: TestContext) {
|
||||
};
|
||||
}
|
||||
|
||||
export async function updateUserProfileViaWeb(
|
||||
page: Page,
|
||||
export async function updateUserProfileViaApi(
|
||||
ctx: TestContext,
|
||||
settings: { timezone?: string; week_start?: string }
|
||||
) {
|
||||
// Read user info from Inertia's data-page attribute on the root element
|
||||
const userInfo = await page.evaluate(() => {
|
||||
// Try Inertia's data-page attribute (stores initial page props as JSON)
|
||||
const appEl = document.getElementById('app');
|
||||
if (appEl) {
|
||||
const dataPage = appEl.getAttribute('data-page');
|
||||
if (dataPage) {
|
||||
try {
|
||||
const parsed = JSON.parse(dataPage);
|
||||
const user = parsed?.props?.auth?.user;
|
||||
if (user) {
|
||||
return {
|
||||
name: user.name,
|
||||
email: user.email,
|
||||
timezone: user.timezone,
|
||||
week_start: user.week_start,
|
||||
};
|
||||
}
|
||||
} catch {
|
||||
// JSON parse failed
|
||||
}
|
||||
}
|
||||
}
|
||||
return null;
|
||||
});
|
||||
if (!userInfo) throw new Error('Could not read user info from Inertia data-page attribute');
|
||||
const user = await getCurrentUserViaApi(ctx);
|
||||
|
||||
const cookies = await page.context().cookies();
|
||||
const xsrfCookie = cookies.find((c) => c.name === 'XSRF-TOKEN');
|
||||
const xsrfToken = xsrfCookie ? decodeURIComponent(xsrfCookie.value) : '';
|
||||
// Only send the fields under test; the endpoint leaves omitted fields untouched.
|
||||
const data: Record<string, string> = {};
|
||||
if (settings.timezone !== undefined) {
|
||||
data.timezone = settings.timezone;
|
||||
}
|
||||
if (settings.week_start !== undefined) {
|
||||
data.week_start = settings.week_start;
|
||||
}
|
||||
|
||||
const response = await page.request.put(`${PLAYWRIGHT_BASE_URL}/user/profile-information`, {
|
||||
headers: {
|
||||
'X-XSRF-TOKEN': xsrfToken,
|
||||
'Content-Type': 'application/json',
|
||||
Accept: 'application/json',
|
||||
},
|
||||
data: {
|
||||
name: userInfo.name,
|
||||
email: userInfo.email,
|
||||
timezone: settings.timezone ?? userInfo.timezone,
|
||||
week_start: settings.week_start ?? userInfo.week_start,
|
||||
},
|
||||
const response = await ctx.request.put(`${PLAYWRIGHT_BASE_URL}/api/v1/users/${user.id}`, {
|
||||
data,
|
||||
});
|
||||
expect(response.status()).toBe(200);
|
||||
}
|
||||
|
||||
58
e2e/utils/totp.ts
Normal file
58
e2e/utils/totp.ts
Normal file
@@ -0,0 +1,58 @@
|
||||
import { createHmac } from 'node:crypto';
|
||||
|
||||
const BASE32_ALPHABET = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ234567';
|
||||
|
||||
function base32Decode(input: string): Buffer {
|
||||
const normalized = input
|
||||
.toUpperCase()
|
||||
.replace(/=+$/, '')
|
||||
.replace(/[^A-Z2-7]/g, '');
|
||||
let bits = 0;
|
||||
let value = 0;
|
||||
const bytes: number[] = [];
|
||||
for (const char of normalized) {
|
||||
value = (value << 5) | BASE32_ALPHABET.indexOf(char);
|
||||
bits += 5;
|
||||
if (bits >= 8) {
|
||||
bytes.push((value >>> (bits - 8)) & 0xff);
|
||||
bits -= 8;
|
||||
}
|
||||
}
|
||||
return Buffer.from(bytes);
|
||||
}
|
||||
|
||||
/**
|
||||
* Generates a 6-digit TOTP code (RFC 6238, SHA-1, 30 second period) for the
|
||||
* given base32 secret — the "Setup Key" shown while enabling 2FA.
|
||||
*/
|
||||
export function generateTotpCode(base32Secret: string, atMs: number = Date.now()): string {
|
||||
const counter = Math.floor(atMs / 1000 / 30);
|
||||
const counterBuffer = Buffer.alloc(8);
|
||||
counterBuffer.writeBigUInt64BE(BigInt(counter));
|
||||
const digest = createHmac('sha1', base32Decode(base32Secret)).update(counterBuffer).digest();
|
||||
const offset = digest[digest.length - 1] & 0x0f;
|
||||
const code =
|
||||
((digest[offset] & 0x7f) << 24) |
|
||||
((digest[offset + 1] & 0xff) << 16) |
|
||||
((digest[offset + 2] & 0xff) << 8) |
|
||||
(digest[offset + 3] & 0xff);
|
||||
return (code % 1_000_000).toString().padStart(6, '0');
|
||||
}
|
||||
|
||||
/**
|
||||
* Generates a syntactically valid TOTP code that is guaranteed to be rejected,
|
||||
* by using a timestamp far outside the accepted verification window.
|
||||
*/
|
||||
export function generateInvalidTotpCode(base32Secret: string): string {
|
||||
const validNow = [
|
||||
generateTotpCode(base32Secret, Date.now() - 30_000),
|
||||
generateTotpCode(base32Secret),
|
||||
generateTotpCode(base32Secret, Date.now() + 30_000),
|
||||
];
|
||||
for (let minutes = 10; ; minutes++) {
|
||||
const candidate = generateTotpCode(base32Secret, Date.now() + minutes * 60_000);
|
||||
if (!validNow.includes(candidate)) {
|
||||
return candidate;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -61,7 +61,7 @@ const switchToTeam = (organization: Organization) => {
|
||||
|
||||
<DropdownMenuItem as-child>
|
||||
<Link
|
||||
:href="route('teams.show', page.props.auth.user.current_team.id)"
|
||||
:href="route('organizations.show', page.props.auth.user.current_team.id)"
|
||||
class="inline-flex items-center gap-2.5 w-full">
|
||||
<Cog6ToothIcon class="w-5 h-5 text-icon-default" />
|
||||
<span>Organization Settings</span>
|
||||
@@ -74,7 +74,7 @@ const switchToTeam = (organization: Organization) => {
|
||||
|
||||
<DropdownMenuItem as-child>
|
||||
<Link
|
||||
:href="route('teams.create')"
|
||||
:href="route('organizations.create')"
|
||||
class="inline-flex items-center gap-2.5 w-full">
|
||||
<PlusCircleIcon class="w-5 h-5 text-icon-default" />
|
||||
<span>Create new organization</span>
|
||||
|
||||
@@ -280,10 +280,15 @@ const page = usePage<{
|
||||
v-if="canUpdateOrganization()"
|
||||
title="Settings"
|
||||
:icon="Cog6ToothIcon"
|
||||
:href="route('teams.show', page.props.auth.user.current_team.id)"
|
||||
:href="
|
||||
route(
|
||||
'organizations.show',
|
||||
page.props.auth.user.current_team.id
|
||||
)
|
||||
"
|
||||
:current="
|
||||
route().current(
|
||||
'teams.show',
|
||||
'organizations.show',
|
||||
page.props.auth.user.current_team.id
|
||||
)
|
||||
"></NavigationSidebarItem>
|
||||
|
||||
@@ -330,6 +330,7 @@ const OrganizationResource = z
|
||||
const OrganizationUpdateRequest = z
|
||||
.object({
|
||||
name: z.string().max(255),
|
||||
currency: z.string(),
|
||||
billable_rate: z.union([z.number(), z.null()]),
|
||||
employees_can_see_billable_rates: z.boolean(),
|
||||
employees_can_manage_tasks: z.boolean(),
|
||||
|
||||
@@ -210,7 +210,7 @@ export function createNavigationCommands(
|
||||
icon: Cog6ToothIcon,
|
||||
keywords: ['settings', 'organization', 'configuration'],
|
||||
group: 'navigation',
|
||||
action: () => navigate('teams.show', { team: currentTeamId() }),
|
||||
action: () => navigate('organizations.show', { organizationId: currentTeamId() }),
|
||||
permission: permissions.canUpdateOrganization,
|
||||
priority: GROUP_PRIORITIES.navigation - 3,
|
||||
},
|
||||
|
||||
7
resources/js/ziggy.d.ts
vendored
7
resources/js/ziggy.d.ts
vendored
@@ -114,6 +114,13 @@ declare module 'ziggy-js' {
|
||||
'other-browser-sessions.destroy': [];
|
||||
'current-user-photo.destroy': [];
|
||||
'current-user.destroy': [];
|
||||
'organizations.create': [];
|
||||
'organizations.show': [
|
||||
{
|
||||
'name': 'organizationId';
|
||||
'required': true;
|
||||
},
|
||||
];
|
||||
'teams.create': [];
|
||||
'teams.store': [];
|
||||
'teams.show': [
|
||||
|
||||
@@ -197,6 +197,12 @@ const Ziggy = {
|
||||
'methods': ['DELETE'],
|
||||
},
|
||||
'current-user.destroy': { 'uri': 'user', 'methods': ['DELETE'] },
|
||||
'organizations.create': { 'uri': 'organizations/create', 'methods': ['GET', 'HEAD'] },
|
||||
'organizations.show': {
|
||||
'uri': 'organizations/{organizationId}',
|
||||
'methods': ['GET', 'HEAD'],
|
||||
'parameters': ['organizationId'],
|
||||
},
|
||||
'teams.create': { 'uri': 'teams/create', 'methods': ['GET', 'HEAD'] },
|
||||
'teams.store': { 'uri': 'teams', 'methods': ['POST'] },
|
||||
'teams.show': {
|
||||
|
||||
@@ -6,6 +6,7 @@ use App\Http\Controllers\Web\DashboardController;
|
||||
use App\Http\Controllers\Web\HomeController;
|
||||
use App\Http\Controllers\Web\OrganizationController;
|
||||
use App\Http\Controllers\Web\OrganizationInvitationController;
|
||||
use App\Http\Controllers\Web\OtherBrowserSessionsController;
|
||||
use App\Http\Controllers\Web\UserController;
|
||||
use App\Http\Controllers\Web\UserProfileController;
|
||||
use App\Service\PermissionStore;
|
||||
@@ -102,6 +103,8 @@ Route::middleware([
|
||||
return to_route('organizations.show', [$organizationId]);
|
||||
})->name('teams.show');
|
||||
Route::get('/user/profile', [UserProfileController::class, 'show'])->name('profile.show');
|
||||
Route::delete('/user/other-browser-sessions', [OtherBrowserSessionsController::class, 'destroy'])
|
||||
->name('other-browser-sessions.destroy');
|
||||
});
|
||||
|
||||
Route::get('/team-invitations/{invitation}', [OrganizationInvitationController::class, 'accept'])
|
||||
|
||||
@@ -1,25 +0,0 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace Tests\Feature;
|
||||
|
||||
use App\Models\User;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Tests\TestCase;
|
||||
|
||||
class BrowserSessionsTest extends TestCase
|
||||
{
|
||||
use RefreshDatabase;
|
||||
|
||||
public function test_other_browser_sessions_can_be_logged_out(): void
|
||||
{
|
||||
$this->actingAs($user = User::factory()->create());
|
||||
|
||||
$response = $this->delete('/user/other-browser-sessions', [
|
||||
'password' => 'password',
|
||||
]);
|
||||
|
||||
$response->assertSessionHasNoErrors();
|
||||
}
|
||||
}
|
||||
@@ -382,6 +382,58 @@ class OrganizationEndpointTest extends ApiEndpointTestAbstract
|
||||
]);
|
||||
}
|
||||
|
||||
public function test_update_endpoint_can_update_the_currency_of_the_organization(): void
|
||||
{
|
||||
// Arrange
|
||||
$data = $this->createUserWithPermission([
|
||||
'organizations:update',
|
||||
]);
|
||||
$this->assertBillableRateServiceIsUnused();
|
||||
$data->organization->currency = 'EUR';
|
||||
$data->organization->save();
|
||||
Passport::actingAs($data->user);
|
||||
|
||||
// Act
|
||||
$response = $this->putJson(route('api.v1.organizations.update', [$data->organization->getKey()]), [
|
||||
'name' => $data->organization->name,
|
||||
'currency' => 'USD',
|
||||
]);
|
||||
|
||||
// Assert
|
||||
$response->assertStatus(200);
|
||||
$response->assertJsonPath('data.currency', 'USD');
|
||||
$this->assertDatabaseHas(Organization::class, [
|
||||
'id' => $data->organization->getKey(),
|
||||
'currency' => 'USD',
|
||||
]);
|
||||
}
|
||||
|
||||
public function test_update_endpoint_fails_if_currency_is_invalid(): void
|
||||
{
|
||||
// Arrange
|
||||
$data = $this->createUserWithPermission([
|
||||
'organizations:update',
|
||||
]);
|
||||
$this->assertBillableRateServiceIsUnused();
|
||||
$data->organization->currency = 'EUR';
|
||||
$data->organization->save();
|
||||
Passport::actingAs($data->user);
|
||||
|
||||
// Act
|
||||
$response = $this->putJson(route('api.v1.organizations.update', [$data->organization->getKey()]), [
|
||||
'name' => $data->organization->name,
|
||||
'currency' => 'NOT_A_CURRENCY',
|
||||
]);
|
||||
|
||||
// Assert
|
||||
$response->assertStatus(422);
|
||||
$response->assertJsonValidationErrors(['currency']);
|
||||
$this->assertDatabaseHas(Organization::class, [
|
||||
'id' => $data->organization->getKey(),
|
||||
'currency' => 'EUR',
|
||||
]);
|
||||
}
|
||||
|
||||
public function test_delete_endpoint_if_user_does_not_have_permission(): void
|
||||
{
|
||||
// Arrange
|
||||
|
||||
103
tests/Unit/Endpoint/Web/OtherBrowserSessionsEndpointTest.php
Normal file
103
tests/Unit/Endpoint/Web/OtherBrowserSessionsEndpointTest.php
Normal file
@@ -0,0 +1,103 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace Tests\Unit\Endpoint\Web;
|
||||
|
||||
use App\Http\Controllers\Web\OtherBrowserSessionsController;
|
||||
use App\Models\User;
|
||||
use Illuminate\Support\Facades\DB;
|
||||
use Illuminate\Support\Facades\Hash;
|
||||
use PHPUnit\Framework\Attributes\CoversClass;
|
||||
|
||||
#[CoversClass(OtherBrowserSessionsController::class)]
|
||||
class OtherBrowserSessionsEndpointTest extends EndpointTestAbstract
|
||||
{
|
||||
public function test_destroy_logs_out_other_browser_sessions_with_the_correct_password(): void
|
||||
{
|
||||
// Arrange
|
||||
$user = User::factory()->create();
|
||||
$originalPasswordHash = $user->password;
|
||||
$this->actingAs($user);
|
||||
|
||||
// Act
|
||||
$response = $this->delete('/user/other-browser-sessions', [
|
||||
'password' => 'password',
|
||||
]);
|
||||
|
||||
// Assert
|
||||
$response->assertRedirect();
|
||||
$response->assertSessionHasNoErrors();
|
||||
// logoutOtherDevices re-hashes the password (same plaintext, new hash) to invalidate other sessions.
|
||||
$this->assertNotSame($originalPasswordHash, $user->fresh()->password);
|
||||
$this->assertTrue(Hash::check('password', $user->fresh()->password));
|
||||
}
|
||||
|
||||
public function test_destroy_fails_with_an_incorrect_password(): void
|
||||
{
|
||||
// Arrange
|
||||
$user = User::factory()->create();
|
||||
$originalPasswordHash = $user->password;
|
||||
$this->actingAs($user);
|
||||
|
||||
// Act
|
||||
$response = $this->delete('/user/other-browser-sessions', [
|
||||
'password' => 'wrong-password',
|
||||
]);
|
||||
|
||||
// Assert
|
||||
$response->assertSessionHasErrors('password');
|
||||
// No side effects when the password is incorrect: the password must not be re-hashed.
|
||||
$this->assertSame($originalPasswordHash, $user->fresh()->password);
|
||||
}
|
||||
|
||||
public function test_destroy_requires_authentication(): void
|
||||
{
|
||||
// Act
|
||||
$response = $this->delete('/user/other-browser-sessions', [
|
||||
'password' => 'password',
|
||||
]);
|
||||
|
||||
// Assert
|
||||
$response->assertRedirect(route('login'));
|
||||
}
|
||||
|
||||
public function test_destroy_deletes_the_other_database_session_records_of_the_current_user(): void
|
||||
{
|
||||
// Arrange
|
||||
config(['session.driver' => 'database']);
|
||||
$user = User::factory()->create();
|
||||
$otherUser = User::factory()->create();
|
||||
$this->actingAs($user);
|
||||
|
||||
DB::table('sessions')->insert([
|
||||
[
|
||||
'id' => 'other-session-of-current-user',
|
||||
'user_id' => $user->getKey(),
|
||||
'ip_address' => '192.0.2.10',
|
||||
'user_agent' => '',
|
||||
'payload' => '',
|
||||
'last_activity' => now()->subMinutes(5)->timestamp,
|
||||
],
|
||||
[
|
||||
'id' => 'session-of-another-user',
|
||||
'user_id' => $otherUser->getKey(),
|
||||
'ip_address' => '192.0.2.30',
|
||||
'user_agent' => '',
|
||||
'payload' => '',
|
||||
'last_activity' => now()->timestamp,
|
||||
],
|
||||
]);
|
||||
|
||||
// Act
|
||||
$response = $this->delete('/user/other-browser-sessions', [
|
||||
'password' => 'password',
|
||||
]);
|
||||
|
||||
// Assert
|
||||
$response->assertSessionHasNoErrors();
|
||||
// The current user's other sessions are removed, while another user's session is untouched.
|
||||
$this->assertDatabaseMissing('sessions', ['id' => 'other-session-of-current-user']);
|
||||
$this->assertDatabaseHas('sessions', ['id' => 'session-of-another-user']);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user