Commit Graph

1262 Commits

Author SHA1 Message Date
Constantin Graf
aeeacfb592 Add tests for billable rate restriction in importers and API edge cases 2026-10-14 14:49:20 +02:00
Constantin Graf
bcae6382db Only check billable rate restriction if time entry becomes billable 2026-10-14 14:48:52 +02:00
Constantin Graf
0fa6f8c005 Move billable rate restriction tests to the endpoint tests of the specific endpoints 2026-10-14 14:48:52 +02:00
Constantin Graf
24b937767e Enforce billable rate restriction in controllers and importers instead of model hooks 2026-10-14 14:48:52 +02:00
Gregor Vostrak
ab0158f77a update invoicing and billing extensions to tagged releases 2026-10-14 14:48:52 +02:00
Gregor Vostrak
a3fd5b95e6 load billable rate limits extension branches for billing and invoicing 2026-10-14 14:48:51 +02:00
Gregor Vostrak
5a9c8a8bf7 add billable rate restriction for free organizations 2026-10-14 14:48:51 +02:00
Gregor Vostrak
deb0c26e32 move upgrade modal to ui package and add trial status and cancel trial ui 2026-10-14 14:48:51 +02:00
Gregor Vostrak
11dd4e174e add time entry filter normalizeation 2026-10-14 14:11:16 +02:00
Constantin Graf
b73cdc4bb5 Detect time entries with a task but no project in consistency check
The comparison used != which evaluates to NULL when the time entry has no
project, so entries that kept their task after the project was removed
were not reported.
2026-10-14 13:20:21 +02:00
Gregor Vostrak
e82c601449 Remove task from time entry when project changes without a new task
PUT /time-entries/{id} accepted a new project_id while keeping a task from
the previous project, leaving the entry with a task that belongs to a
different project. The bulk endpoint already handled a project switch but
kept the task when the project was removed.

Both endpoints now remove the task whenever project_id is changed without
task_id and the current task does not belong to the new project.
2026-10-14 13:20:21 +02:00
Constantin Graf
f65a1532ad Delete running time entries of placeholder when merging members
The running time entries of the merged member could give the destination
member a second running time entry. The placeholder is deleted after the
merge, so its running time entries can not stay with it.
2026-10-14 11:11:53 +02:00
Constantin Graf
b42e84294c Skip running time entries in solidtime import
Imported running time entries could give a user a second running time
entry, for example when an export is imported again while a timer runs.
2026-10-14 11:11:53 +02:00
Constantin Graf
1863953a23 Reject changing the member of running time entries
Moving a running time entry to another member could give that member's
user a second running time entry. Stopping the time entry and changing
the member in the same request is still allowed.
2026-10-14 11:11:53 +02:00
Constantin Graf
ce9413a55e Allow only one running time entry per user across organizations
The running time entry check in the store endpoint was scoped to the
member, so a user could start a time entry in each of their
organizations. The active time entry endpoint and the database
consistency check expect only one running time entry per user.
2026-10-14 11:11:53 +02:00
Constantin Graf
b08364770c Lock creation of running time entries to prevent race condition
Concurrent requests could both pass the running time entry check and
create more than one running time entry for the same member.
2026-10-14 11:11:53 +02:00
Constantin Graf
26926d3b2c Add correction command to delete time entries with end before start 2026-10-14 10:45:36 +02:00
Constantin Graf
fd008dd4a8 Prevent time entries with end before start
Partial updates of time entries only validated end against start if both
were part of the payload. Start and end are now also validated against the
persisted value if only one of them is sent (fixes #1189).

The importers now fail if the end of a time entry is before the start and
the database consistency check reports such time entries.
2026-10-14 10:45:36 +02:00
Constantin Graf
9a845bad8f Raise default ZIP file limit for imports to 10000
Toggl exports contain two files per project, so the previous limit of 100 rejected workspaces with more than about 40 projects.
2026-10-14 10:45:15 +02:00
Constantin Graf
b9e3f55537 Store admin panel import uploads on private disk and delete them after import
The Filament import upload was stored on the public disk and never deleted.
2026-10-14 10:45:15 +02:00
Constantin Graf
0b2a417788 Store copy of import data on private disk for debugging
Re-adds the copy of the import data that was removed in 70646a0d. Every import stores its raw data in import/{date}-{organizationId}-{uuid} on the private disk.
2026-10-14 10:45:15 +02:00
Constantin Graf
65525791a6 Throw import exception for missing references in solidtime import
Time entries referencing a user, member, client, project or task that is not part of the import caused a TypeError, which surfaced as "Unknown error".
2026-10-14 10:45:15 +02:00
Constantin Graf
0c58896b00 Run OSS Scanner image on Octane/FrankenPHP and bundle Gotenberg
Production runs as long-lived Octane workers in FrankenPHP worker mode, so state leaking between requests
(static properties, singletons, ...) is a real risk that php artisan serve cannot reproduce. Base the scanner image
on the production FrankenPHP image, add start-octane.sh (single worker, production Caddyfile) and describe this
class of issue in the threat model.

Bundle Gotenberg (Chromium only) so the PDF export tests pass offline and PDF rendering can be exercised.
2026-10-09 18:10:44 +02:00
Constantin Graf
6301b0f4a1 Clarify that super admins are trusted in OSS Scanner threat model 2026-10-09 18:10:44 +02:00
Constantin Graf
4c993c8eb2 Add OSS Scanner build environment and threat model 2026-10-09 18:10:44 +02:00
Constantin Graf
ae6937d012 Updated auditing extension to v0.0.5 2026-10-09 15:09:41 +02:00
Constantin Graf
1256fa61bd Updated invoicing extension to v0.0.10 2026-10-09 14:42:41 +02:00
Constantin Graf
d6f80e23fb Run core PHPUnit tests with extensions enabled in CI 2026-10-09 14:42:41 +02:00
Gregor Vostrak
c994345de9 fix scramble diagnostics in goal resource and requests 2026-10-08 20:47:12 +02:00
Gregor Vostrak
e56a659723 remove PaginatedResourceCollection from goal collection after scramble 0.13 update 2026-10-08 20:47:12 +02:00
Gregor Vostrak
c3529e4373 improve goal target formatting in superadmin interface 2026-10-08 20:47:12 +02:00
Gregor Vostrak
81c923644d fix broken loading spinner position on initial load 2026-10-08 20:47:12 +02:00
Gregor Vostrak
689b2e93e1 move goal progress calculation out of the resources 2026-10-08 20:47:12 +02:00
Gregor Vostrak
63ca886154 Add goals feature for personal goals with filters 2026-10-08 20:47:12 +02:00
Constantin Graf
5010a5be3a Use database in API docs diagnostics test so Scramble can read model schemas 2026-10-08 16:39:46 +02:00
Constantin Graf
b05f275fe8 Updated invoicing extension to v0.0.9 2026-10-08 16:39:46 +02:00
Constantin Graf
f01a4111b6 Fix Scramble API docs warnings
Remove redundant @var annotations from API resources and defer the user
access in the email unique rule of UserUpdateRequest, so rules() can be
evaluated by Scramble without route model binding. Add a test that fails
on any Scramble diagnostic and tests for the email unique rule.
2026-10-08 16:39:46 +02:00
Gregor Vostrak
4a2f78931a add playwright e2e support for extensions 2026-10-08 16:07:26 +02:00
Constantin Graf
ed2f19f58b Fix API docs generation with Scramble 0.13
Scramble 0.13 moved the collected resource type of resource collections
to a different template slot, which broke the custom paginated resource
collection extension and the API docs export. Scramble now infers
paginated responses natively, so the extension, the marker interface and
the @return annotations that overrode the inference are removed.

Scramble 0.13 also documents closure routes, so the API fallback routes
are moved to a controller that is excluded from the docs.

Add a test that exports the API docs.
2026-10-08 12:38:03 +02:00
Constantin Graf
fde944a84f Updated extensions 2026-10-07 18:43:16 +02:00
Constantin Graf
34273a4863 Add audit owner through parent model
Models that belong to an organization via a parent model (for example
project members via their project) implement AuditableThroughParent and
return the parent relation. The owner organization of their audits is
taken from the loaded parent if it matches the foreign key, otherwise it
is queried. The declaration is also used to backfill the owner of
existing audits.
2026-10-07 18:43:16 +02:00
Constantin Graf
6fe721fc26 Updated extensions to audit improvement branches 2026-10-07 18:43:16 +02:00
Constantin Graf
f921452419 Add marker for auditable models without owner
Models implementing AuditableWithoutOwner intentionally have no audit
owner, either because they belong to neither an organization nor a user,
or because they and their audits have to be kept when the owner is
deleted (for example billing records). Adds helpers and a scope on the
audit model to find audits that are missing an owner although they
should have one.
2026-10-07 18:43:16 +02:00
Constantin Graf
30a90f80e0 Updated extensions to audit improvement branches 2026-10-07 18:43:16 +02:00
Constantin Graf
135984f9ef Add owner organization and owner user to audits
- Rename the audit actor columns user_type/user_id to actor_type/actor_id
- Add owner_organization_id and owner_user_id to the audits table as
  foreign keys with cascade on delete, so that the audits of an
  organization or user are deleted together with it. The indexes and
  foreign keys are created without blocking writes on the large table.
- Fill the owner columns for new audits via CustomAuditable. Organizations
  and users no longer record their own deletion audit, since it would
  reference the already deleted owner.
2026-10-07 18:43:16 +02:00
Constantin Graf
af54b0db73 Updated auditing extension 2026-10-07 18:43:16 +02:00
Constantin Graf
3fc2cec751 Updated services extension 2026-10-07 18:43:16 +02:00
Constantin Graf
32ac8841bc Remove debug output from TrustHostsTest 2026-10-07 18:28:29 +02:00
Constantin Graf
1582e6f4c3 Generate profile photo in user factory locally
Faker's image() downloads the image from via.placeholder.com, which no
longer exists. Since the domain resolves again but does not respond,
the download (without timeout) hangs and the PHPUnit runs time out.
The profile photo is now generated locally with GD, which also stores a
real image instead of the temporary file path returned by image().
2026-10-07 18:28:29 +02:00
Constantin Graf
01281d80d0 Rename DB_SSLMODE env to DB_SSL_MODE and add DATABASE_URL fallback
The Laravel 13 config update made sslmode read DB_SSLMODE, which the
self-hosting examples set to require, breaking instances whose database
does not support SSL. Use DB_SSL_MODE instead so existing values are
ignored again, and fall back to DATABASE_URL when DB_URL is not set.
2026-10-07 16:23:11 +02:00