adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-11 01:42:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(chromium): missing webp validation

Browse Source
This commit is contained in:
Julien Neuhart
2024-01-08 11:44:56 +01:00
parent afd3763d96
commit 0e8385a5a7
2 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/modules/chromium/routes.go
View File

@@ -171,7 +171,7 @@ func FormDataChromiumScreenshotOptions(ctx *api.Context) (*api.FormData, Screens
return nil
}
if value != "png" && value != "jpeg" && value != "" {
if value != "png" && value != "jpeg" && value != "webp" {
return fmt.Errorf("wrong value, expected either 'png', 'jpeg' or 'webp'")
}

36
pkg/modules/chromium/routes_test.go
View File

@@ -209,7 +209,24 @@ func TestFormDataChromiumScreenshotOptions(t *testing.T) {
}(),
},
{
scenario: "valid format form field",
scenario: "valid png format form field",
ctx: func() *api.ContextMock {
ctx := &api.ContextMock{Context: new(api.Context)}
ctx.SetValues(map[string][]string{
"format": {
"png",
},
})
return ctx
}(),
expectedOptions: func() ScreenshotOptions {
options := DefaultScreenshotOptions()
options.Format = "png"
return options
}(),
},
{
scenario: "valid jpeg format form field",
ctx: func() *api.ContextMock {
ctx := &api.ContextMock{Context: new(api.Context)}
ctx.SetValues(map[string][]string{
@@ -225,6 +242,23 @@ func TestFormDataChromiumScreenshotOptions(t *testing.T) {
return options
}(),
},
{
scenario: "valid webp format form field",
ctx: func() *api.ContextMock {
ctx := &api.ContextMock{Context: new(api.Context)}
ctx.SetValues(map[string][]string{
"format": {
"webp",
},
})
return ctx
}(),
expectedOptions: func() ScreenshotOptions {
options := DefaultScreenshotOptions()
options.Format = "webp"
return options
}(),
},
{
scenario: "invalid quality form field (not an integer)",
ctx: func() *api.ContextMock {