mirror of
https://github.com/solidtime-io/solidtime.git
synced 2026-10-08 13:53:17 +01:00
Compare commits
3 Commits
main
...
feature/fi
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f64b0331cd | ||
|
|
b85f49fe05 | ||
|
|
8c5a898585 |
@@ -0,0 +1,107 @@
|
|||||||
|
<?php
|
||||||
|
|
||||||
|
declare(strict_types=1);
|
||||||
|
|
||||||
|
namespace App\Extensions\Scramble;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
|
use App\Http\Resources\V1\TimeEntry\TimeEntryCollection;
|
||||||
|
use Dedoc\Scramble\Extensions\TypeToSchemaExtension;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Response;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Schema;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Types\ArrayType;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Types\BooleanType;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Types\IntegerType;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Types\ObjectType as OpenApiObjectType;
|
||||||
|
use Dedoc\Scramble\Support\Generator\Types\StringType;
|
||||||
|
use Dedoc\Scramble\Support\Type\Generic;
|
||||||
|
use Dedoc\Scramble\Support\Type\ObjectType;
|
||||||
|
use Dedoc\Scramble\Support\Type\Type;
|
||||||
|
use Illuminate\Database\Eloquent\Model;
|
||||||
|
use Illuminate\Http\Resources\Json\JsonResource;
|
||||||
|
|
||||||
|
class PaginatedResourceCollectionTypeToSchema extends TypeToSchemaExtension
|
||||||
|
{
|
||||||
|
public function shouldHandle(Type $type): bool
|
||||||
|
{
|
||||||
|
return $type instanceof ObjectType
|
||||||
|
&& $type->isInstanceOf(PaginatedResourceCollection::class);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function toSchema(Type $type): ?OpenApiObjectType
|
||||||
|
{
|
||||||
|
/** @var Type|null $collectingClassType */
|
||||||
|
$collectingClassType = $type->templateTypes[0] ?? null;
|
||||||
|
|
||||||
|
if (! $collectingClassType instanceof ObjectType) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (! $collectingClassType->isInstanceOf(JsonResource::class) && ! $collectingClassType->isInstanceOf(Model::class)) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
$collectingType = $this->openApiTransformer->transform($collectingClassType);
|
||||||
|
|
||||||
|
$newType = new OpenApiObjectType;
|
||||||
|
$newType->addProperty('data', (new ArrayType)->setItems($collectingType));
|
||||||
|
if ($type instanceof ObjectType && $type->isInstanceOf(TimeEntryCollection::class)) {
|
||||||
|
$newType->addProperty(
|
||||||
|
'meta',
|
||||||
|
(new OpenApiObjectType)
|
||||||
|
->addProperty('total', (new IntegerType)->setDescription('Total number of items being paginated.'))
|
||||||
|
->setRequired(['total'])
|
||||||
|
);
|
||||||
|
$newType->setRequired(['data', 'meta']);
|
||||||
|
} else {
|
||||||
|
$newType->addProperty(
|
||||||
|
'links',
|
||||||
|
(new OpenApiObjectType)
|
||||||
|
->addProperty('first', (new StringType)->nullable(true))
|
||||||
|
->addProperty('last', (new StringType)->nullable(true))
|
||||||
|
->addProperty('prev', (new StringType)->nullable(true))
|
||||||
|
->addProperty('next', (new StringType)->nullable(true))
|
||||||
|
->setRequired(['first', 'last', 'prev', 'next'])
|
||||||
|
);
|
||||||
|
$newType->addProperty(
|
||||||
|
'meta',
|
||||||
|
(new OpenApiObjectType)
|
||||||
|
->addProperty('current_page', new IntegerType)
|
||||||
|
->addProperty('from', (new IntegerType)->nullable(true))
|
||||||
|
->addProperty('last_page', new IntegerType)
|
||||||
|
->addProperty('links', (new ArrayType)->setItems(
|
||||||
|
(new OpenApiObjectType)
|
||||||
|
->addProperty('url', (new StringType)->nullable(true))
|
||||||
|
->addProperty('label', new StringType)
|
||||||
|
->addProperty('active', new BooleanType)
|
||||||
|
->setRequired(['url', 'label', 'active'])
|
||||||
|
)->setDescription('Generated paginator links.'))
|
||||||
|
->addProperty('path', (new StringType)->nullable(true)->setDescription('Base path for paginator generated URLs.'))
|
||||||
|
->addProperty('per_page', (new IntegerType)->setDescription('Number of items shown per page.'))
|
||||||
|
->addProperty('to', (new IntegerType)->nullable(true)->setDescription('Number of the last item in the slice.'))
|
||||||
|
->addProperty('total', (new IntegerType)->setDescription('Total number of items being paginated.'))
|
||||||
|
->setRequired(['current_page', 'from', 'last_page', 'links', 'path', 'per_page', 'to', 'total'])
|
||||||
|
);
|
||||||
|
$newType->setRequired(['data', 'links', 'meta']);
|
||||||
|
}
|
||||||
|
|
||||||
|
return $newType;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param Generic $type
|
||||||
|
*/
|
||||||
|
public function toResponse(Type $type): ?Response
|
||||||
|
{
|
||||||
|
/** @var ObjectType|null $collectingClassType */
|
||||||
|
$collectingClassType = $type->templateTypes[0] ?? null;
|
||||||
|
if (! $collectingClassType instanceof ObjectType) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
$type = $this->toSchema($type);
|
||||||
|
|
||||||
|
return Response::make(200)
|
||||||
|
->description('Paginated set of `'.$this->components->uniqueSchemaName($collectingClassType->name).'`')
|
||||||
|
->setContent('application/json', Schema::fromType($type));
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,21 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
namespace App\Http\Controllers\Api;
|
|
||||||
|
|
||||||
use App\Http\Controllers\Controller;
|
|
||||||
use Dedoc\Scramble\Attributes\ExcludeAllRoutesFromDocs;
|
|
||||||
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Fallback for unknown /api/* routes, to prevent a rendered HTML page
|
|
||||||
*/
|
|
||||||
#[ExcludeAllRoutesFromDocs]
|
|
||||||
class FallbackController extends Controller
|
|
||||||
{
|
|
||||||
public function __invoke(): never
|
|
||||||
{
|
|
||||||
throw new NotFoundHttpException('API resource not found');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -29,6 +29,8 @@ class ClientController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get clients
|
* Get clients
|
||||||
*
|
*
|
||||||
|
* @return ClientCollection<ClientResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getClients
|
* @operationId getClients
|
||||||
|
|||||||
@@ -9,6 +9,7 @@ use App\Exceptions\Api\UserIsAlreadyMemberOfOrganizationApiException;
|
|||||||
use App\Http\Requests\V1\Invitation\InvitationIndexRequest;
|
use App\Http\Requests\V1\Invitation\InvitationIndexRequest;
|
||||||
use App\Http\Requests\V1\Invitation\InvitationStoreRequest;
|
use App\Http\Requests\V1\Invitation\InvitationStoreRequest;
|
||||||
use App\Http\Resources\V1\Invitation\InvitationCollection;
|
use App\Http\Resources\V1\Invitation\InvitationCollection;
|
||||||
|
use App\Http\Resources\V1\Invitation\InvitationResource;
|
||||||
use App\Models\Organization;
|
use App\Models\Organization;
|
||||||
use App\Models\OrganizationInvitation;
|
use App\Models\OrganizationInvitation;
|
||||||
use App\Service\InvitationService;
|
use App\Service\InvitationService;
|
||||||
@@ -29,6 +30,8 @@ class InvitationController extends Controller
|
|||||||
/**
|
/**
|
||||||
* List all invitations of an organization
|
* List all invitations of an organization
|
||||||
*
|
*
|
||||||
|
* @return InvitationCollection<InvitationResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getInvitations
|
* @operationId getInvitations
|
||||||
@@ -85,8 +88,6 @@ class InvitationController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Remove a pending invitation
|
* Remove a pending invitation
|
||||||
*
|
*
|
||||||
* This revokes the invitation: the link in the invitation email stops working. Find the invitation ID with `GET /organizations/{organization}/invitations`.
|
|
||||||
*
|
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId removeInvitation
|
* @operationId removeInvitation
|
||||||
|
|||||||
@@ -48,6 +48,8 @@ class MemberController extends Controller
|
|||||||
/**
|
/**
|
||||||
* List all members of an organization
|
* List all members of an organization
|
||||||
*
|
*
|
||||||
|
* @return MemberCollection<MemberResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getMembers
|
* @operationId getMembers
|
||||||
@@ -143,9 +145,6 @@ class MemberController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Merge one member into another
|
* Merge one member into another
|
||||||
*
|
*
|
||||||
* Only placeholder members (for example people created by an import) can be merged. All time entries and other data of the placeholder
|
|
||||||
* are reassigned to the member given in `member_id`, and the placeholder is removed. Find both member IDs with `GET /organizations/{organization}/members`.
|
|
||||||
*
|
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
* @throws OnlyPlaceholdersCanBeMergedIntoAnotherMember
|
* @throws OnlyPlaceholdersCanBeMergedIntoAnotherMember
|
||||||
* @throws Throwable
|
* @throws Throwable
|
||||||
|
|||||||
@@ -35,6 +35,8 @@ class ProjectController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get projects visible to the current user
|
* Get projects visible to the current user
|
||||||
*
|
*
|
||||||
|
* @return ProjectCollection<ProjectResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getProjects
|
* @operationId getProjects
|
||||||
|
|||||||
@@ -36,6 +36,8 @@ class ProjectMemberController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get project members for project
|
* Get project members for project
|
||||||
*
|
*
|
||||||
|
* @return ProjectMemberCollection<ProjectMemberResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getProjectMembers
|
* @operationId getProjectMembers
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ use App\Http\Requests\V1\Report\ReportStoreRequest;
|
|||||||
use App\Http\Requests\V1\Report\ReportUpdateRequest;
|
use App\Http\Requests\V1\Report\ReportUpdateRequest;
|
||||||
use App\Http\Resources\V1\Report\DetailedReportResource;
|
use App\Http\Resources\V1\Report\DetailedReportResource;
|
||||||
use App\Http\Resources\V1\Report\ReportCollection;
|
use App\Http\Resources\V1\Report\ReportCollection;
|
||||||
|
use App\Http\Resources\V1\Report\ReportResource;
|
||||||
use App\Models\Organization;
|
use App\Models\Organization;
|
||||||
use App\Models\Report;
|
use App\Models\Report;
|
||||||
use App\Service\Dto\ReportPropertiesDto;
|
use App\Service\Dto\ReportPropertiesDto;
|
||||||
@@ -34,6 +35,8 @@ class ReportController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get reports
|
* Get reports
|
||||||
*
|
*
|
||||||
|
* @return ReportCollection<ReportResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getReports
|
* @operationId getReports
|
||||||
@@ -68,8 +71,6 @@ class ReportController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Create report
|
* Create report
|
||||||
*
|
*
|
||||||
* A report is a saved set of filters. Set `is_public` to `true` to share it: the response then contains the `shareable_link` that can be opened without logging in.
|
|
||||||
*
|
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId createReport
|
* @operationId createReport
|
||||||
|
|||||||
@@ -29,6 +29,8 @@ class TagController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get tags
|
* Get tags
|
||||||
*
|
*
|
||||||
|
* @return TagCollection<TagResource>
|
||||||
|
*
|
||||||
* @operationId getTags
|
* @operationId getTags
|
||||||
*
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
|
|||||||
@@ -51,6 +51,8 @@ class TaskController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get tasks
|
* Get tasks
|
||||||
*
|
*
|
||||||
|
* @return TaskCollection<TaskResource>
|
||||||
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
* @operationId getTasks
|
* @operationId getTasks
|
||||||
|
|||||||
@@ -109,13 +109,10 @@ class TimeEntryController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Get time entries in organization
|
* Get time entries in organization
|
||||||
*
|
*
|
||||||
* Without a member filter this returns the time entries of all members of the organization (for users who may view all time entries, such as owners and admins), not only your own.
|
* If you only need time entries for a specific user, you can filter by `member_id`.
|
||||||
* To get only your own time entries, pass your member ID as `member_id`. Your member ID is the `id` returned for this organization by `GET /v1/users/me/memberships`; it is not your user ID.
|
|
||||||
* Users with the permission `time-entries:view:own` can only use this endpoint with their own member ID in the member_id filter.
|
* Users with the permission `time-entries:view:own` can only use this endpoint with their own member ID in the member_id filter.
|
||||||
*
|
*
|
||||||
* The `start` and `end` filters both apply to the start time of an entry, in UTC. Convert the user's local day boundaries to UTC first.
|
* @return TimeEntryCollection<TimeEntryResource>
|
||||||
* Results are paginated with `limit` (default 100, max 500) and `offset`; check `meta.total` and fetch further pages when needed.
|
|
||||||
* To find the running timer, use `active=true` (or `GET /v1/users/me/time-entries/active`).
|
|
||||||
*
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
*
|
*
|
||||||
@@ -354,11 +351,6 @@ class TimeEntryController extends Controller
|
|||||||
* The parameters `group` and `sub_group` allow you to group the time entries by different criteria.
|
* The parameters `group` and `sub_group` allow you to group the time entries by different criteria.
|
||||||
* If the group parameters are all set to `null` or are all missing, the endpoint will aggregate all filtered time entries.
|
* If the group parameters are all set to `null` or are all missing, the endpoint will aggregate all filtered time entries.
|
||||||
*
|
*
|
||||||
* Durations are returned in `seconds` (divide by 3600 for hours) and amounts in `cost` as cents in the organization's currency (divide by 100 for money).
|
|
||||||
* Filter by member with `member_id`. Your member ID is the `id` returned for this organization by `GET /v1/users/me/memberships`; it is not your user ID.
|
|
||||||
* Array filters use the query format `client_ids[]=<id>`.
|
|
||||||
* Example: billable hours per client for a period: `group=client&billable=true&start=...&end=...`.
|
|
||||||
*
|
|
||||||
* @operationId getAggregatedTimeEntries
|
* @operationId getAggregatedTimeEntries
|
||||||
*
|
*
|
||||||
* @return array{
|
* @return array{
|
||||||
@@ -592,12 +584,6 @@ class TimeEntryController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Create time entry
|
* Create time entry
|
||||||
*
|
*
|
||||||
* `billable` is not taken from the project. To match the web app, set it to the project's `is_billable` value (or `false` without a project).
|
|
||||||
*
|
|
||||||
* A member can only have one running time entry (an entry with `end` set to `null`). Creating a running entry while another one runs fails with `time_entry_still_running`.
|
|
||||||
* To start a new timer, first stop the running entry by updating its `end` to the current time, then create the new entry.
|
|
||||||
* To log past work, send both `start` and `end` (UTC). Create one entry per block of work.
|
|
||||||
*
|
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
* @throws TimeEntryStillRunningApiException
|
* @throws TimeEntryStillRunningApiException
|
||||||
*
|
*
|
||||||
@@ -648,8 +634,6 @@ class TimeEntryController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Update time entry
|
* Update time entry
|
||||||
*
|
*
|
||||||
* To stop a running timer, set `end` to the stop time (UTC). Times the user gives in their own timezone must be converted to UTC first.
|
|
||||||
*
|
|
||||||
* @throws AuthorizationException|TimeEntryCanNotBeRestartedApiException
|
* @throws AuthorizationException|TimeEntryCanNotBeRestartedApiException
|
||||||
*
|
*
|
||||||
* @operationId updateTimeEntry
|
* @operationId updateTimeEntry
|
||||||
@@ -718,10 +702,6 @@ class TimeEntryController extends Controller
|
|||||||
/**
|
/**
|
||||||
* Update multiple time entries
|
* Update multiple time entries
|
||||||
*
|
*
|
||||||
* Applies the same `changes` to every entry in `ids`. To find the IDs, list entries with `GET /organizations/{organization}/time-entries`
|
|
||||||
* (filtered by `member_id`, the project and the other criteria), then send their IDs here.
|
|
||||||
* When `changes.project_id` moves entries to another project, also set `changes.task_id` to a task of the new project or to `null`, because tasks belong to a project.
|
|
||||||
*
|
|
||||||
* @operationId updateMultipleTimeEntries
|
* @operationId updateMultipleTimeEntries
|
||||||
*
|
*
|
||||||
* @throws AuthorizationException
|
* @throws AuthorizationException
|
||||||
|
|||||||
@@ -27,7 +27,6 @@ class MemberUpdateRequest extends BaseFormRequest
|
|||||||
'string',
|
'string',
|
||||||
Rule::enum(Role::class),
|
Rule::enum(Role::class),
|
||||||
],
|
],
|
||||||
// Billable rate in cents per hour (example: 8000 means 80.00 in the organization's currency)
|
|
||||||
'billable_rate' => array_merge(
|
'billable_rate' => array_merge(
|
||||||
[
|
[
|
||||||
'nullable',
|
'nullable',
|
||||||
|
|||||||
@@ -36,7 +36,6 @@ class OrganizationUpdateRequest extends BaseFormRequest
|
|||||||
'string',
|
'string',
|
||||||
new CurrencyRule,
|
new CurrencyRule,
|
||||||
],
|
],
|
||||||
// Billable rate in cents per hour (example: 8000 means 80.00 in the organization's currency)
|
|
||||||
'billable_rate' => array_merge(
|
'billable_rate' => array_merge(
|
||||||
[
|
[
|
||||||
'nullable',
|
'nullable',
|
||||||
|
|||||||
@@ -55,7 +55,6 @@ class ProjectStoreRequest extends BaseFormRequest
|
|||||||
'required',
|
'required',
|
||||||
'boolean',
|
'boolean',
|
||||||
],
|
],
|
||||||
// Billable rate in cents per hour (example: 8000 means 80.00 in the organization's currency)
|
|
||||||
'billable_rate' => array_merge(
|
'billable_rate' => array_merge(
|
||||||
[
|
[
|
||||||
'nullable',
|
'nullable',
|
||||||
|
|||||||
@@ -68,7 +68,6 @@ class ProjectUpdateRequest extends BaseFormRequest
|
|||||||
return $builder->whereBelongsTo($this->organization, 'organization');
|
return $builder->whereBelongsTo($this->organization, 'organization');
|
||||||
})->uuid(),
|
})->uuid(),
|
||||||
],
|
],
|
||||||
// Billable rate in cents per hour (example: 8000 means 80.00 in the organization's currency)
|
|
||||||
'billable_rate' => array_merge([
|
'billable_rate' => array_merge([
|
||||||
'nullable',
|
'nullable',
|
||||||
],
|
],
|
||||||
|
|||||||
@@ -31,7 +31,6 @@ class ProjectMemberStoreRequest extends BaseFormRequest
|
|||||||
return $builder->whereBelongsTo($this->organization, 'organization');
|
return $builder->whereBelongsTo($this->organization, 'organization');
|
||||||
})->uuid(),
|
})->uuid(),
|
||||||
],
|
],
|
||||||
// Billable rate in cents per hour (example: 8000 means 80.00 in the organization's currency)
|
|
||||||
'billable_rate' => array_merge(
|
'billable_rate' => array_merge(
|
||||||
[
|
[
|
||||||
'nullable',
|
'nullable',
|
||||||
|
|||||||
@@ -21,7 +21,6 @@ class ProjectMemberUpdateRequest extends BaseFormRequest
|
|||||||
public function rules(): array
|
public function rules(): array
|
||||||
{
|
{
|
||||||
return [
|
return [
|
||||||
// Billable rate in cents per hour (example: 8000 means 80.00 in the organization's currency)
|
|
||||||
'billable_rate' => array_merge(
|
'billable_rate' => array_merge(
|
||||||
[
|
[
|
||||||
'nullable',
|
'nullable',
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ class TimeEntryIndexRequest extends BaseFormRequest
|
|||||||
public function rules(): array
|
public function rules(): array
|
||||||
{
|
{
|
||||||
return [
|
return [
|
||||||
// Filter by member ID. Without it, users who may view all time entries (owners, admins) get the entries of every member; pass your own member ID (from GET /v1/users/me/memberships) to get only yours
|
// Filter by member ID
|
||||||
'member_id' => [
|
'member_id' => [
|
||||||
'string',
|
'string',
|
||||||
ExistsEloquent::make(Member::class, null, function (Builder $builder): Builder {
|
ExistsEloquent::make(Member::class, null, function (Builder $builder): Builder {
|
||||||
@@ -155,7 +155,7 @@ class TimeEntryIndexRequest extends BaseFormRequest
|
|||||||
'string',
|
'string',
|
||||||
Rule::enum(TimeEntryType::class),
|
Rule::enum(TimeEntryType::class),
|
||||||
],
|
],
|
||||||
// Limit the number of returned time entries (default: 100)
|
// Limit the number of returned time entries (default: 150)
|
||||||
'limit' => [
|
'limit' => [
|
||||||
'integer',
|
'integer',
|
||||||
'min:1',
|
'min:1',
|
||||||
|
|||||||
@@ -32,7 +32,7 @@ class TimeEntryStoreRequest extends BaseFormRequest
|
|||||||
public function rules(): array
|
public function rules(): array
|
||||||
{
|
{
|
||||||
return [
|
return [
|
||||||
// ID of the organization member that the time entry should belong to (a member ID from GET /v1/users/me/memberships or the members list, not a user ID)
|
// ID of the organization member that the time entry should belong to
|
||||||
'member_id' => [
|
'member_id' => [
|
||||||
'required',
|
'required',
|
||||||
'string',
|
'string',
|
||||||
@@ -86,7 +86,7 @@ class TimeEntryStoreRequest extends BaseFormRequest
|
|||||||
'date_format:Y-m-d\TH:i:s\Z',
|
'date_format:Y-m-d\TH:i:s\Z',
|
||||||
'after_or_equal:start',
|
'after_or_equal:start',
|
||||||
],
|
],
|
||||||
// Whether time entry is billable. Not derived from the project: set it to the project's is_billable value to match the web app
|
// Whether time entry is billable
|
||||||
'billable' => [
|
'billable' => [
|
||||||
'required',
|
'required',
|
||||||
'boolean',
|
'boolean',
|
||||||
|
|||||||
7
app/Http/Resources/PaginatedResourceCollection.php
Normal file
7
app/Http/Resources/PaginatedResourceCollection.php
Normal file
@@ -0,0 +1,7 @@
|
|||||||
|
<?php
|
||||||
|
|
||||||
|
declare(strict_types=1);
|
||||||
|
|
||||||
|
namespace App\Http\Resources;
|
||||||
|
|
||||||
|
interface PaginatedResourceCollection {}
|
||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Client;
|
namespace App\Http\Resources\V1\Client;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class ClientCollection extends ResourceCollection
|
class ClientCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Invitation;
|
namespace App\Http\Resources\V1\Invitation;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class InvitationCollection extends ResourceCollection
|
class InvitationCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Member;
|
namespace App\Http\Resources\V1\Member;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class MemberCollection extends ResourceCollection
|
class MemberCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Member;
|
namespace App\Http\Resources\V1\Member;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class PersonalMembershipCollection extends ResourceCollection
|
class PersonalMembershipCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,11 +4,12 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Project;
|
namespace App\Http\Resources\V1\Project;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use App\Models\Project;
|
use App\Models\Project;
|
||||||
use Illuminate\Http\Request;
|
use Illuminate\Http\Request;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class ProjectCollection extends ResourceCollection
|
class ProjectCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
private bool $showBillableRates;
|
private bool $showBillableRates;
|
||||||
|
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\ProjectMember;
|
namespace App\Http\Resources\V1\ProjectMember;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class ProjectMemberCollection extends ResourceCollection
|
class ProjectMemberCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Report;
|
namespace App\Http\Resources\V1\Report;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class ReportCollection extends ResourceCollection
|
class ReportCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Tag;
|
namespace App\Http\Resources\V1\Tag;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class TagCollection extends ResourceCollection
|
class TagCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\Task;
|
namespace App\Http\Resources\V1\Task;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class TaskCollection extends ResourceCollection
|
class TaskCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Http\Resources\V1\TimeEntry;
|
namespace App\Http\Resources\V1\TimeEntry;
|
||||||
|
|
||||||
|
use App\Http\Resources\PaginatedResourceCollection;
|
||||||
use Illuminate\Http\Resources\Json\ResourceCollection;
|
use Illuminate\Http\Resources\Json\ResourceCollection;
|
||||||
|
|
||||||
class TimeEntryCollection extends ResourceCollection
|
class TimeEntryCollection extends ResourceCollection implements PaginatedResourceCollection
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
* The resource that this resource collects.
|
* The resource that this resource collects.
|
||||||
|
|||||||
@@ -4,19 +4,15 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Models;
|
namespace App\Models;
|
||||||
|
|
||||||
use App\Models\Concerns\AuditableWithoutOwner;
|
|
||||||
use Database\Factories\AuditFactory;
|
use Database\Factories\AuditFactory;
|
||||||
use Illuminate\Database\Eloquent\Builder;
|
|
||||||
use Illuminate\Database\Eloquent\Factories\HasFactory;
|
use Illuminate\Database\Eloquent\Factories\HasFactory;
|
||||||
use Illuminate\Database\Eloquent\Relations\BelongsTo;
|
|
||||||
use Illuminate\Database\Eloquent\Relations\Relation;
|
|
||||||
use Illuminate\Support\Carbon;
|
use Illuminate\Support\Carbon;
|
||||||
use OwenIt\Auditing\Models\Audit as PackageAuditModel;
|
use OwenIt\Auditing\Models\Audit as PackageAuditModel;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @property int $id
|
* @property int $id
|
||||||
* @property string|null $actor_type
|
* @property string|null $user_type
|
||||||
* @property string|null $actor_id
|
* @property string|null $user_id
|
||||||
* @property string $event
|
* @property string $event
|
||||||
* @property string $auditable_type
|
* @property string $auditable_type
|
||||||
* @property string $auditable_id
|
* @property string $auditable_id
|
||||||
@@ -26,71 +22,13 @@ use OwenIt\Auditing\Models\Audit as PackageAuditModel;
|
|||||||
* @property string|null $ip_address
|
* @property string|null $ip_address
|
||||||
* @property string|null $user_agent
|
* @property string|null $user_agent
|
||||||
* @property string|null $tags
|
* @property string|null $tags
|
||||||
* @property string|null $owner_user_id
|
|
||||||
* @property string|null $owner_organization_id
|
|
||||||
* @property Carbon|null $created_at
|
* @property Carbon|null $created_at
|
||||||
* @property Carbon|null $updated_at
|
* @property Carbon|null $updated_at
|
||||||
* @property-read User|null $ownerUser
|
|
||||||
* @property-read Organization|null $ownerOrganization
|
|
||||||
*
|
*
|
||||||
* @method static AuditFactory factory()
|
* @method static AuditFactory factory()
|
||||||
* @method static Builder<Audit> whereMissingOwner()
|
|
||||||
*/
|
*/
|
||||||
class Audit extends PackageAuditModel
|
class Audit extends PackageAuditModel
|
||||||
{
|
{
|
||||||
/** @use HasFactory<AuditFactory> */
|
/** @use HasFactory<AuditFactory> */
|
||||||
use HasFactory;
|
use HasFactory;
|
||||||
|
|
||||||
/**
|
|
||||||
* @return BelongsTo<User, $this>
|
|
||||||
*/
|
|
||||||
public function ownerUser(): BelongsTo
|
|
||||||
{
|
|
||||||
return $this->belongsTo(User::class, 'owner_user_id');
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* @return BelongsTo<Organization, $this>
|
|
||||||
*/
|
|
||||||
public function ownerOrganization(): BelongsTo
|
|
||||||
{
|
|
||||||
return $this->belongsTo(Organization::class, 'owner_organization_id');
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Whether audits of the given auditable type intentionally have no owner (see AuditableWithoutOwner).
|
|
||||||
*/
|
|
||||||
public static function isAuditableTypeWithoutOwner(string $auditableType): bool
|
|
||||||
{
|
|
||||||
$modelClass = Relation::getMorphedModel($auditableType) ?? $auditableType;
|
|
||||||
|
|
||||||
return is_subclass_of($modelClass, AuditableWithoutOwner::class);
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Auditable types (morph aliases) whose audits intentionally have no owner (see AuditableWithoutOwner).
|
|
||||||
*
|
|
||||||
* @return array<int, string>
|
|
||||||
*/
|
|
||||||
public static function getAuditableTypesWithoutOwner(): array
|
|
||||||
{
|
|
||||||
return collect(Relation::morphMap())
|
|
||||||
->filter(fn (string $modelClass): bool => is_subclass_of($modelClass, AuditableWithoutOwner::class))
|
|
||||||
->keys()
|
|
||||||
->values()
|
|
||||||
->all();
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Audits that have neither an owner organization nor an owner user, although their auditable type should have one.
|
|
||||||
* These are audits whose owner no longer exists or could not be determined (yet).
|
|
||||||
*
|
|
||||||
* @param Builder<Audit> $builder
|
|
||||||
*/
|
|
||||||
public function scopeWhereMissingOwner(Builder $builder): void
|
|
||||||
{
|
|
||||||
$builder->whereNull('owner_organization_id')
|
|
||||||
->whereNull('owner_user_id')
|
|
||||||
->whereNotIn('auditable_type', self::getAuditableTypesWithoutOwner());
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,22 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
namespace App\Models\Concerns;
|
|
||||||
|
|
||||||
use Illuminate\Database\Eloquent\Model;
|
|
||||||
use Illuminate\Database\Eloquent\Relations\BelongsTo;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Marks an auditable model whose audits are owned by the owner of its parent model,
|
|
||||||
* because the model itself has no organization_id (for example a project member belongs to an organization via its project).
|
|
||||||
* The parent model has to have an organization_id column.
|
|
||||||
* This is used to set the owner of new audits (CustomAuditable) and to backfill the owner of existing audits.
|
|
||||||
*/
|
|
||||||
interface AuditableThroughParent
|
|
||||||
{
|
|
||||||
/**
|
|
||||||
* @return BelongsTo<covariant Model, covariant Model>
|
|
||||||
*/
|
|
||||||
public function getAuditParentRelation(): BelongsTo;
|
|
||||||
}
|
|
||||||
@@ -1,14 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
namespace App\Models\Concerns;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Marks an auditable model whose audits intentionally have no owner (neither an organization nor a user),
|
|
||||||
* either because the model belongs to neither of them, or because the model and its audits have to be kept
|
|
||||||
* when its organization or user is deleted (for example billing records).
|
|
||||||
* Audits of these models are not deleted together with an organization or user,
|
|
||||||
* and are not considered as missing an owner (for example by the audit backfill command).
|
|
||||||
*/
|
|
||||||
interface AuditableWithoutOwner {}
|
|
||||||
@@ -4,8 +4,6 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Models\Concerns;
|
namespace App\Models\Concerns;
|
||||||
|
|
||||||
use Illuminate\Database\Eloquent\Model;
|
|
||||||
use Illuminate\Support\Facades\Config;
|
|
||||||
use OwenIt\Auditing\Auditable;
|
use OwenIt\Auditing\Auditable;
|
||||||
|
|
||||||
trait CustomAuditable
|
trait CustomAuditable
|
||||||
@@ -21,92 +19,4 @@ trait CustomAuditable
|
|||||||
{
|
{
|
||||||
$this->auditEvents = [];
|
$this->auditEvents = [];
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* The organization that owns the audited model.
|
|
||||||
* The audits of the model are deleted (via foreign key cascade) when the organization is deleted.
|
|
||||||
*/
|
|
||||||
public function getAuditOwnerOrganizationId(): ?string
|
|
||||||
{
|
|
||||||
if ($this instanceof AuditableThroughParent) {
|
|
||||||
$relation = $this->getAuditParentRelation();
|
|
||||||
$parentId = $this->getAttributes()[$relation->getForeignKeyName()] ?? null;
|
|
||||||
if ($parentId === null) {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Note: The loaded parent is only used if it still matches the foreign key and was loaded with the organization
|
|
||||||
$relationName = $relation->getRelationName();
|
|
||||||
if ($this->relationLoaded($relationName)) {
|
|
||||||
$parent = $this->getRelation($relationName);
|
|
||||||
if ($parent instanceof Model
|
|
||||||
&& $parent->getAttribute($relation->getOwnerKeyName()) === $parentId
|
|
||||||
&& array_key_exists('organization_id', $parent->getAttributes())) {
|
|
||||||
/** @var string|null $organizationId */
|
|
||||||
$organizationId = $parent->getAttributes()['organization_id'];
|
|
||||||
|
|
||||||
return $organizationId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/** @var string|null $organizationId */
|
|
||||||
$organizationId = $relation->getRelated()->newQuery()
|
|
||||||
->toBase()
|
|
||||||
->where($relation->getOwnerKeyName(), $parentId)
|
|
||||||
->value('organization_id');
|
|
||||||
|
|
||||||
return $organizationId;
|
|
||||||
}
|
|
||||||
|
|
||||||
return $this->getAttributes()['organization_id'] ?? null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* The user that owns the audited model.
|
|
||||||
* The audits of the model are deleted (via foreign key cascade) when the user is deleted.
|
|
||||||
*/
|
|
||||||
public function getAuditOwnerUserId(): ?string
|
|
||||||
{
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Models that are the owner of their own audits can not record the deletion audit,
|
|
||||||
* since the audit would reference the already deleted model and therefore violate the foreign key.
|
|
||||||
*/
|
|
||||||
protected function isAuditOwnerOfItself(): bool
|
|
||||||
{
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* @return array<int|string, string>
|
|
||||||
*/
|
|
||||||
public function getAuditEvents(): array
|
|
||||||
{
|
|
||||||
$events = $this->auditEvents ?? Config::get('audit.events', [
|
|
||||||
'created',
|
|
||||||
'updated',
|
|
||||||
'deleted',
|
|
||||||
'restored',
|
|
||||||
]);
|
|
||||||
|
|
||||||
if ($this->isAuditOwnerOfItself()) {
|
|
||||||
$events = array_filter($events, fn (string $value, int|string $key): bool => (is_int($key) ? $value : $key) !== 'deleted', ARRAY_FILTER_USE_BOTH);
|
|
||||||
}
|
|
||||||
|
|
||||||
return $events;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* @param array<string, mixed> $data
|
|
||||||
* @return array<string, mixed>
|
|
||||||
*/
|
|
||||||
public function transformAudit(array $data): array
|
|
||||||
{
|
|
||||||
$data['owner_organization_id'] = $this->getAuditOwnerOrganizationId();
|
|
||||||
$data['owner_user_id'] = $this->getAuditOwnerUserId();
|
|
||||||
|
|
||||||
return $data;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -96,16 +96,6 @@ class Organization extends Model implements AuditableContract
|
|||||||
protected $attributes = [
|
protected $attributes = [
|
||||||
];
|
];
|
||||||
|
|
||||||
public function getAuditOwnerOrganizationId(): ?string
|
|
||||||
{
|
|
||||||
return $this->getKey();
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function isAuditOwnerOfItself(): bool
|
|
||||||
{
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Get all the users that belong to the team.
|
* Get all the users that belong to the team.
|
||||||
*
|
*
|
||||||
|
|||||||
@@ -4,7 +4,6 @@ declare(strict_types=1);
|
|||||||
|
|
||||||
namespace App\Models;
|
namespace App\Models;
|
||||||
|
|
||||||
use App\Models\Concerns\AuditableThroughParent;
|
|
||||||
use App\Models\Concerns\CustomAuditable;
|
use App\Models\Concerns\CustomAuditable;
|
||||||
use App\Models\Concerns\HasUuids;
|
use App\Models\Concerns\HasUuids;
|
||||||
use Database\Factories\ProjectMemberFactory;
|
use Database\Factories\ProjectMemberFactory;
|
||||||
@@ -30,7 +29,7 @@ use OwenIt\Auditing\Contracts\Auditable as AuditableContract;
|
|||||||
* @method static Builder<ProjectMember> whereBelongsToOrganization(Organization $organization)
|
* @method static Builder<ProjectMember> whereBelongsToOrganization(Organization $organization)
|
||||||
* @method static ProjectMemberFactory factory()
|
* @method static ProjectMemberFactory factory()
|
||||||
*/
|
*/
|
||||||
class ProjectMember extends Model implements AuditableContract, AuditableThroughParent
|
class ProjectMember extends Model implements AuditableContract
|
||||||
{
|
{
|
||||||
use CustomAuditable;
|
use CustomAuditable;
|
||||||
|
|
||||||
@@ -83,12 +82,4 @@ class ProjectMember extends Model implements AuditableContract, AuditableThrough
|
|||||||
$query->whereBelongsTo($organization, 'organization');
|
$query->whereBelongsTo($organization, 'organization');
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* @return BelongsTo<Project, $this>
|
|
||||||
*/
|
|
||||||
public function getAuditParentRelation(): BelongsTo
|
|
||||||
{
|
|
||||||
return $this->project();
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -124,16 +124,6 @@ class User extends Authenticatable implements AuditableContract, FilamentUser, M
|
|||||||
'send_time_entry_still_running_email' => true,
|
'send_time_entry_still_running_email' => true,
|
||||||
];
|
];
|
||||||
|
|
||||||
public function getAuditOwnerUserId(): ?string
|
|
||||||
{
|
|
||||||
return $this->getKey();
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function isAuditOwnerOfItself(): bool
|
|
||||||
{
|
|
||||||
return true;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Get the URL to the user's profile photo.
|
* Get the URL to the user's profile photo.
|
||||||
*
|
*
|
||||||
|
|||||||
@@ -32,7 +32,7 @@ return [
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
'user' => [
|
'user' => [
|
||||||
'morph_prefix' => 'actor',
|
'morph_prefix' => 'user',
|
||||||
'guards' => [
|
'guards' => [
|
||||||
'web',
|
'web',
|
||||||
'api',
|
'api',
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ return [
|
|||||||
|
|
||||||
'sqlite' => [
|
'sqlite' => [
|
||||||
'driver' => 'sqlite',
|
'driver' => 'sqlite',
|
||||||
'url' => env('DB_URL', env('DATABASE_URL')),
|
'url' => env('DB_URL'),
|
||||||
'database' => env('DB_DATABASE', database_path('database.sqlite')),
|
'database' => env('DB_DATABASE', database_path('database.sqlite')),
|
||||||
'prefix' => '',
|
'prefix' => '',
|
||||||
'foreign_key_constraints' => env('DB_FOREIGN_KEYS', true),
|
'foreign_key_constraints' => env('DB_FOREIGN_KEYS', true),
|
||||||
@@ -47,7 +47,7 @@ return [
|
|||||||
|
|
||||||
'pgsql' => [
|
'pgsql' => [
|
||||||
'driver' => 'pgsql',
|
'driver' => 'pgsql',
|
||||||
'url' => env('DB_URL', env('DATABASE_URL')),
|
'url' => env('DB_URL'),
|
||||||
'host' => env('DB_HOST', '127.0.0.1'),
|
'host' => env('DB_HOST', '127.0.0.1'),
|
||||||
'port' => env('DB_PORT', '5432'),
|
'port' => env('DB_PORT', '5432'),
|
||||||
'database' => env('DB_DATABASE', 'forge'),
|
'database' => env('DB_DATABASE', 'forge'),
|
||||||
@@ -57,12 +57,12 @@ return [
|
|||||||
'prefix' => '',
|
'prefix' => '',
|
||||||
'prefix_indexes' => true,
|
'prefix_indexes' => true,
|
||||||
'search_path' => 'public',
|
'search_path' => 'public',
|
||||||
'sslmode' => env('DB_SSL_MODE', 'prefer'),
|
'sslmode' => env('DB_SSLMODE', 'prefer'),
|
||||||
],
|
],
|
||||||
|
|
||||||
'pgsql_test' => [
|
'pgsql_test' => [
|
||||||
'driver' => 'pgsql',
|
'driver' => 'pgsql',
|
||||||
'url' => env('DB_URL', env('DATABASE_URL')),
|
'url' => env('DB_URL'),
|
||||||
'host' => env('DB_TEST_HOST', '127.0.0.1'),
|
'host' => env('DB_TEST_HOST', '127.0.0.1'),
|
||||||
'port' => env('DB_TEST_PORT', '5432'),
|
'port' => env('DB_TEST_PORT', '5432'),
|
||||||
'database' => env('DB_TEST_DATABASE', 'forge'),
|
'database' => env('DB_TEST_DATABASE', 'forge'),
|
||||||
@@ -72,12 +72,12 @@ return [
|
|||||||
'prefix' => '',
|
'prefix' => '',
|
||||||
'prefix_indexes' => true,
|
'prefix_indexes' => true,
|
||||||
'search_path' => 'public',
|
'search_path' => 'public',
|
||||||
'sslmode' => env('DB_SSL_MODE', 'prefer'),
|
'sslmode' => env('DB_SSLMODE', 'prefer'),
|
||||||
],
|
],
|
||||||
|
|
||||||
'sqlsrv' => [
|
'sqlsrv' => [
|
||||||
'driver' => 'sqlsrv',
|
'driver' => 'sqlsrv',
|
||||||
'url' => env('DB_URL', env('DATABASE_URL')),
|
'url' => env('DB_URL'),
|
||||||
'host' => env('DB_HOST', 'localhost'),
|
'host' => env('DB_HOST', 'localhost'),
|
||||||
'port' => env('DB_PORT', '1433'),
|
'port' => env('DB_PORT', '1433'),
|
||||||
'database' => env('DB_DATABASE', 'laravel'),
|
'database' => env('DB_DATABASE', 'laravel'),
|
||||||
|
|||||||
@@ -3,6 +3,7 @@
|
|||||||
declare(strict_types=1);
|
declare(strict_types=1);
|
||||||
|
|
||||||
use App\Extensions\Scramble\ApiExceptionTypeToSchema;
|
use App\Extensions\Scramble\ApiExceptionTypeToSchema;
|
||||||
|
use App\Extensions\Scramble\PaginatedResourceCollectionTypeToSchema;
|
||||||
use Dedoc\Scramble\Http\Middleware\RestrictedDocsAccess;
|
use Dedoc\Scramble\Http\Middleware\RestrictedDocsAccess;
|
||||||
|
|
||||||
return [
|
return [
|
||||||
@@ -27,30 +28,7 @@ return [
|
|||||||
/*
|
/*
|
||||||
* Description rendered on the home page of the API documentation (`/docs/api`).
|
* Description rendered on the home page of the API documentation (`/docs/api`).
|
||||||
*/
|
*/
|
||||||
'description' => <<<'MD'
|
'description' => '',
|
||||||
## Getting started
|
|
||||||
|
|
||||||
All organization endpoints live under `/v1/organizations/{organization}`, where `{organization}` is the organization's ID. Authenticate with `Authorization: Bearer <token>` and send `Accept: application/json`.
|
|
||||||
|
|
||||||
**1. Find yourself.** Call `GET /v1/users/me/memberships`. Each membership contains the **organization ID** (use it as `{organization}` in paths) and your **member ID** in that organization (the membership `id`). Most endpoints filter by member ID, not by user ID.
|
|
||||||
|
|
||||||
**2. Scope to your own data.** For owners and admins, `GET /time-entries` and `GET /time-entries/aggregate` return the whole organization's time entries unless you pass `member_id`. When acting for "me", always pass your member ID, both when reading and before changing entries.
|
|
||||||
|
|
||||||
**3. Resolve names to IDs.** Look up projects, clients, tags, tasks and members by name with their list endpoints (`GET /projects`, `GET /clients`, `GET /tags`, `GET /tasks`, `GET /members`). Never guess IDs.
|
|
||||||
|
|
||||||
**4. Use UTC.** All timestamps are sent and returned in UTC as `Y-m-d\TH:i:s\Z` (example: `2026-10-02T07:30:00Z`). Convert the user's local times and day boundaries to UTC before sending them.
|
|
||||||
|
|
||||||
**5. Money is in cents.** Billable rates and costs are integers in cents of the organization's currency (`8000` means 80.00).
|
|
||||||
|
|
||||||
## Common tasks
|
|
||||||
|
|
||||||
- **Start a timer:** stop the running entry first (find it with `GET /v1/users/me/time-entries/active`, then `PUT` its `end`), then `POST /time-entries` with `start` and `end: null`. Only one entry can run per member.
|
|
||||||
- **Log past work:** `POST /time-entries` once per block with `member_id`, `start`, `end`, `project_id` and `billable` set to the project's `is_billable` (it is not derived automatically).
|
|
||||||
- **Fix or stop an entry:** `PUT /time-entries/{timeEntry}` with the new `start` or `end` in UTC.
|
|
||||||
- **Move entries to another project:** list them with `member_id` and filters, then `PATCH /time-entries` with their `ids` and `changes.project_id`, plus `changes.task_id` set to a task of the new project or `null`.
|
|
||||||
- **Totals and reports:** `GET /time-entries/aggregate` with `group` (for example `client` or `project`) and `start`/`end`; durations are in `seconds`, amounts in `cost` (cents).
|
|
||||||
- **Share a report:** `POST /reports` with `is_public: true` and use the returned `shareable_link`.
|
|
||||||
MD,
|
|
||||||
],
|
],
|
||||||
|
|
||||||
/*
|
/*
|
||||||
@@ -100,5 +78,6 @@ MD,
|
|||||||
|
|
||||||
'extensions' => [
|
'extensions' => [
|
||||||
ApiExceptionTypeToSchema::class,
|
ApiExceptionTypeToSchema::class,
|
||||||
|
PaginatedResourceCollectionTypeToSchema::class,
|
||||||
],
|
],
|
||||||
];
|
];
|
||||||
|
|||||||
@@ -91,7 +91,7 @@ class UserFactory extends Factory
|
|||||||
|
|
||||||
public function withProfilePicture(): static
|
public function withProfilePicture(): static
|
||||||
{
|
{
|
||||||
$profilePhoto = $this->generateProfilePhoto();
|
$profilePhoto = $this->faker->image(null, 500, 500);
|
||||||
/** @see FileHelpers::hashName */
|
/** @see FileHelpers::hashName */
|
||||||
$path = 'profile-photos/'.Str::random(40).'.png';
|
$path = 'profile-photos/'.Str::random(40).'.png';
|
||||||
Storage::disk(config('filesystems.public'))->put($path, $profilePhoto);
|
Storage::disk(config('filesystems.public'))->put($path, $profilePhoto);
|
||||||
@@ -103,21 +103,6 @@ class UserFactory extends Factory
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Generates a PNG image with a random background color.
|
|
||||||
* Note: The image is generated locally, since downloading a placeholder image (Faker image()) depends on an external service.
|
|
||||||
*/
|
|
||||||
private function generateProfilePhoto(): string
|
|
||||||
{
|
|
||||||
$image = imagecreatetruecolor(500, 500);
|
|
||||||
$color = imagecolorallocate($image, $this->faker->numberBetween(0, 255), $this->faker->numberBetween(0, 255), $this->faker->numberBetween(0, 255));
|
|
||||||
imagefill($image, 0, 0, $color);
|
|
||||||
ob_start();
|
|
||||||
imagepng($image);
|
|
||||||
|
|
||||||
return (string) ob_get_clean();
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Indicate that the user should have a personal team.
|
* Indicate that the user should have a personal team.
|
||||||
*/
|
*/
|
||||||
|
|||||||
@@ -18,8 +18,7 @@ class CreateAuditsTable extends Migration
|
|||||||
|
|
||||||
Schema::connection($connection)->create($table, function (Blueprint $table): void {
|
Schema::connection($connection)->create($table, function (Blueprint $table): void {
|
||||||
|
|
||||||
// Note: The morph prefix is hardcoded, since the columns are renamed in a later migration
|
$morphPrefix = config('audit.user.morph_prefix', 'user');
|
||||||
$morphPrefix = 'user';
|
|
||||||
|
|
||||||
$table->bigIncrements('id');
|
$table->bigIncrements('id');
|
||||||
$table->string($morphPrefix.'_type')->nullable();
|
$table->string($morphPrefix.'_type')->nullable();
|
||||||
|
|||||||
@@ -1,42 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
use Illuminate\Database\Migrations\Migration;
|
|
||||||
use Illuminate\Database\Schema\Blueprint;
|
|
||||||
use Illuminate\Support\Facades\Schema;
|
|
||||||
|
|
||||||
return new class extends Migration
|
|
||||||
{
|
|
||||||
/**
|
|
||||||
* Run the migrations.
|
|
||||||
*
|
|
||||||
* Note: Renaming columns and adding nullable columns without default are metadata-only operations in PostgreSQL,
|
|
||||||
* so this migration is fast even for a large audits table.
|
|
||||||
* The indexes and foreign keys for the new columns are added in a separate non-transactional migration.
|
|
||||||
*/
|
|
||||||
public function up(): void
|
|
||||||
{
|
|
||||||
Schema::table('audits', function (Blueprint $table): void {
|
|
||||||
$table->renameColumn('user_type', 'actor_type');
|
|
||||||
$table->renameColumn('user_id', 'actor_id');
|
|
||||||
$table->renameIndex('audits_user_id_user_type_index', 'audits_actor_id_actor_type_index');
|
|
||||||
$table->uuid('owner_user_id')->nullable();
|
|
||||||
$table->uuid('owner_organization_id')->nullable();
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Reverse the migrations.
|
|
||||||
*/
|
|
||||||
public function down(): void
|
|
||||||
{
|
|
||||||
Schema::table('audits', function (Blueprint $table): void {
|
|
||||||
$table->dropColumn('owner_user_id');
|
|
||||||
$table->dropColumn('owner_organization_id');
|
|
||||||
$table->renameIndex('audits_actor_id_actor_type_index', 'audits_user_id_user_type_index');
|
|
||||||
$table->renameColumn('actor_type', 'user_type');
|
|
||||||
$table->renameColumn('actor_id', 'user_id');
|
|
||||||
});
|
|
||||||
}
|
|
||||||
};
|
|
||||||
@@ -1,94 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
use Illuminate\Database\Migrations\Migration;
|
|
||||||
use Illuminate\Support\Facades\DB;
|
|
||||||
|
|
||||||
return new class extends Migration
|
|
||||||
{
|
|
||||||
/**
|
|
||||||
* PostgreSQL cannot build an index concurrently inside a transaction.
|
|
||||||
* Keeping this migration non-transactional prevents long write locks on the (large) audits table in production.
|
|
||||||
* Every step is idempotent, so the migration can be re-run if it fails halfway.
|
|
||||||
*
|
|
||||||
* @var bool
|
|
||||||
*/
|
|
||||||
public $withinTransaction = false;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Run the migrations.
|
|
||||||
*/
|
|
||||||
public function up(): void
|
|
||||||
{
|
|
||||||
$this->createIndex('audits_owner_user_id_index', 'owner_user_id');
|
|
||||||
$this->createIndex('audits_owner_organization_id_index', 'owner_organization_id');
|
|
||||||
|
|
||||||
$this->createForeignKey('audits_owner_user_id_foreign', 'owner_user_id', 'users');
|
|
||||||
$this->createForeignKey('audits_owner_organization_id_foreign', 'owner_organization_id', 'organizations');
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Reverse the migrations.
|
|
||||||
*/
|
|
||||||
public function down(): void
|
|
||||||
{
|
|
||||||
DB::statement('ALTER TABLE audits DROP CONSTRAINT IF EXISTS audits_owner_user_id_foreign');
|
|
||||||
DB::statement('ALTER TABLE audits DROP CONSTRAINT IF EXISTS audits_owner_organization_id_foreign');
|
|
||||||
DB::statement('DROP INDEX'.$this->concurrently().' IF EXISTS audits_owner_user_id_index');
|
|
||||||
DB::statement('DROP INDEX'.$this->concurrently().' IF EXISTS audits_owner_organization_id_index');
|
|
||||||
}
|
|
||||||
|
|
||||||
private function createIndex(string $index, string $column): void
|
|
||||||
{
|
|
||||||
$state = DB::selectOne(
|
|
||||||
<<<'SQL'
|
|
||||||
SELECT pg_index.indisvalid::int AS valid
|
|
||||||
FROM pg_index
|
|
||||||
JOIN pg_class ON pg_class.oid = pg_index.indexrelid
|
|
||||||
JOIN pg_namespace ON pg_namespace.oid = pg_class.relnamespace
|
|
||||||
WHERE pg_namespace.nspname = current_schema()
|
|
||||||
AND pg_class.relname = ?
|
|
||||||
SQL,
|
|
||||||
[$index],
|
|
||||||
);
|
|
||||||
|
|
||||||
if ($state !== null && (bool) $state->valid) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
// A failed concurrent index build leaves an invalid index behind, that needs to be dropped before rebuilding
|
|
||||||
if ($state !== null) {
|
|
||||||
DB::statement('DROP INDEX'.$this->concurrently().' '.$index);
|
|
||||||
}
|
|
||||||
|
|
||||||
DB::statement('CREATE INDEX'.$this->concurrently().' '.$index.' ON audits ('.$column.')');
|
|
||||||
}
|
|
||||||
|
|
||||||
private function createForeignKey(string $constraint, string $column, string $referencedTable): void
|
|
||||||
{
|
|
||||||
$exists = DB::selectOne(
|
|
||||||
<<<'SQL'
|
|
||||||
SELECT 1
|
|
||||||
FROM pg_constraint
|
|
||||||
JOIN pg_namespace ON pg_namespace.oid = pg_constraint.connamespace
|
|
||||||
WHERE pg_namespace.nspname = current_schema()
|
|
||||||
AND pg_constraint.conname = ?
|
|
||||||
SQL,
|
|
||||||
[$constraint],
|
|
||||||
) !== null;
|
|
||||||
|
|
||||||
// Note: Adding the constraint as NOT VALID only needs a short lock, the validation of the existing rows
|
|
||||||
// afterward does not block reads or writes on the audits table.
|
|
||||||
if (! $exists) {
|
|
||||||
DB::statement('ALTER TABLE audits ADD CONSTRAINT '.$constraint.' FOREIGN KEY ('.$column.') REFERENCES '.$referencedTable.' (id) ON DELETE CASCADE NOT VALID');
|
|
||||||
}
|
|
||||||
|
|
||||||
DB::statement('ALTER TABLE audits VALIDATE CONSTRAINT '.$constraint);
|
|
||||||
}
|
|
||||||
|
|
||||||
private function concurrently(): string
|
|
||||||
{
|
|
||||||
return DB::transactionLevel() === 0 ? ' CONCURRENTLY' : '';
|
|
||||||
}
|
|
||||||
};
|
|
||||||
@@ -1,18 +1,18 @@
|
|||||||
{
|
{
|
||||||
"Billing": {
|
"Billing": {
|
||||||
"repository": "solidtime-io/extension-billing",
|
"repository": "solidtime-io/extension-billing",
|
||||||
"ref": "v0.0.9"
|
"ref": "v0.0.8"
|
||||||
},
|
},
|
||||||
"Services": {
|
"Services": {
|
||||||
"repository": "solidtime-io/extension-services",
|
"repository": "solidtime-io/extension-services",
|
||||||
"ref": "v0.0.4"
|
"ref": "v0.0.3"
|
||||||
},
|
},
|
||||||
"Invoicing": {
|
"Invoicing": {
|
||||||
"repository": "solidtime-io/extension-invoicing",
|
"repository": "solidtime-io/extension-invoicing",
|
||||||
"ref": "v0.0.8"
|
"ref": "v0.0.7"
|
||||||
},
|
},
|
||||||
"Auditing": {
|
"Auditing": {
|
||||||
"repository": "solidtime-io/extension-auditing",
|
"repository": "solidtime-io/extension-auditing",
|
||||||
"ref": "v0.0.4"
|
"ref": "v0.0.2"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -168,10 +168,6 @@ defineExpose({ submit, focusAfterStart });
|
|||||||
data-testid="time_entry_description"
|
data-testid="time_entry_description"
|
||||||
class="w-full rounded-l-lg py-4 sm:py-2.5 px-3.5 border-b border-b-card-background-separator @2xl:px-4 text-base text-text-primary bg-transparent border-none placeholder-text-secondary focus:ring-0 transition"
|
class="w-full rounded-l-lg py-4 sm:py-2.5 px-3.5 border-b border-b-card-background-separator @2xl:px-4 text-base text-text-primary bg-transparent border-none placeholder-text-secondary focus:ring-0 transition"
|
||||||
type="text"
|
type="text"
|
||||||
autocomplete="off"
|
|
||||||
data-1p-ignore
|
|
||||||
data-lpignore="true"
|
|
||||||
data-form-type="other"
|
|
||||||
@keydown.enter="submit"
|
@keydown.enter="submit"
|
||||||
@keydown.esc="showDropdown = false"
|
@keydown.esc="showDropdown = false"
|
||||||
@blur="updateTimeEntryDescription" />
|
@blur="updateTimeEntryDescription" />
|
||||||
|
|||||||
@@ -170,10 +170,6 @@ function closeAndFocusInput() {
|
|||||||
: 'text-text-primary bg-card-background border-border-secondary border border-none'
|
: 'text-text-primary bg-card-background border-border-secondary border border-none'
|
||||||
"
|
"
|
||||||
type="text"
|
type="text"
|
||||||
autocomplete="off"
|
|
||||||
data-1p-ignore
|
|
||||||
data-lpignore="true"
|
|
||||||
data-form-type="other"
|
|
||||||
@focusin="openModalOnTab"
|
@focusin="openModalOnTab"
|
||||||
@click="openModalOnClick"
|
@click="openModalOnClick"
|
||||||
@keydown.exact.tab="focusNextElement"
|
@keydown.exact.tab="focusNextElement"
|
||||||
|
|||||||
@@ -2,7 +2,6 @@
|
|||||||
|
|
||||||
declare(strict_types=1);
|
declare(strict_types=1);
|
||||||
|
|
||||||
use App\Http\Controllers\Api\FallbackController;
|
|
||||||
use App\Http\Controllers\Api\V1\ApiTokenController;
|
use App\Http\Controllers\Api\V1\ApiTokenController;
|
||||||
use App\Http\Controllers\Api\V1\ChartController;
|
use App\Http\Controllers\Api\V1\ChartController;
|
||||||
use App\Http\Controllers\Api\V1\ClientController;
|
use App\Http\Controllers\Api\V1\ClientController;
|
||||||
@@ -24,6 +23,7 @@ use App\Http\Controllers\Api\V1\UserController;
|
|||||||
use App\Http\Controllers\Api\V1\UserMembershipController;
|
use App\Http\Controllers\Api\V1\UserMembershipController;
|
||||||
use App\Http\Controllers\Api\V1\UserTimeEntryController;
|
use App\Http\Controllers\Api\V1\UserTimeEntryController;
|
||||||
use Illuminate\Support\Facades\Route;
|
use Illuminate\Support\Facades\Route;
|
||||||
|
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|--------------------------------------------------------------------------
|
|--------------------------------------------------------------------------
|
||||||
@@ -200,5 +200,9 @@ Route::prefix('v1')->name('v1.')->group(static function (): void {
|
|||||||
* Fallback routes, to prevent a rendered HTML page in /api/* routes
|
* Fallback routes, to prevent a rendered HTML page in /api/* routes
|
||||||
* The / route is also included since the fallback is not triggered on the root route
|
* The / route is also included since the fallback is not triggered on the root route
|
||||||
*/
|
*/
|
||||||
Route::get('/', FallbackController::class);
|
Route::get('/', function (): void {
|
||||||
Route::fallback(FallbackController::class);
|
throw new NotFoundHttpException('API resource not found');
|
||||||
|
});
|
||||||
|
Route::fallback(function (): void {
|
||||||
|
throw new NotFoundHttpException('API resource not found');
|
||||||
|
});
|
||||||
|
|||||||
@@ -1,113 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
namespace Tests\Unit\ApiDocs;
|
|
||||||
|
|
||||||
use App\Http\Controllers\Api\FallbackController;
|
|
||||||
use Dedoc\Scramble\Infer\Context;
|
|
||||||
use Illuminate\Console\Command;
|
|
||||||
use Illuminate\Support\Facades\File;
|
|
||||||
use PHPUnit\Framework\Attributes\CoversClass;
|
|
||||||
use Tests\TestCase;
|
|
||||||
|
|
||||||
#[CoversClass(FallbackController::class)]
|
|
||||||
class ApiDocsExportTest extends TestCase
|
|
||||||
{
|
|
||||||
private string $path;
|
|
||||||
|
|
||||||
protected function setUp(): void
|
|
||||||
{
|
|
||||||
parent::setUp();
|
|
||||||
// Scramble keeps its inference context in a static property, which would otherwise outlive the refreshed application
|
|
||||||
Context::reset();
|
|
||||||
$this->path = storage_path('framework/testing/api-docs-'.uniqid().'.json');
|
|
||||||
File::ensureDirectoryExists(dirname($this->path));
|
|
||||||
}
|
|
||||||
|
|
||||||
protected function tearDown(): void
|
|
||||||
{
|
|
||||||
File::delete($this->path);
|
|
||||||
parent::tearDown();
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* @return array<string, mixed>
|
|
||||||
*/
|
|
||||||
private function exportApiDocs(): array
|
|
||||||
{
|
|
||||||
$exitCode = $this->withoutMockingConsoleOutput()->artisan('scramble:export', [
|
|
||||||
'--path' => $this->path,
|
|
||||||
]);
|
|
||||||
$this->assertSame(Command::SUCCESS, $exitCode);
|
|
||||||
$this->assertFileExists($this->path);
|
|
||||||
|
|
||||||
return json_decode(File::get($this->path), true, flags: JSON_THROW_ON_ERROR);
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* @param array<string, mixed> $docs
|
|
||||||
* @param array<string, mixed> $schema
|
|
||||||
* @return array<string, mixed>
|
|
||||||
*/
|
|
||||||
private function resolveSchema(array $docs, array $schema): array
|
|
||||||
{
|
|
||||||
if (isset($schema['$ref'])) {
|
|
||||||
$name = str_replace('#/components/schemas/', '', $schema['$ref']);
|
|
||||||
|
|
||||||
return $this->resolveSchema($docs, $docs['components']['schemas'][$name]);
|
|
||||||
}
|
|
||||||
|
|
||||||
return $schema;
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_api_docs_can_be_exported(): void
|
|
||||||
{
|
|
||||||
// Act
|
|
||||||
$docs = $this->exportApiDocs();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertArrayHasKey('paths', $docs);
|
|
||||||
$this->assertNotEmpty($docs['paths']);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_paginated_endpoints_are_documented_with_pagination(): void
|
|
||||||
{
|
|
||||||
// Act
|
|
||||||
$docs = $this->exportApiDocs();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$tagsSchema = $docs['paths']['/v1/organizations/{organization}/tags']['get']['responses']['200']['content']['application/json']['schema'];
|
|
||||||
$this->assertSame(['data', 'links', 'meta'], $tagsSchema['required']);
|
|
||||||
$tagsData = $this->resolveSchema($docs, $tagsSchema['properties']['data']);
|
|
||||||
$this->assertSame('array', $tagsData['type']);
|
|
||||||
$this->assertSame('#/components/schemas/TagResource', $tagsData['items']['$ref']);
|
|
||||||
|
|
||||||
$timeEntriesSchema = $docs['paths']['/v1/organizations/{organization}/time-entries']['get']['responses']['200']['content']['application/json']['schema'];
|
|
||||||
$this->assertSame(['data', 'meta'], $timeEntriesSchema['required']);
|
|
||||||
$this->assertSame(['total'], $timeEntriesSchema['properties']['meta']['required']);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_fallback_routes_are_excluded_from_api_docs(): void
|
|
||||||
{
|
|
||||||
// Act
|
|
||||||
$docs = $this->exportApiDocs();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertArrayNotHasKey('/', $docs['paths']);
|
|
||||||
$this->assertArrayNotHasKey('/{fallbackPlaceholder}', $docs['paths']);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_fallback_routes_return_not_found(): void
|
|
||||||
{
|
|
||||||
// Act
|
|
||||||
$rootResponse = $this->getJson('/api');
|
|
||||||
$unknownResponse = $this->getJson('/api/does-not-exist');
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$rootResponse->assertNotFound();
|
|
||||||
$rootResponse->assertJsonPath('message', 'API resource not found');
|
|
||||||
$unknownResponse->assertNotFound();
|
|
||||||
$unknownResponse->assertJsonPath('message', 'API resource not found');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -50,8 +50,7 @@ class TrustHostsTest extends TestCase
|
|||||||
$this->middleware()->handle($request, fn (Request $request): Response => new Response('passed'));
|
$this->middleware()->handle($request, fn (Request $request): Response => new Response('passed'));
|
||||||
|
|
||||||
try {
|
try {
|
||||||
// Note: Throws an exception if the host is not trusted
|
dump($request->getHost());
|
||||||
$request->getHost();
|
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
} catch (\Throwable) {
|
} catch (\Throwable) {
|
||||||
|
|||||||
@@ -1,209 +0,0 @@
|
|||||||
<?php
|
|
||||||
|
|
||||||
declare(strict_types=1);
|
|
||||||
|
|
||||||
namespace Tests\Unit\Model;
|
|
||||||
|
|
||||||
use App\Models\Audit;
|
|
||||||
use App\Models\Concerns\AuditableWithoutOwner;
|
|
||||||
use App\Models\Member;
|
|
||||||
use App\Models\Organization;
|
|
||||||
use App\Models\Project;
|
|
||||||
use App\Models\ProjectMember;
|
|
||||||
use App\Models\TimeEntry;
|
|
||||||
use App\Models\User;
|
|
||||||
use Illuminate\Database\Eloquent\Model;
|
|
||||||
use Illuminate\Database\Eloquent\Relations\Relation;
|
|
||||||
use Illuminate\Support\Facades\DB;
|
|
||||||
use PHPUnit\Framework\Attributes\CoversClass;
|
|
||||||
|
|
||||||
#[CoversClass(Audit::class)]
|
|
||||||
class AuditModelTest extends ModelTestAbstract
|
|
||||||
{
|
|
||||||
public function test_it_belongs_to_an_owner_organization(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$audit = Audit::factory()->create([
|
|
||||||
'owner_organization_id' => $organization->getKey(),
|
|
||||||
]);
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$audit->refresh();
|
|
||||||
$ownerOrganizationRel = $audit->ownerOrganization;
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertNotNull($ownerOrganizationRel);
|
|
||||||
$this->assertTrue($ownerOrganizationRel->is($organization));
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_it_belongs_to_an_owner_user(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$user = User::factory()->create();
|
|
||||||
$audit = Audit::factory()->create([
|
|
||||||
'owner_user_id' => $user->getKey(),
|
|
||||||
]);
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$audit->refresh();
|
|
||||||
$ownerUserRel = $audit->ownerUser;
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertNotNull($ownerUserRel);
|
|
||||||
$this->assertTrue($ownerUserRel->is($user));
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_audits_of_models_with_organization_have_the_organization_as_owner(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$member = Member::factory()->forOrganization($organization)->create();
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$timeEntry = TimeEntry::factory()->forOrganization($organization)->forMember($member)->create();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$audit = Audit::query()->where('auditable_id', $timeEntry->getKey())->sole();
|
|
||||||
$this->assertSame($organization->getKey(), $audit->owner_organization_id);
|
|
||||||
$this->assertNull($audit->owner_user_id);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_audits_of_project_members_have_the_organization_of_the_project_as_owner(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$project = Project::factory()->forOrganization($organization)->create();
|
|
||||||
$member = Member::factory()->forOrganization($organization)->create();
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$projectMember = ProjectMember::factory()->forProject($project)->forMember($member)->create();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$audit = Audit::query()->where('auditable_id', $projectMember->getKey())->sole();
|
|
||||||
$this->assertSame($organization->getKey(), $audit->owner_organization_id);
|
|
||||||
$this->assertNull($audit->owner_user_id);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_owner_organization_through_parent_uses_the_loaded_parent_without_query(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$project = Project::factory()->forOrganization($organization)->create();
|
|
||||||
$projectMember = ProjectMember::factory()->forProject($project)->forMember(Member::factory()->forOrganization($organization)->create())->create();
|
|
||||||
$projectMember->load('project');
|
|
||||||
DB::enableQueryLog();
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$ownerOrganizationId = $projectMember->getAuditOwnerOrganizationId();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertSame($organization->getKey(), $ownerOrganizationId);
|
|
||||||
$this->assertCount(0, DB::getQueryLog());
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_owner_organization_through_parent_ignores_a_loaded_parent_that_does_not_match_the_foreign_key(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$otherOrganization = Organization::factory()->create();
|
|
||||||
$project = Project::factory()->forOrganization($organization)->create();
|
|
||||||
$otherProject = Project::factory()->forOrganization($otherOrganization)->create();
|
|
||||||
$projectMember = ProjectMember::factory()->forProject($project)->forMember(Member::factory()->forOrganization($organization)->create())->create();
|
|
||||||
$projectMember->load('project');
|
|
||||||
$projectMember->project_id = $otherProject->getKey();
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$ownerOrganizationId = $projectMember->getAuditOwnerOrganizationId();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertSame($otherOrganization->getKey(), $ownerOrganizationId);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_audits_of_an_organization_have_the_organization_itself_as_owner(): void
|
|
||||||
{
|
|
||||||
// Act
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$audit = Audit::query()->where('auditable_id', $organization->getKey())->sole();
|
|
||||||
$this->assertSame($organization->getKey(), $audit->owner_organization_id);
|
|
||||||
$this->assertNull($audit->owner_user_id);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_audits_of_a_user_have_the_user_itself_as_owner(): void
|
|
||||||
{
|
|
||||||
// Act
|
|
||||||
$user = User::factory()->create();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$audit = Audit::query()->where('auditable_id', $user->getKey())->sole();
|
|
||||||
$this->assertSame($user->getKey(), $audit->owner_user_id);
|
|
||||||
$this->assertNull($audit->owner_organization_id);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_deleting_an_owner_deletes_its_audits_and_does_not_create_a_deletion_audit(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$user = User::factory()->create();
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$otherUser = User::factory()->create();
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$user->delete();
|
|
||||||
$organization->delete();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertSame(0, Audit::query()->where('auditable_id', $user->getKey())->count());
|
|
||||||
$this->assertSame(0, Audit::query()->where('auditable_id', $organization->getKey())->count());
|
|
||||||
$this->assertSame(1, Audit::query()->where('auditable_id', $otherUser->getKey())->count());
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_auditable_types_without_owner_are_determined_by_the_marker_interface(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$originalMorphMap = Relation::morphMap();
|
|
||||||
$modelWithoutOwner = new class extends Model implements AuditableWithoutOwner {};
|
|
||||||
Relation::morphMap(['model-without-owner' => $modelWithoutOwner::class]);
|
|
||||||
|
|
||||||
try {
|
|
||||||
// Act
|
|
||||||
$typesWithoutOwner = Audit::getAuditableTypesWithoutOwner();
|
|
||||||
$isWithoutOwner = Audit::isAuditableTypeWithoutOwner('model-without-owner');
|
|
||||||
$isTimeEntryWithoutOwner = Audit::isAuditableTypeWithoutOwner((new TimeEntry)->getMorphClass());
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertContains('model-without-owner', $typesWithoutOwner);
|
|
||||||
$this->assertNotContains((new TimeEntry)->getMorphClass(), $typesWithoutOwner);
|
|
||||||
$this->assertTrue($isWithoutOwner);
|
|
||||||
$this->assertFalse($isTimeEntryWithoutOwner);
|
|
||||||
} finally {
|
|
||||||
Relation::morphMap($originalMorphMap, false);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_scope_where_missing_owner_only_returns_audits_without_owner_whose_type_should_have_one(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$originalMorphMap = Relation::morphMap();
|
|
||||||
$modelWithoutOwner = new class extends Model implements AuditableWithoutOwner {};
|
|
||||||
Relation::morphMap(['model-without-owner' => $modelWithoutOwner::class]);
|
|
||||||
$organization = Organization::factory()->create();
|
|
||||||
$user = User::factory()->create();
|
|
||||||
Audit::query()->delete();
|
|
||||||
$missingOwnerAudit = Audit::factory()->create(['auditable_type' => (new TimeEntry)->getMorphClass()]);
|
|
||||||
Audit::factory()->create(['auditable_type' => (new TimeEntry)->getMorphClass(), 'owner_organization_id' => $organization->getKey()]);
|
|
||||||
Audit::factory()->create(['owner_user_id' => $user->getKey()]);
|
|
||||||
Audit::factory()->create(['auditable_type' => 'model-without-owner']);
|
|
||||||
|
|
||||||
try {
|
|
||||||
// Act
|
|
||||||
$auditIds = Audit::query()->whereMissingOwner()->pluck('id')->all();
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$this->assertSame([$missingOwnerAudit->getKey()], $auditIds);
|
|
||||||
} finally {
|
|
||||||
Relation::morphMap($originalMorphMap, false);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -7,7 +7,6 @@ namespace Tests\Unit\Service;
|
|||||||
use App\Enums\Role;
|
use App\Enums\Role;
|
||||||
use App\Events\BeforeOrganizationDeletion;
|
use App\Events\BeforeOrganizationDeletion;
|
||||||
use App\Exceptions\Api\CanNotDeleteUserWhoIsOwnerOfOrganizationWithMultipleMembers;
|
use App\Exceptions\Api\CanNotDeleteUserWhoIsOwnerOfOrganizationWithMultipleMembers;
|
||||||
use App\Models\Audit;
|
|
||||||
use App\Models\Client;
|
use App\Models\Client;
|
||||||
use App\Models\Member;
|
use App\Models\Member;
|
||||||
use App\Models\Organization;
|
use App\Models\Organization;
|
||||||
@@ -183,8 +182,6 @@ class DeletionServiceTest extends TestCaseWithDatabase
|
|||||||
// Assert
|
// Assert
|
||||||
$this->assertOrganizationDeleted($organization->organization);
|
$this->assertOrganizationDeleted($organization->organization);
|
||||||
$this->assertOrganizationNothingDeleted($otherOrganization->organization);
|
$this->assertOrganizationNothingDeleted($otherOrganization->organization);
|
||||||
$this->assertSame(0, Audit::query()->where('owner_organization_id', $organization->organization->getKey())->count());
|
|
||||||
$this->assertGreaterThan(0, Audit::query()->where('owner_organization_id', $otherOrganization->organization->getKey())->count());
|
|
||||||
Log::assertLoggedTimes(fn (LogEntry $log) => $log->level === 'debug'
|
Log::assertLoggedTimes(fn (LogEntry $log) => $log->level === 'debug'
|
||||||
&& $log->message === 'Start deleting organization'
|
&& $log->message === 'Start deleting organization'
|
||||||
&& $log->context['organization_id'] === $organization->organization->getKey(),
|
&& $log->context['organization_id'] === $organization->organization->getKey(),
|
||||||
@@ -321,10 +318,6 @@ class DeletionServiceTest extends TestCaseWithDatabase
|
|||||||
$this->assertDatabaseMissing(Member::class, [
|
$this->assertDatabaseMissing(Member::class, [
|
||||||
'user_id' => $user->getKey(),
|
'user_id' => $user->getKey(),
|
||||||
]);
|
]);
|
||||||
$this->assertSame(0, Audit::query()->where('owner_user_id', $user->getKey())->count());
|
|
||||||
$this->assertSame(0, Audit::query()->where('owner_organization_id', $user->current_team_id)->count());
|
|
||||||
$this->assertGreaterThan(0, Audit::query()->where('owner_user_id', $otherUser->getKey())->count());
|
|
||||||
$this->assertGreaterThan(0, Audit::query()->where('owner_organization_id', $otherUser->current_team_id)->count());
|
|
||||||
Storage::disk(config('filesystems.public'))->assertMissing($user->profile_photo_path);
|
Storage::disk(config('filesystems.public'))->assertMissing($user->profile_photo_path);
|
||||||
Storage::disk(config('filesystems.public'))->assertExists($otherUser->profile_photo_path);
|
Storage::disk(config('filesystems.public'))->assertExists($otherUser->profile_photo_path);
|
||||||
Log::assertLoggedTimes(fn (LogEntry $log) => $log->level === 'debug'
|
Log::assertLoggedTimes(fn (LogEntry $log) => $log->level === 'debug'
|
||||||
@@ -339,24 +332,6 @@ class DeletionServiceTest extends TestCaseWithDatabase
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function test_delete_user_keeps_audits_of_other_organizations_where_the_user_is_the_actor(): void
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
$user = User::factory()->withPersonalOrganization()->create();
|
|
||||||
$otherOrganization = Organization::factory()->create();
|
|
||||||
$audit = Audit::factory()->auditUser($user)->auditFor($otherOrganization)->create([
|
|
||||||
'owner_organization_id' => $otherOrganization->getKey(),
|
|
||||||
]);
|
|
||||||
|
|
||||||
// Act
|
|
||||||
$this->deletionService->deleteUser($user);
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
$audit->refresh();
|
|
||||||
$this->assertSame($user->getKey(), $audit->actor_id);
|
|
||||||
$this->assertSame($otherOrganization->getKey(), $audit->owner_organization_id);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function test_delete_user_deletes_owned_organizations_that_have_only_one_member_and_makes_makes_the_user_placeholder_in_not_owned_organizations(): void
|
public function test_delete_user_deletes_owned_organizations_that_have_only_one_member_and_makes_makes_the_user_placeholder_in_not_owned_organizations(): void
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
|
|||||||
Reference in New Issue
Block a user