adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-08-08 00:02:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

add stable secondary sorting based on id to the tests to avoid flakyness

Browse Source
This commit is contained in:
Gregor Vostrak
2026-07-08 18:24:04 +02:00
parent 75f5144b45
commit c90c1ed8fa
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php
View File

@@ -45,7 +45,7 @@ class ClientEndpointTest extends ApiEndpointTestAbstract
// Assert // Assert
$response->assertStatus(200); $response->assertStatus(200);
$response->assertJsonCount(4, 'data'); $response->assertJsonCount(4, 'data');
$clients = Client::query()->orderBy('created_at', 'desc')->get(); $clients = Client::query()->orderBy('created_at', 'desc')->orderBy('id')->get();
$response->assertJson(fn (AssertableJson $json) => $json $response->assertJson(fn (AssertableJson $json) => $json
->has('data') ->has('data')
->has('links') ->has('links')
@@ -84,9 +84,12 @@ class ClientEndpointTest extends ApiEndpointTestAbstract
->has('links') ->has('links')
->has('meta') ->has('meta')
->count('data', 2) ->count('data', 2)
->where('data.0.id', $clients->get(0)->getKey())
->where('data.1.id', $clients->get(1)->getKey())
); );
// Both clients share the same created_at, so their relative order is not defined.
$this->assertEqualsCanonicalizing([
$clients->get(0)->getKey(),
$clients->get(1)->getKey(),
], $response->json('data.*.id'));
} }
public function test_index_endpoint_without_filter_archived_returns_only_non_archived_clients(): void public function test_index_endpoint_without_filter_archived_returns_only_non_archived_clients(): void

2
tests/Unit/Endpoint/Api/V1/ReportEndpointTest.php
View File

@@ -52,7 +52,7 @@ class ReportEndpointTest extends ApiEndpointTestAbstract
// Assert // Assert
$response->assertStatus(200); $response->assertStatus(200);
$response->assertJsonCount(4, 'data'); $response->assertJsonCount(4, 'data');
$reports = Report::query()->orderBy('created_at', 'desc')->get(); $reports = Report::query()->orderBy('created_at', 'desc')->orderBy('id')->get();
$response->assertJson(fn (AssertableJson $json) => $json $response->assertJson(fn (AssertableJson $json) => $json
->has('data') ->has('data')
->has('links') ->has('links')

2
tests/Unit/Endpoint/Api/V1/TagEndpointTest.php
View File

@@ -44,7 +44,7 @@ class TagEndpointTest extends ApiEndpointTestAbstract
// Assert // Assert
$response->assertStatus(200); $response->assertStatus(200);
$response->assertJsonCount(4, 'data'); $response->assertJsonCount(4, 'data');
$tags = Tag::query()->orderBy('created_at', 'desc')->get(); $tags = Tag::query()->orderBy('created_at', 'desc')->orderBy('id')->get();
$response->assertJson(fn (AssertableJson $json) => $json $response->assertJson(fn (AssertableJson $json) => $json
->has('data') ->has('data')
->has('links') ->has('links')