adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-10-09 14:23:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Detect time entries with a task but no project in consistency check

Browse Source 
The comparison used != which evaluates to NULL when the time entry has no
project, so entries that kept their task after the project was removed
were not reported.
This commit is contained in:
Constantin Graf
2026-10-09 10:37:44 +02:00
parent 194fa6cf49
commit b778622b2b
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/Unit/Console/Commands/SelfHost/SelfHostDatabaseConsistencyCommandTest.php
View File

@@ -38,6 +38,26 @@ class SelfHostDatabaseConsistencyCommandTest extends TestCaseWithDatabase
$this->assertSame("Consistency problem: Time entries have a task that does not belong to the project of the time entry\n - ".$timeEntry->getKey()."\n", $output);
}
public function test_checks_that_task_need_to_be_part_of_project_in_time_entries_with_no_project_in_time_entry(): void
{
// Arrange
$user = $this->createUserWithRole(Role::Owner);
$project = Project::factory()->forOrganization($user->organization)->create();
$task = Task::factory()->forOrganization($user->organization)->forProject($project)->create();
$timeEntry = TimeEntry::factory()->forMember($user->member)->forTask($task)->create([
'project_id' => null,
'client_id' => null,
]);
// Act
$exitCode = $this->withoutMockingConsoleOutput()->artisan('self-host:database-consistency');
// Assert
$this->assertSame(Command::FAILURE, $exitCode);
$output = Artisan::output();
$this->assertSame("Consistency problem: Time entries have a task that does not belong to the project of the time entry\n - ".$timeEntry->getKey()."\n", $output);
}
public function test_checks_that_client_id_is_the_client_id_of_the_project(): void
{
// Arrange