adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-08-15 11:42:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Added usage check to delete endpoints

Browse Source
This commit is contained in:
Constantin Graf
2024-04-18 21:42:29 +02:00
committed by Constantin Graf
parent 40f1159ea5
commit ad6146c483
18 changed files with 326 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php
View File

@@ -6,6 +6,7 @@ namespace Tests\Unit\Endpoint\Api\V1;
use App\Models\Client;
use App\Models\Organization;
use App\Models\Project;
use Illuminate\Testing\Fluent\AssertableJson;
use Laravel\Passport\Passport;
@@ -199,6 +200,27 @@ class ClientEndpointTest extends ApiEndpointTestAbstract
]);
}
public function test_destroy_endpoint_fails_if_client_is_still_in_use_by_project(): void
{
// Arrange
$data = $this->createUserWithPermission([
'clients:delete',
]);
$client = Client::factory()->forOrganization($data->organization)->create();
$project = Project::factory()->forOrganization($data->organization)->forClient($client)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.clients.destroy', [$data->organization->getKey(), $client->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The client is still used by a project and can not be deleted.');
$this->assertDatabaseHas(Client::class, [
'id' => $client->getKey(),
]);
}
public function test_destroy_endpoint_deletes_client(): void
{
// Arrange

44
tests/Unit/Endpoint/Api/V1/MemberEndpointTest.php
View File

@@ -6,6 +6,9 @@ namespace Tests\Unit\Endpoint\Api\V1;
use App\Models\Membership;
use App\Models\Organization;
use App\Models\Project;
use App\Models\ProjectMember;
use App\Models\TimeEntry;
use App\Models\User;
use Laravel\Passport\Passport;
@@ -154,6 +157,47 @@ class MemberEndpointTest extends ApiEndpointTestAbstract
$response->assertStatus(403);
}
public function test_destroy_endpoint_fails_if_member_is_still_in_use_by_a_time_entry(): void
{
// Arrange
$data = $this->createUserWithPermission([
'members:delete',
]);
TimeEntry::factory()->forUser($data->user)->forOrganization($data->organization)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.members.destroy', [$data->organization->getKey(), $data->member->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The member is still used by a time entry and can not be deleted.');
$this->assertDatabaseHas(Membership::class, [
'id' => $data->member->getKey(),
]);
}
public function test_destroy_endpoint_fails_if_member_is_still_in_use_by_a_project_member(): void
{
// Arrange
$data = $this->createUserWithPermission([
'members:delete',
]);
$project = Project::factory()->forOrganization($data->organization)->create();
ProjectMember::factory()->forProject($project)->forUser($data->user)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.members.destroy', [$data->organization->getKey(), $data->member->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The member is still used by a project member and can not be deleted.');
$this->assertDatabaseHas(Membership::class, [
'id' => $data->member->getKey(),
]);
}
public function test_destroy_member_succeeds_if_data_is_valid(): void
{
// Arrange

44
tests/Unit/Endpoint/Api/V1/ProjectEndpointTest.php
View File

@@ -7,6 +7,8 @@ namespace Tests\Unit\Endpoint\Api\V1;
use App\Models\Client;
use App\Models\Organization;
use App\Models\Project;
use App\Models\Task;
use App\Models\TimeEntry;
use Laravel\Passport\Passport;
class ProjectEndpointTest extends ApiEndpointTestAbstract
@@ -333,6 +335,48 @@ class ProjectEndpointTest extends ApiEndpointTestAbstract
$response->assertForbidden();
}
public function test_destroy_endpoint_fails_if_project_is_still_in_use_by_a_task(): void
{
// Arrange
$data = $this->createUserWithPermission([
'projects:delete',
]);
$project = Project::factory()->forOrganization($data->organization)->create();
$task = Task::factory()->forProject($project)->forOrganization($data->organization)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.projects.destroy', [$data->organization->getKey(), $project->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The project is still used by a task and can not be deleted.');
$this->assertDatabaseHas(Project::class, [
'id' => $project->getKey(),
]);
}
public function test_destroy_endpoint_fails_if_project_is_still_in_use_by_a_time_entry(): void
{
// Arrange
$data = $this->createUserWithPermission([
'projects:delete',
]);
$project = Project::factory()->forOrganization($data->organization)->create();
$timeEntry = TimeEntry::factory()->forProject($project)->forOrganization($data->organization)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.projects.destroy', [$data->organization->getKey(), $project->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The project is still used by a time entry and can not be deleted.');
$this->assertDatabaseHas(Project::class, [
'id' => $project->getKey(),
]);
}
public function test_destroy_endpoint_deletes_project(): void
{
// Arrange

24
tests/Unit/Endpoint/Api/V1/TagEndpointTest.php
View File

@@ -6,6 +6,7 @@ namespace Tests\Unit\Endpoint\Api\V1;
use App\Models\Organization;
use App\Models\Tag;
use App\Models\TimeEntry;
use Illuminate\Testing\Fluent\AssertableJson;
use Laravel\Passport\Passport;
@@ -199,6 +200,29 @@ class TagEndpointTest extends ApiEndpointTestAbstract
]);
}
public function test_destroy_endpoint_fails_if_tag_is_still_in_use_by_a_time_entry(): void
{
// Arrange
$data = $this->createUserWithPermission([
'tags:delete',
]);
$tag = Tag::factory()->forOrganization($data->organization)->create();
TimeEntry::factory()->forUser($data->user)->forOrganization($data->organization)->create([
'tags' => [$tag->getKey()],
]);
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.tags.destroy', [$data->organization->getKey(), $tag->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The tag is still used by a time entry and can not be deleted.');
$this->assertDatabaseHas(Tag::class, [
'id' => $tag->getKey(),
]);
}
public function test_destroy_endpoint_deletes_tag(): void
{
// Arrange

22
tests/Unit/Endpoint/Api/V1/TaskEndpointTest.php
View File

@@ -7,6 +7,7 @@ namespace Tests\Unit\Endpoint\Api\V1;
use App\Models\Project;
use App\Models\ProjectMember;
use App\Models\Task;
use App\Models\TimeEntry;
use Laravel\Passport\Passport;
class TaskEndpointTest extends ApiEndpointTestAbstract
@@ -303,6 +304,27 @@ class TaskEndpointTest extends ApiEndpointTestAbstract
]);
}
public function test_destroy_endpoint_fails_if_task_is_still_in_use_by_a_time_entry(): void
{
// Arrange
$data = $this->createUserWithPermission([
'tasks:delete',
]);
$task = Task::factory()->forOrganization($data->organization)->create();
TimeEntry::factory()->forUser($data->user)->forTask($task)->forOrganization($data->organization)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.tasks.destroy', [$data->organization->getKey(), $task->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'The task is still used by a time entry and can not be deleted.');
$this->assertDatabaseHas(Task::class, [
'id' => $task->getKey(),
]);
}
public function test_delete_endpoint_fails_if_user_has_no_permission_to_delete_tasks(): void
{
// Arrange