mirror of
https://github.com/solidtime-io/solidtime.git
synced 2026-08-17 04:32:15 +01:00
fix: display custom billable rate correctly on project detail page
This commit is contained in:
@@ -317,6 +317,55 @@ test('test that sort state persists after page reload', async ({ page }) => {
|
|||||||
await expect(page.getByTestId('project_table')).toBeVisible();
|
await expect(page.getByTestId('project_table')).toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('test that custom billable rate is displayed correctly on project detail page', async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
const newProjectName = 'Billable Rate Project ' + Math.floor(1 + Math.random() * 10000);
|
||||||
|
const newBillableRate = Math.round(10 + Math.random() * 1000);
|
||||||
|
await goToProjectsOverview(page);
|
||||||
|
await page.getByRole('button', { name: 'Create Project' }).click();
|
||||||
|
await page.getByLabel('Project Name').fill(newProjectName);
|
||||||
|
|
||||||
|
await Promise.all([
|
||||||
|
page.getByRole('button', { name: 'Create Project' }).click(),
|
||||||
|
page.waitForResponse(
|
||||||
|
(response) =>
|
||||||
|
response.url().includes('/projects') &&
|
||||||
|
response.request().method() === 'POST' &&
|
||||||
|
response.status() === 201
|
||||||
|
),
|
||||||
|
]);
|
||||||
|
await expect(page.getByText(newProjectName)).toBeVisible({ timeout: 10000 });
|
||||||
|
|
||||||
|
// Edit the project to set a custom billable rate
|
||||||
|
await page.getByRole('row').first().getByRole('button').click();
|
||||||
|
await page.getByRole('menuitem').getByText('Edit').first().click();
|
||||||
|
await page.getByText('Non-Billable').click();
|
||||||
|
await page.getByText('Custom Rate').click();
|
||||||
|
await page.getByPlaceholder('Billable Rate').fill(newBillableRate.toString());
|
||||||
|
await page.getByRole('button', { name: 'Update Project' }).click();
|
||||||
|
|
||||||
|
await Promise.all([
|
||||||
|
page.locator('button').filter({ hasText: 'Yes, update existing time' }).click(),
|
||||||
|
page.waitForResponse(
|
||||||
|
async (response) =>
|
||||||
|
response.url().includes('/projects/') &&
|
||||||
|
response.request().method() === 'PUT' &&
|
||||||
|
response.status() === 200
|
||||||
|
),
|
||||||
|
]);
|
||||||
|
|
||||||
|
// Navigate to the project detail page by clicking the project name
|
||||||
|
await page.getByText(newProjectName).first().click();
|
||||||
|
await page.waitForURL(/\/projects\/[a-f0-9-]+/);
|
||||||
|
|
||||||
|
// Verify the badge displays the correctly formatted billable rate
|
||||||
|
const expectedFormattedRate = formatCentsWithOrganizationDefaults(newBillableRate * 100);
|
||||||
|
await expect(page.locator('nav[aria-label="Breadcrumb"]').locator('..')).toContainText(
|
||||||
|
expectedFormattedRate
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
// Create new project with new Client
|
// Create new project with new Client
|
||||||
|
|
||||||
// Create new project with existing Client
|
// Create new project with existing Client
|
||||||
|
|||||||
@@ -44,8 +44,7 @@ import UpdateSidebarNotification from '@/Components/UpdateSidebarNotification.vu
|
|||||||
import BillingBanner from '@/Components/Billing/BillingBanner.vue';
|
import BillingBanner from '@/Components/Billing/BillingBanner.vue';
|
||||||
import UserTimezoneMismatchModal from '@/Components/Common/User/UserTimezoneMismatchModal.vue';
|
import UserTimezoneMismatchModal from '@/Components/Common/User/UserTimezoneMismatchModal.vue';
|
||||||
import { useTheme } from '@/utils/theme';
|
import { useTheme } from '@/utils/theme';
|
||||||
import { useQuery } from '@tanstack/vue-query';
|
import { useOrganizationQuery } from '@/utils/useOrganizationQuery';
|
||||||
import { api } from '@/packages/api/src';
|
|
||||||
import { getCurrentOrganizationId } from '@/utils/useUser';
|
import { getCurrentOrganizationId } from '@/utils/useUser';
|
||||||
import LoadingSpinner from '@/packages/ui/src/LoadingSpinner.vue';
|
import LoadingSpinner from '@/packages/ui/src/LoadingSpinner.vue';
|
||||||
import { twMerge } from 'tailwind-merge';
|
import { twMerge } from 'tailwind-merge';
|
||||||
@@ -65,22 +64,12 @@ defineProps({
|
|||||||
const showSidebarMenu = ref(false);
|
const showSidebarMenu = ref(false);
|
||||||
const isUnloading = ref(false);
|
const isUnloading = ref(false);
|
||||||
|
|
||||||
const { data: organization, isLoading: isOrganizationLoading } = useQuery({
|
const { organization, isLoading: isOrganizationLoading } = useOrganizationQuery(
|
||||||
queryKey: ['organization', getCurrentOrganizationId()],
|
getCurrentOrganizationId()!
|
||||||
queryFn: () =>
|
|
||||||
api.getOrganization({
|
|
||||||
params: {
|
|
||||||
organization: getCurrentOrganizationId()!,
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
enabled: !!getCurrentOrganizationId(),
|
|
||||||
});
|
|
||||||
|
|
||||||
provide(
|
|
||||||
'organization',
|
|
||||||
computed(() => organization.value?.data)
|
|
||||||
);
|
);
|
||||||
|
|
||||||
|
provide('organization', organization);
|
||||||
|
|
||||||
onMounted(async () => {
|
onMounted(async () => {
|
||||||
useTheme();
|
useTheme();
|
||||||
// make sure that the initial requests are only loaded once, this can be removed once we move away from inertia
|
// make sure that the initial requests are only loaded once, this can be removed once we move away from inertia
|
||||||
|
|||||||
@@ -3,7 +3,7 @@ import MainContainer from '@/packages/ui/src/MainContainer.vue';
|
|||||||
import AppLayout from '@/Layouts/AppLayout.vue';
|
import AppLayout from '@/Layouts/AppLayout.vue';
|
||||||
import { FolderIcon, PlusIcon } from '@heroicons/vue/16/solid';
|
import { FolderIcon, PlusIcon } from '@heroicons/vue/16/solid';
|
||||||
import SecondaryButton from '@/packages/ui/src/Buttons/SecondaryButton.vue';
|
import SecondaryButton from '@/packages/ui/src/Buttons/SecondaryButton.vue';
|
||||||
import { computed, ref, inject, type ComputedRef } from 'vue';
|
import { computed, ref } from 'vue';
|
||||||
import { useProjectsQuery } from '@/utils/useProjectsQuery';
|
import { useProjectsQuery } from '@/utils/useProjectsQuery';
|
||||||
import {
|
import {
|
||||||
ChevronRightIcon,
|
ChevronRightIcon,
|
||||||
@@ -28,11 +28,12 @@ import ProjectEditModal from '@/Components/Common/Project/ProjectEditModal.vue';
|
|||||||
import { Badge } from '@/packages/ui/src';
|
import { Badge } from '@/packages/ui/src';
|
||||||
import { formatCents } from '../packages/ui/src/utils/money';
|
import { formatCents } from '../packages/ui/src/utils/money';
|
||||||
import { getOrganizationCurrencyString } from '../utils/money';
|
import { getOrganizationCurrencyString } from '../utils/money';
|
||||||
import type { Organization } from '@/packages/api/src';
|
import { useOrganizationQuery } from '@/utils/useOrganizationQuery';
|
||||||
|
import { getCurrentOrganizationId } from '@/utils/useUser';
|
||||||
|
|
||||||
const { projects } = useProjectsQuery();
|
const { projects } = useProjectsQuery();
|
||||||
|
|
||||||
const organization = inject<ComputedRef<Organization>>('organization');
|
const { organization } = useOrganizationQuery(getCurrentOrganizationId()!);
|
||||||
|
|
||||||
const project = computed(() => {
|
const project = computed(() => {
|
||||||
return projects.value.find((project) => project.id === route().params.project) ?? null;
|
return projects.value.find((project) => project.id === route().params.project) ?? null;
|
||||||
@@ -48,6 +49,19 @@ const { projectMembers } = canViewProjectMembers()
|
|||||||
|
|
||||||
const showEditProjectModal = ref(false);
|
const showEditProjectModal = ref(false);
|
||||||
|
|
||||||
|
const billableRateFormatted = computed(() => {
|
||||||
|
if (project.value?.billable_rate) {
|
||||||
|
return formatCents(
|
||||||
|
project.value.billable_rate,
|
||||||
|
getOrganizationCurrencyString(),
|
||||||
|
organization.value?.currency_format,
|
||||||
|
organization.value?.currency_symbol,
|
||||||
|
organization.value?.number_format
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
});
|
||||||
|
|
||||||
const activeTab = ref<'active' | 'done'>('active');
|
const activeTab = ref<'active' | 'done'>('active');
|
||||||
|
|
||||||
const { tasks } = useTasksQuery();
|
const { tasks } = useTasksQuery();
|
||||||
@@ -96,15 +110,7 @@ const shownTasks = computed(() => {
|
|||||||
</ol>
|
</ol>
|
||||||
<div class="px-4">
|
<div class="px-4">
|
||||||
<Badge v-if="project?.billable_rate">
|
<Badge v-if="project?.billable_rate">
|
||||||
{{
|
{{ billableRateFormatted }}
|
||||||
formatCents(
|
|
||||||
project?.billable_rate ?? 0,
|
|
||||||
getOrganizationCurrencyString(),
|
|
||||||
organization?.currency_format,
|
|
||||||
organization?.currency_symbol,
|
|
||||||
organization?.number_format
|
|
||||||
)
|
|
||||||
}}
|
|
||||||
/ h
|
/ h
|
||||||
</Badge>
|
</Badge>
|
||||||
<Badge v-if="project?.is_billable && !project?.billable_rate">
|
<Badge v-if="project?.is_billable && !project?.billable_rate">
|
||||||
|
|||||||
22
resources/js/utils/useOrganizationQuery.ts
Normal file
22
resources/js/utils/useOrganizationQuery.ts
Normal file
@@ -0,0 +1,22 @@
|
|||||||
|
import { useQuery } from '@tanstack/vue-query';
|
||||||
|
import { api } from '@/packages/api/src';
|
||||||
|
import { computed } from 'vue';
|
||||||
|
|
||||||
|
export function useOrganizationQuery(organizationId: string) {
|
||||||
|
const query = useQuery({
|
||||||
|
queryKey: ['organization', organizationId],
|
||||||
|
queryFn: () =>
|
||||||
|
api.getOrganization({
|
||||||
|
params: {
|
||||||
|
organization: organizationId,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
|
||||||
|
const organization = computed(() => query.data.value?.data);
|
||||||
|
|
||||||
|
return {
|
||||||
|
...query,
|
||||||
|
organization,
|
||||||
|
};
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user