From 6dc7c1ba1d2a4fd339709be78d88db7a1beb5a54 Mon Sep 17 00:00:00 2001 From: Constantin Graf Date: Wed, 27 Mar 2024 22:58:04 +0100 Subject: [PATCH] Github actions: Added missing step for ziggy; Added names to steps --- .github/workflows/npm-build.yml | 21 +++++++++++++++------ .github/workflows/npm-lint.yml | 10 +++++++--- .github/workflows/npm-typecheck.yml | 20 +++++++++++++++++--- .github/workflows/phpunit.yml | 4 ++-- 4 files changed, 41 insertions(+), 14 deletions(-) diff --git a/.github/workflows/npm-build.yml b/.github/workflows/npm-build.yml index 85f2f667..8bf52914 100644 --- a/.github/workflows/npm-build.yml +++ b/.github/workflows/npm-build.yml @@ -11,14 +11,23 @@ jobs: - name: "Checkout code" uses: actions/checkout@v4 - - uses: shivammathur/setup-php@v2 + - name: "Setup PHP (for Ziggy)" + uses: shivammathur/setup-php@v2 with: - php-version: '8.3.1' + php-version: '8.3' extensions: intl, zip - - run: composer install - - name: Use Node.js + coverage: none + + - name: "Run composer install (for Ziggy)" + run: composer install -n --prefer-dist + + - name: "Use Node.js" uses: actions/setup-node@v4 with: node-version: '20.x' - - run: npm ci - - run: npm run build + + - name: "Install npm dependencies" + run: npm ci + + - name: "Build" + run: npm run build diff --git a/.github/workflows/npm-lint.yml b/.github/workflows/npm-lint.yml index 6adc4c61..9a837c7a 100644 --- a/.github/workflows/npm-lint.yml +++ b/.github/workflows/npm-lint.yml @@ -11,9 +11,13 @@ jobs: - name: "Checkout code" uses: actions/checkout@v4 - - name: Use Node.js + - name: "Use Node.js" uses: actions/setup-node@v4 with: node-version: '20.x' - - run: npm ci - - run: npm run lint + + - name: "Install npm dependencies" + run: npm ci + + - name: "Run linter" + run: npm run lint diff --git a/.github/workflows/npm-typecheck.yml b/.github/workflows/npm-typecheck.yml index 27843604..d271613c 100644 --- a/.github/workflows/npm-typecheck.yml +++ b/.github/workflows/npm-typecheck.yml @@ -11,9 +11,23 @@ jobs: - name: "Checkout code" uses: actions/checkout@v4 - - name: Use Node.js + - name: "Setup PHP (for Ziggy)" + uses: shivammathur/setup-php@v2 + with: + php-version: '8.3' + extensions: intl, zip + coverage: none + + - name: "Run composer install (for Ziggy)" + run: composer install -n --prefer-dist + + - name: "Use Node.js" uses: actions/setup-node@v4 with: node-version: '20.x' - - run: npm ci - - run: npm run type-check + + - name: "Install npm dependencies" + run: npm ci + + - name: "Run type check" + run: npm run type-check diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index dd65dbfc..79674551 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -38,10 +38,10 @@ jobs: with: node-version: '20.x' - - name: Install dependencies + - name: "Install dependencies" run: npm ci - - name: Build Frontend + - name: "Build Frontend" run: npm run build - name: "Prepare Laravel Application"