adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-10-16 01:33:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Throw import exception for missing references in solidtime import

Browse Source 
Time entries referencing a user, member, client, project or task that is not part of the import caused a TypeError, which surfaced as "Unknown error".
This commit is contained in:
Constantin Graf
2026-10-14 10:30:53 +02:00
committed by Constantin Graf
parent 0c58896b00
commit 65525791a6
12 changed files with 61 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/Service/Import/Importers/SolidtimeImporter.php
View File

@@ -212,17 +212,29 @@ class SolidtimeImporter extends DefaultImporter
// Time entries
foreach ($timeEntriesReader as $timeEntryRow) {
$userId = $this->userImportHelper->getKeyByExternalIdentifier($timeEntryRow['user_id']);
if ($userId === null) {
throw new ImportException('Time entry references a user that does not exist in the import');
}
$memberId = $this->memberImportHelper->getKeyByExternalIdentifier($timeEntryRow['member_id']);
if ($memberId === null) {
throw new ImportException('Time entry references a member that does not exist in the import');
}
$member = $this->memberImportHelper->getModelById($memberId);
$clientId = null;
if ($timeEntryRow['client_id'] !== '') {
$clientId = $this->clientImportHelper->getKeyByExternalIdentifier($timeEntryRow['client_id']);
if ($clientId === null) {
throw new ImportException('Time entry references a client that does not exist in the import');
}
}
$project = null;
$projectId = null;
$projectMember = null;
if ($timeEntryRow['project_id'] !== '') {
$projectId = $this->projectImportHelper->getKeyByExternalIdentifier($timeEntryRow['project_id']);
if ($projectId === null) {
throw new ImportException('Time entry references a project that does not exist in the import');
}
$project = $this->projectImportHelper->getModelById($projectId);
$projectMember = $this->projectMemberImportHelper->getModel([
'project_id' => $projectId,
@@ -232,6 +244,9 @@ class SolidtimeImporter extends DefaultImporter
$taskId = null;
if ($timeEntryRow['task_id'] !== '') {
$taskId = $this->taskImportHelper->getKeyByExternalIdentifier($timeEntryRow['task_id']);
if ($taskId === null) {
throw new ImportException('Time entry references a task that does not exist in the import');
}
$this->taskImportHelper->getModelById($taskId);
}
$timeEntry = new TimeEntry;