adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-08-15 11:42:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Added php-cs-fixer rule void_return

Browse Source
This commit is contained in:
Constantin Graf
2024-07-02 16:37:05 +02:00
committed by Gregor Vostrak
parent a820d8540f
commit 2e8da98287
51 changed files with 96 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Actions/Fortify/CreateNewUser.php
View File

@@ -82,7 +82,7 @@ class CreateNewUser implements CreatesNewUsers
}
$user = null;
$organization = null;
DB::transaction(function () use (&$user, &$organization, $input, $timezone, $startOfWeek, $currency) {
DB::transaction(function () use (&$user, &$organization, $input, $timezone, $startOfWeek, $currency): void {
$user = User::create([
'name' => $input['name'],
'email' => $input['email'],

4
app/Actions/Jetstream/AddOrganizationMember.php
View File

@@ -38,7 +38,7 @@ class AddOrganizationMember implements AddsTeamMembers
AddingTeamMember::dispatch($organization, $newOrganizationMember);
DB::transaction(function () use ($organization, $newOrganizationMember, $role) {
DB::transaction(function () use ($organization, $newOrganizationMember, $role): void {
$organization->users()->attach(
$newOrganizationMember, ['role' => $role]
);
@@ -93,7 +93,7 @@ class AddOrganizationMember implements AddsTeamMembers
*/
protected function ensureUserIsNotAlreadyOnTeam(Organization $team, string $email): Closure
{
return function ($validator) use ($team, $email) {
return function ($validator) use ($team, $email): void {
$validator->errors()->addIf(
$team->hasRealUserWithEmail($email),
'email',

2
app/Console/Commands/TimeEntry/TimeEntrySendStillRunningMailsCommand.php
View File

@@ -54,7 +54,7 @@ class TimeEntrySendStillRunningMailsCommand extends Command
$query->where('is_placeholder', '=', false);
})
->orderBy('created_at', 'asc')
->chunk(500, function (Collection $timeEntries) use ($dryRun, &$sentMails) {
->chunk(500, function (Collection $timeEntries) use ($dryRun, &$sentMails): void {
/** @var Collection<int, TimeEntry> $timeEntries */
foreach ($timeEntries as $timeEntry) {
$user = $timeEntry->user;

2
app/Exceptions/Handler.php
View File

@@ -27,7 +27,7 @@ class Handler extends ExceptionHandler
*/
public function register(): void
{
$this->reportable(function (Throwable $e) {
$this->reportable(function (Throwable $e): void {
//
});
}

4
app/Filament/Resources/OrganizationResource.php
View File

@@ -122,7 +122,7 @@ class OrganizationResource extends Resource
->persistent()
->send();
return response()->streamDownload(function () use ($file) {
return response()->streamDownload(function () use ($file): void {
echo Storage::disk(config('filesystems.private'))->get($file);
}, 'export.zip');
} catch (\Exception $exception) {
@@ -137,7 +137,7 @@ class OrganizationResource extends Resource
}),
Action::make('Import')
->icon('heroicon-o-inbox-arrow-down')
->action(function (Organization $record, array $data) {
->action(function (Organization $record, array $data): void {
try {
$file = Storage::disk(config('filament.default_filesystem_disk'))->get($data['file']);
if ($file === null) {

4
app/Providers/AppServiceProvider.php
View File

@@ -81,10 +81,10 @@ class AppServiceProvider extends ServiceProvider
});
// Scramble
Scramble::extendOpenApi(function (OpenApi $openApi) {
Scramble::extendOpenApi(function (OpenApi $openApi): void {
$openApi->secure(
SecurityScheme::oauth2()
->flow('authorizationCode', function (OAuthFlow $flow) {
->flow('authorizationCode', function (OAuthFlow $flow): void {
$flow
->authorizationUrl('https://solidtime.test/oauth/authorize');
})

4
app/Providers/RouteServiceProvider.php
View File

@@ -37,9 +37,9 @@ class RouteServiceProvider extends ServiceProvider
: Limit::perMinute(60)->by($request->ip());
});
$this->routes(function () {
$this->routes(function (): void {
Route::middleware('health-check')
->group(function () {
->group(function (): void {
Route::get('health-check/up', [HealthCheckController::class, 'up']);
Route::get('health-check/debug', [HealthCheckController::class, 'debug']);
});

6
app/Service/BillableRateService.php
View File

@@ -28,9 +28,9 @@ class BillableRateService
->where('billable', '=', true)
->where('organization_id', '=', $project->organization_id)
->whereBelongsTo($project, 'project')
->whereDoesntHave('member', function (Builder $query) use ($project) {
->whereDoesntHave('member', function (Builder $query) use ($project): void {
/** @var Builder<Member> $query */
$query->whereHas('projectMembers', function (Builder $query) use ($project) {
$query->whereHas('projectMembers', function (Builder $query) use ($project): void {
/** @var Builder<ProjectMember> $query */
$query->whereBelongsTo($project, 'project')
->whereNotNull('billable_rate');
@@ -62,7 +62,7 @@ class BillableRateService
TimeEntry::query()
->where('billable', '=', true)
->where('organization_id', '=', $organization->getKey())
->whereDoesntHave('member', function (Builder $builder) {
->whereDoesntHave('member', function (Builder $builder): void {
/** @var Builder<Member> $builder */
$builder->whereNotNull('billable_rate');
})

4
app/Service/DeletionService.php
View File

@@ -35,7 +35,7 @@ class DeletionService
public function deleteOrganization(Organization $organization, bool $inTransaction = true, ?User $ignoreUser = null): void
{
if ($inTransaction) {
DB::transaction(function () use ($organization) {
DB::transaction(function () use ($organization): void {
$this->deleteOrganization($organization, false);
});
@@ -123,7 +123,7 @@ class DeletionService
public function deleteUser(User $user, bool $inTransaction = true): void
{
if ($inTransaction) {
DB::transaction(function () use ($user) {
DB::transaction(function () use ($user): void {
$this->deleteUser($user, false);
});

2
app/Service/Import/ImportService.php
View File

@@ -31,7 +31,7 @@ class ImportService
$lock = Cache::lock('import:'.$organization->getKey(), config('octane.max_execution_time', 60) + 1);
if ($lock->get()) {
DB::transaction(function () use (&$importer, &$data, &$timezone) {
DB::transaction(function () use (&$importer, &$data, &$timezone): void {
$importer->importData($data, $timezone);
});
$lock->release();

4
app/Service/Import/Importers/DefaultImporter.php
View File

@@ -113,7 +113,7 @@ abstract class DefaultImporter implements ImporterContract
'nullable',
'integer',
],
], beforeSave: function (Project $project) {
], beforeSave: function (Project $project): void {
if ($project->billable_rate === 0) {
$project->billable_rate = null;
}
@@ -126,7 +126,7 @@ abstract class DefaultImporter implements ImporterContract
'nullable',
'integer',
],
], beforeSave: function (ProjectMember $projectMember) {
], beforeSave: function (ProjectMember $projectMember): void {
if ($projectMember->billable_rate === 0) {
$projectMember->billable_rate = null;
}