adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-08-08 00:02:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Restrict removing owner from organization

Browse Source
This commit is contained in:
Constantin Graf
2024-05-21 18:53:20 +02:00
parent 98eea87b5f
commit 2c20e941da
5 changed files with 36 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/Unit/Endpoint/Api/V1/MemberEndpointTest.php
View File

@@ -141,6 +141,23 @@ class MemberEndpointTest extends ApiEndpointTestAbstract
$response->assertStatus(403);
}
public function test_destroy_member_fails_if_member_is_owner(): void
{
// Arrange
$data = $this->createUserWithPermission([
'members:delete',
]);
$memberToDelete = Member::factory()->forOrganization($data->organization)->role(Role::Owner)->create();
Passport::actingAs($data->user);
// Act
$response = $this->deleteJson(route('api.v1.members.destroy', [$data->organization->getKey(), $memberToDelete->getKey()]));
// Assert
$response->assertStatus(400);
$response->assertJsonPath('message', 'Can not remove owner from organization');
}
public function test_destroy_member_fails_if_member_is_not_part_of_org(): void
{
// Arrange

2
tests/Unit/Service/Import/ImportServiceTest.php
View File

@@ -7,6 +7,7 @@ namespace Tests\Unit\Service\Import;
use App\Models\Organization;
use App\Service\Import\ImportService;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\Storage;
use Tests\TestCase;
class ImportServiceTest extends TestCase
@@ -16,6 +17,7 @@ class ImportServiceTest extends TestCase
public function test_import_gets_importer_from_provider_runs_importer_and_returns_report(): void
{
// Arrange
Storage::fake('s3');
$organization = Organization::factory()->create();
$data = file_get_contents(storage_path('tests/toggl_time_entries_import_test_1.csv'));