adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-08-10 09:12:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add ability to update billable rate of existing time entries

Browse Source
This commit is contained in:
Constantin Graf
2024-06-14 16:46:39 +02:00
committed by Gregor Vostrak
parent 7c26cee1ea
commit 2184b3c835
22 changed files with 1001 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

533
tests/Unit/Service/BillableRateServiceTest.php
View File

@@ -11,14 +11,15 @@ use App\Models\ProjectMember;
use App\Models\TimeEntry;
use App\Models\User;
use App\Service\BillableRateService;
use DB;
use Illuminate\Foundation\Testing\RefreshDatabase;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\UsesClass;
use Tests\TestCase;
use Tests\TestCaseWithDatabase;
#[CoversClass(BillableRateService::class)]
#[UsesClass(BillableRateService::class)]
class BillableRateServiceTest extends TestCase
class BillableRateServiceTest extends TestCaseWithDatabase
{
use RefreshDatabase;
@@ -30,6 +31,516 @@ class BillableRateServiceTest extends TestCase
$this->billableRateService = app(BillableRateService::class);
}
/*
* Function: updateTimeEntriesBillableRateForProjectMember
*/
public function test_update_time_entries_billable_rate_for_project_member_updates_time_entries_of_project_member(): void
{
// Arrange
$user = $this->createUserWithPermission();
$project = Project::factory()->forOrganization($user->organization)->create();
$projectMember = ProjectMember::factory()->forMember($user->member)->forProject($project)->create([
'billable_rate' => 123,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProjectMember($projectMember);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 123,
]);
}
public function test_update_time_entries_billable_rate_for_project_member_updates_time_entries_of_project_member_even_if_all_other_billable_rates_are_set(): void
{
// Arrange
$user = $this->createUserWithPermission();
$organization = $user->organization;
$member = $user->member;
$organization->billable_rate = 111;
$organization->save();
$member->billable_rate = 222;
$member->save();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 321,
]);
$projectMember = ProjectMember::factory()->forMember($user->member)->forProject($project)->create([
'billable_rate' => 123,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProjectMember($projectMember);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 123,
]);
}
public function test_update_time_entries_billable_rate_for_project_member_ignores_time_entries_of_other_member(): void
{
// Arrange
$user = $this->createUserWithPermission();
$otherUser = User::factory()->create();
$otherMember = Member::factory()->forUser($otherUser)->forOrganization($user->organization)->create();
$project = Project::factory()->forOrganization($user->organization)->create();
$projectMember = ProjectMember::factory()->forMember($user->member)->forProject($project)->create([
'billable_rate' => 123,
]);
$otherProjectMember = ProjectMember::factory()->forMember($otherMember)->forProject($project)->create([
'billable_rate' => 321,
]);
$timeEntry = TimeEntry::factory()->forMember($otherMember)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProjectMember($projectMember);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
/*
* Function: updateTimeEntriesBillableRateForProject
*/
public function test_update_time_entries_billable_rate_for_project_updates_time_entries_of_project(): void
{
// Arrange
$user = $this->createUserWithPermission();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 321,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProject($project);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 321,
]);
}
public function test_update_time_entries_billable_rate_for_project_updates_time_entries_of_project_all_other_billable_rates_null(): void
{
// Arrange
$user = $this->createUserWithPermission();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 321,
]);
$projectMember = ProjectMember::factory()->forMember($user->member)->forProject($project)->create([
'billable_rate' => null,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProject($project);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 321,
]);
}
public function test_update_time_entries_billable_rate_for_project_ignores_time_entries_that_are_not_billable(): void
{
// Arrange
$user = $this->createUserWithPermission();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 321,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->notBillable()->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProject($project);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => null,
]);
}
public function test_update_time_entries_billable_rate_for_project_ignores_time_entries_that_have_project_member_with_billable_rate(): void
{
// Arrange
$user = $this->createUserWithPermission();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 321,
]);
$projectMember = ProjectMember::factory()->forMember($user->member)->forProject($project)->create([
'billable_rate' => 123,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProject($project);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
public function test_update_time_entries_billable_rate_for_project_ignores_time_entries_of_that_project_but_are_incorrectly_attached_to_other_organization(): void
{
// Arrange
$user = $this->createUserWithPermission();
$userInOtherOrga = $this->createUserWithPermission();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 321,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$brokenTimeEntryInOtherOrganizationButSameProject = TimeEntry::factory()->forMember($userInOtherOrga->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForProject($project);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 2);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 321,
]);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $brokenTimeEntryInOtherOrganizationButSameProject->getKey(),
'billable_rate' => 1,
]);
}
/*
* Function: updateTimeEntriesBillableRateForMember
*/
public function test_update_time_entries_billable_rate_for_member_updates_time_entries_of_member(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$member->billable_rate = 567;
$member->save();
$timeEntry = TimeEntry::factory()->forMember($member)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForMember($member);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 567,
]);
}
public function test_update_time_entries_billable_rate_for_member_updates_time_entries_of_member_all_other_billable_rates_null(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$member->billable_rate = 110;
$member->save();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => null,
]);
$projectMember = ProjectMember::factory()->forMember($member)->forProject($project)->create([
'billable_rate' => null,
]);
$timeEntry = TimeEntry::factory()->forMember($member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForMember($member);
// Assert
$queryLog = DB::getQueryLog();
$this->assertCount(1, $queryLog);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 110,
]);
}
public function test_update_time_entries_billable_rate_for_member_ignores_time_entries_that_have_project_member_with_billable_rate(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$member->billable_rate = 110;
$member->save();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => null,
]);
$projectMember = ProjectMember::factory()->forMember($member)->forProject($project)->create([
'billable_rate' => 123,
]);
$timeEntry = TimeEntry::factory()->forMember($member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForMember($member);
// Assert
$queryLog = DB::getQueryLog();
$this->assertCount(1, $queryLog);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
public function test_update_time_entries_billable_rate_for_member_ignores_time_entries_that_have_project_with_billable_rate(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$member->billable_rate = 110;
$member->save();
$project = Project::factory()->forOrganization($user->organization)->create([
'billable_rate' => 123,
]);
$timeEntry = TimeEntry::factory()->forMember($member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForMember($member);
// Assert
$queryLog = DB::getQueryLog();
$this->assertCount(1, $queryLog);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
/*
* Function: updateTimeEntriesBillableRateForOrganization
*/
public function test_update_time_entries_billable_rate_for_organization_updates_time_entries_of_organization(): void
{
// Arrange
$user = $this->createUserWithPermission();
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$timeEntry = TimeEntry::factory()->forMember($user->member)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($user->organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 110,
]);
}
public function test_update_time_entries_billable_rate_for_organization_updates_time_entries_of_organization_all_other_billable_rates_null(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$project = Project::factory()->forOrganization($organization)->create([
'billable_rate' => null,
]);
$projectMember = ProjectMember::factory()->forProject($project)->forMember($member)->create([
'billable_rate' => null,
]);
$timeEntry = TimeEntry::factory()->forMember($user->member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($user->organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 110,
]);
}
public function test_update_time_entries_billable_rate_for_organization_ignores_time_entries_that_are_not_billable(): void
{
// Arrange
$user = $this->createUserWithPermission();
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$timeEntry = TimeEntry::factory()->forMember($user->member)->notBillable()->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => null,
]);
}
public function test_update_time_entries_billable_rate_for_organization_ignores_time_entries_of_organization(): void
{
// Arrange
$user = $this->createUserWithPermission();
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$otherUser = $this->createUserWithPermission();
$timeEntry = TimeEntry::factory()->forMember($otherUser->member)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
public function test_update_time_entries_billable_rate_for_organization_ignores_time_entries_with_member_with_billable_rate(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$member->billable_rate = 120;
$member->save();
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$timeEntry = TimeEntry::factory()->forMember($member)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
public function test_update_time_entries_billable_rate_for_organization_ignores_time_entries_with_project_with_billable_rate(): void
{
// Arrange
$user = $this->createUserWithPermission();
$member = $user->member;
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$project = Project::factory()->forOrganization($organization)->create([
'billable_rate' => 120,
]);
$timeEntry = TimeEntry::factory()->forMember($member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
public function test_update_time_entries_billable_rate_for_organization_ignores_time_entries_with_project_member_with_billable_rate(): void
{
$user = $this->createUserWithPermission();
$member = $user->member;
$organization = $user->organization;
$organization->billable_rate = 110;
$organization->save();
$project = Project::factory()->forOrganization($organization)->create([
'billable_rate' => null,
]);
$projectMember = ProjectMember::factory()->forProject($project)->forMember($member)->create([
'billable_rate' => 120,
]);
$timeEntry = TimeEntry::factory()->forMember($member)->forProject($project)->billableRate(1)->create();
$this->enableQueryLog();
// Act
$this->billableRateService->updateTimeEntriesBillableRateForOrganization($organization);
// Assert
$this->assertQueryCount(1);
$this->assertDatabaseCount(TimeEntry::class, 1);
$this->assertDatabaseHas(TimeEntry::class, [
'id' => $timeEntry->getKey(),
'billable_rate' => 1,
]);
}
/*
* Function: getBillableRateForTimeEntryWithGivenRelations
*/
public function test_billable_rate_is_null_if_time_entry_is_not_billable(): void
{
// Arrange
@@ -277,6 +788,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => false,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -288,6 +800,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(null, $billableRate);
}
@@ -310,6 +823,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -321,6 +835,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(4004, $billableRate);
}
@@ -343,6 +858,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -354,6 +870,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(3003, $billableRate);
}
@@ -373,6 +890,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -384,6 +902,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(3003, $billableRate);
}
@@ -406,6 +925,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -417,6 +937,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(2002, $billableRate);
}
@@ -433,6 +954,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -444,6 +966,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(2002, $billableRate);
}
@@ -466,6 +989,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -477,6 +1001,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(1001, $billableRate);
}
@@ -493,6 +1018,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -504,6 +1030,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(1001, $billableRate);
}
@@ -526,6 +1053,7 @@ class BillableRateServiceTest extends TestCase
$timeEntry = TimeEntry::factory()->forProject($project)->forMember($member)->forOrganization($organization)->create([
'billable' => true,
]);
$this->enableQueryLog();
// Act
$billableRate = $this->billableRateService->getBillableRateForTimeEntryWithGivenRelations(
@@ -537,6 +1065,7 @@ class BillableRateServiceTest extends TestCase
);
// Assert
$this->assertQueryCount(0);
$this->assertSame(null, $billableRate);
}
}