adalal/solidtime
1
0
Fork 0
mirror of https://github.com/solidtime-io/solidtime.git synced 2026-08-13 10:42:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Allow NONE filter value to shared reports and add shared-report tests

Browse Source
This commit is contained in:
Gregor Vostrak
2026-02-02 20:42:07 +01:00
parent 18989a9a8e
commit 09c3205680
7 changed files with 651 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

83
tests/Unit/Endpoint/Api/V1/ReportEndpointTest.php
View File

@@ -8,7 +8,12 @@ use App\Enums\TimeEntryAggregationType;
use App\Enums\TimeEntryRoundingType;
use App\Enums\Weekday;
use App\Http\Controllers\Api\V1\ReportController;
use App\Models\Client;
use App\Models\Project;
use App\Models\Report;
use App\Models\Tag;
use App\Models\Task;
use App\Service\TimeEntryFilter;
use Illuminate\Support\Carbon;
use Illuminate\Testing\Fluent\AssertableJson;
use Laravel\Passport\Passport;
@@ -490,6 +495,84 @@ class ReportEndpointTest extends ApiEndpointTestAbstract
);
}
public function test_store_endpoint_creates_report_with_none_filter_values(): void
{
// Arrange
$data = $this->createUserWithPermission([
'reports:create',
]);
Passport::actingAs($data->user);
// Act
$response = $this->withoutExceptionHandling()->postJson(route('api.v1.reports.store', [$data->organization->getKey()]), [
'name' => 'Test Report with None Filters',
'is_public' => false,
'properties' => [
'start' => Carbon::now()->subDays(30)->toIso8601ZuluString(),
'end' => Carbon::now()->toIso8601ZuluString(),
'group' => TimeEntryAggregationType::Project->value,
'sub_group' => TimeEntryAggregationType::Task->value,
'history_group' => TimeEntryAggregationType::Day->value,
'project_ids' => [TimeEntryFilter::NONE_VALUE],
'client_ids' => [TimeEntryFilter::NONE_VALUE],
'tag_ids' => [TimeEntryFilter::NONE_VALUE],
'task_ids' => [TimeEntryFilter::NONE_VALUE],
],
]);
// Assert
$response->assertStatus(201);
/** @var Report $report */
$report = Report::query()->findOrFail($response->json('data.id'));
$this->assertTrue($report->properties->projectIds->contains(TimeEntryFilter::NONE_VALUE));
$this->assertTrue($report->properties->clientIds->contains(TimeEntryFilter::NONE_VALUE));
$this->assertTrue($report->properties->tagIds->contains(TimeEntryFilter::NONE_VALUE));
$this->assertTrue($report->properties->taskIds->contains(TimeEntryFilter::NONE_VALUE));
}
public function test_store_endpoint_creates_report_with_none_combined_with_real_ids(): void
{
// Arrange
$data = $this->createUserWithPermission([
'reports:create',
]);
$project = Project::factory()->forOrganization($data->organization)->create();
$client = Client::factory()->forOrganization($data->organization)->create();
$task = Task::factory()->forOrganization($data->organization)->forProject($project)->create();
$tag = Tag::factory()->forOrganization($data->organization)->create();
Passport::actingAs($data->user);
// Act
$response = $this->withoutExceptionHandling()->postJson(route('api.v1.reports.store', [$data->organization->getKey()]), [
'name' => 'Test Report with Combined Filters',
'is_public' => false,
'properties' => [
'start' => Carbon::now()->subDays(30)->toIso8601ZuluString(),
'end' => Carbon::now()->toIso8601ZuluString(),
'group' => TimeEntryAggregationType::Project->value,
'sub_group' => TimeEntryAggregationType::Task->value,
'history_group' => TimeEntryAggregationType::Day->value,
'project_ids' => [$project->getKey(), TimeEntryFilter::NONE_VALUE],
'client_ids' => [$client->getKey(), TimeEntryFilter::NONE_VALUE],
'tag_ids' => [$tag->getKey(), TimeEntryFilter::NONE_VALUE],
'task_ids' => [$task->getKey(), TimeEntryFilter::NONE_VALUE],
],
]);
// Assert
$response->assertStatus(201);
/** @var Report $report */
$report = Report::query()->findOrFail($response->json('data.id'));
$this->assertTrue($report->properties->projectIds->contains($project->getKey()));
$this->assertTrue($report->properties->projectIds->contains(TimeEntryFilter::NONE_VALUE));
$this->assertTrue($report->properties->clientIds->contains($client->getKey()));
$this->assertTrue($report->properties->clientIds->contains(TimeEntryFilter::NONE_VALUE));
$this->assertTrue($report->properties->tagIds->contains($tag->getKey()));
$this->assertTrue($report->properties->tagIds->contains(TimeEntryFilter::NONE_VALUE));
$this->assertTrue($report->properties->taskIds->contains($task->getKey()));
$this->assertTrue($report->properties->taskIds->contains(TimeEntryFilter::NONE_VALUE));
}
public function test_destroy_endpoint_fails_if_user_has_no_permission_to_delete_report(): void
{
// Arrange