adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-10-14 16:23:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(chromium): report unreachable resources behind the pinning proxy as loading failures

Browse Source
This commit is contained in:
Julien Neuhart
2026-10-13 19:45:06 +02:00
parent e1d714e5e0
commit db150b7733
6 changed files with 87 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/integration/features/chromium_convert_html.feature
View File

@@ -644,9 +644,23 @@ Feature: /forms/chromium/convert/html
Then the response header "Content-Type" should be "application/pdf"
Then there should be 1 PDF(s) in the response
# Through the pinning proxy, an unreachable resource must still fail the
# conversion. The proxy resets the connection instead of answering 502, which
# Chromium would treat as an ordinary HTTP error.
Scenario: POST /forms/chromium/convert/html (Fail On Resource Loading Failed through the pinning proxy)
Given I have a default Gotenberg container
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s):
| files | testdata/feature-rich-html/index.html | file |
| failOnResourceLoadingFailed | true | field |
Then the response status code should be 409
Then the response body should contain string:
"""
resource Stylesheet: net::ERR_CONNECTION_RESET
"""
Scenario: POST /forms/chromium/convert/html (Fail On Resource Loading Failed)
# A configured allow-list routes loopback through the pinning proxy, which
# reports a refused connection as a 502 response, not a loading failure.
# reports a refused connection as a reset. See the scenario below.
Given I have a Gotenberg container with the following environment variable(s):
| CHROMIUM_ALLOW_LIST | |
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s):

3
test/integration/features/chromium_convert_markdown.feature
View File

@@ -411,7 +411,8 @@ Feature: /forms/chromium/convert/markdown
Scenario: POST /forms/chromium/convert/markdown (Fail On Resource Loading Failed)
# A configured allow-list routes loopback through the pinning proxy, which
# reports a refused connection as a 502 response, not a loading failure.
# reports a refused connection as a reset. See the convert/html
# scenario.
Given I have a Gotenberg container with the following environment variable(s):
| CHROMIUM_ALLOW_LIST | |
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/markdown" endpoint with the following form data and header(s):

3
test/integration/features/chromium_convert_url.feature
View File

@@ -712,7 +712,8 @@ Feature: /forms/chromium/convert/url
Scenario: POST /forms/chromium/convert/url (Fail On Resource Loading Failed)
# A configured allow-list routes loopback through the pinning proxy, which
# reports a refused connection as a 502 response, not a loading failure.
# reports a refused connection as a reset. See the convert/html
# scenario.
Given I have a Gotenberg container with the following environment variable(s):
| CHROMIUM_ALLOW_LIST | |
Given I have a static server