From cf2d413a2853fe957f7ffe0ffaf3062d6b3c1f66 Mon Sep 17 00:00:00 2001 From: Julien Neuhart Date: Mon, 2 Jun 2025 11:27:25 +0200 Subject: [PATCH] test(integration): comment scenario that is not happening anymore on amd architectures --- .../features/chromium_convert_html.feature | 30 +++++++++-------- .../chromium_convert_markdown.feature | 32 ++++++++++--------- .../features/chromium_convert_url.feature | 32 ++++++++++--------- 3 files changed, 50 insertions(+), 44 deletions(-) diff --git a/test/integration/features/chromium_convert_html.feature b/test/integration/features/chromium_convert_html.feature index ab93e348..822f3361 100644 --- a/test/integration/features/chromium_convert_html.feature +++ b/test/integration/features/chromium_convert_html.feature @@ -420,20 +420,22 @@ Feature: /forms/chromium/convert/html """ omitBackground requires printBackground set to true """ - When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s): - | files | testdata/page-1-html/index.html | file | - | paperWidth | 0 | field | - | paperHeight | 0 | field | - | marginTop | 1000000 | field | - | marginBottom | 1000000 | field | - | marginLeft | 1000000 | field | - | marginRight | 1000000 | field | - Then the response status code should be 400 - Then the response header "Content-Type" should be "text/plain; charset=UTF-8" - Then the response body should match string: - """ - Chromium does not handle the provided settings; please check for aberrant form values - """ + # Does not seems to happen on amd architectures anymore since Chromium 137. + # See: https://github.com/gotenberg/gotenberg/actions/runs/15384321883/job/43280184372. +# When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s): +# | files | testdata/page-1-html/index.html | file | +# | paperWidth | 0 | field | +# | paperHeight | 0 | field | +# | marginTop | 1000000 | field | +# | marginBottom | 1000000 | field | +# | marginLeft | 1000000 | field | +# | marginRight | 1000000 | field | +# Then the response status code should be 400 +# Then the response header "Content-Type" should be "text/plain; charset=UTF-8" +# Then the response body should match string: +# """ +# Chromium does not handle the provided settings; please check for aberrant form values +# """ When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s): | files | testdata/page-1-html/index.html | file | | nativePageRanges | foo | field | diff --git a/test/integration/features/chromium_convert_markdown.feature b/test/integration/features/chromium_convert_markdown.feature index b8d84c28..338be06e 100644 --- a/test/integration/features/chromium_convert_markdown.feature +++ b/test/integration/features/chromium_convert_markdown.feature @@ -497,21 +497,23 @@ Feature: /forms/chromium/convert/markdown """ omitBackground requires printBackground set to true """ - When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/markdown" endpoint with the following form data and header(s): - | files | testdata/page-1-markdown/index.html | file | - | files | testdata/page-1-markdown/page_1.md | file | - | paperWidth | 0 | field | - | paperHeight | 0 | field | - | marginTop | 1000000 | field | - | marginBottom | 1000000 | field | - | marginLeft | 1000000 | field | - | marginRight | 1000000 | field | - Then the response status code should be 400 - Then the response header "Content-Type" should be "text/plain; charset=UTF-8" - Then the response body should match string: - """ - Chromium does not handle the provided settings; please check for aberrant form values - """ + # Does not seems to happen on amd architectures anymore since Chromium 137. + # See: https://github.com/gotenberg/gotenberg/actions/runs/15384321883/job/43280184372. +# When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/markdown" endpoint with the following form data and header(s): +# | files | testdata/page-1-markdown/index.html | file | +# | files | testdata/page-1-markdown/page_1.md | file | +# | paperWidth | 0 | field | +# | paperHeight | 0 | field | +# | marginTop | 1000000 | field | +# | marginBottom | 1000000 | field | +# | marginLeft | 1000000 | field | +# | marginRight | 1000000 | field | +# Then the response status code should be 400 +# Then the response header "Content-Type" should be "text/plain; charset=UTF-8" +# Then the response body should match string: +# """ +# Chromium does not handle the provided settings; please check for aberrant form values +# """ When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/markdown" endpoint with the following form data and header(s): | files | testdata/page-1-markdown/index.html | file | | files | testdata/page-1-markdown/page_1.md | file | diff --git a/test/integration/features/chromium_convert_url.feature b/test/integration/features/chromium_convert_url.feature index 4c16dc25..2e13e2c0 100644 --- a/test/integration/features/chromium_convert_url.feature +++ b/test/integration/features/chromium_convert_url.feature @@ -479,21 +479,23 @@ Feature: /forms/chromium/convert/url """ omitBackground requires printBackground set to true """ - Given I have a static server - When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/url" endpoint with the following form data and header(s): - | url | http://host.docker.internal:%d/html/testdata/page-1-html/index.html | field | - | paperWidth | 0 | field | - | paperHeight | 0 | field | - | marginTop | 1000000 | field | - | marginBottom | 1000000 | field | - | marginLeft | 1000000 | field | - | marginRight | 1000000 | field | - Then the response status code should be 400 - Then the response header "Content-Type" should be "text/plain; charset=UTF-8" - Then the response body should match string: - """ - Chromium does not handle the provided settings; please check for aberrant form values - """ + # Does not seems to happen on amd architectures anymore since Chromium 137. + # See: https://github.com/gotenberg/gotenberg/actions/runs/15384321883/job/43280184372. +# Given I have a static server +# When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/url" endpoint with the following form data and header(s): +# | url | http://host.docker.internal:%d/html/testdata/page-1-html/index.html | field | +# | paperWidth | 0 | field | +# | paperHeight | 0 | field | +# | marginTop | 1000000 | field | +# | marginBottom | 1000000 | field | +# | marginLeft | 1000000 | field | +# | marginRight | 1000000 | field | +# Then the response status code should be 400 +# Then the response header "Content-Type" should be "text/plain; charset=UTF-8" +# Then the response body should match string: +# """ +# Chromium does not handle the provided settings; please check for aberrant form values +# """ Given I have a static server When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/url" endpoint with the following form data and header(s): | url | http://host.docker.internal:%d/html/testdata/page-1-html/index.html | field |