adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-13 02:42:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

adding tests for page ranges

Browse Source
This commit is contained in:
Julien Neuhart
2019-10-05 12:09:39 +02:00
parent 827060b6ce
commit ca0784fa59
7 changed files with 89 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/pkg/printer/office.go
View File

@@ -91,9 +91,6 @@ func (p officePrinter) Print(destination string) error {
func (p officePrinter) unoconv(ctx context.Context, fpath, destination string) error {
const op string = "printer.unoconv"
resolver := func() error {
hasPageRanges := func() bool {
return p.opts.PageRanges != "" && len(p.fpaths) == 1
}
port, err := freeport.GetFreePort()
if err != nil {
return err
@@ -109,14 +106,15 @@ func (p officePrinter) unoconv(ctx context.Context, fpath, destination string) e
if p.opts.Landscape {
args = append(args, "--printer", "PaperOrientation=landscape")
}
if hasPageRanges() {
if p.opts.PageRanges != "" {
args = append(args, "--export", fmt.Sprintf("PageRange=%s", p.opts.PageRanges))
}
args = append(args, "--output", destination, fpath)
if err := xexec.Run(ctx, p.logger, "unoconv", args...); err != nil {
if hasPageRanges() && strings.Contains(err.Error(), "exit status 5") {
// TODO: find a way to check it in the handlers.
if p.opts.PageRanges != "" && strings.Contains(err.Error(), "exit status 5") {
return xerror.Invalid(
"",
op,
fmt.Sprintf("'%s' is not a valid LibreOffice page ranges", p.opts.PageRanges),
err,
)