adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-16 04:12:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(libreoffice): wrong HTTP status codes if invalid PDF formats

Browse Source
This commit is contained in:
Julien Neuhart
2024-01-18 12:00:32 +01:00
parent e5194b313d
commit b8926350b9
7 changed files with 44 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/modules/libreoffice/pdfengine/pdfengine.go
View File

@@ -64,7 +64,7 @@ func (engine *LibreOfficePdfEngine) Convert(ctx context.Context, logger *zap.Log
return nil
}
if errors.Is(err, api.ErrInvalidPdfFormat) {
if errors.Is(err, api.ErrInvalidPdfFormats) {
return fmt.Errorf("convert PDF to '%+v' with LibreOffice: %w", formats, gotenberg.ErrPdfFormatNotSupported)
}

2
pkg/modules/libreoffice/pdfengine/pdfengine_test.go
View File

@@ -137,7 +137,7 @@ func TestLibreOfficePdfEngine_Convert(t *testing.T) {
scenario: "invalid PDF format",
api: &api.ApiMock{
PdfMock: func(ctx context.Context, logger *zap.Logger, inputPath, outputPath string, options api.Options) error {
return api.ErrInvalidPdfFormat
return api.ErrInvalidPdfFormats
},
},
expectError: true,