adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-08 08:32:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(chromium): better native errors handling

Browse Source
This commit is contained in:
Julien Neuhart
2025-11-15 15:10:09 +01:00
parent 4a788ce9d8
commit b2c3187690
6 changed files with 71 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/integration/features/chromium_convert_html.feature
View File

@@ -2,7 +2,7 @@
# 1. JavaScript disabled on some feature.
@chromium
@chromium-pdf-html
@chromium-convert-html
Feature: /forms/chromium/convert/html
Scenario: POST /forms/chromium/convert/html (Default)
@@ -445,7 +445,16 @@ Feature: /forms/chromium/convert/html
Then the response header "Content-Type" should be "text/plain; charset=UTF-8"
Then the response body should match string:
"""
Chromium does not handle the page ranges 'foo' (nativePageRanges)
Chromium does not handle the page ranges 'foo' (nativePageRanges) syntax
"""
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s):
| files | testdata/page-1-html/index.html | file |
| nativePageRanges | 2-3 | field |
Then the response status code should be 400
Then the response header "Content-Type" should be "text/plain; charset=UTF-8"
Then the response body should match string:
"""
The page ranges '2-3' (nativePageRanges) exceeds the page count
"""
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/html" endpoint with the following form data and header(s):
| files | testdata/page-1-html/index.html | file |

12
test/integration/features/chromium_convert_markdown.feature
View File

@@ -524,7 +524,17 @@ Feature: /forms/chromium/convert/markdown
Then the response header "Content-Type" should be "text/plain; charset=UTF-8"
Then the response body should match string:
"""
Chromium does not handle the page ranges 'foo' (nativePageRanges)
Chromium does not handle the page ranges 'foo' (nativePageRanges) syntax
"""
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/markdown" endpoint with the following form data and header(s):
| files | testdata/page-1-markdown/index.html | file |
| files | testdata/page-1-markdown/page_1.md | file |
| nativePageRanges | 2-3 | field |
Then the response status code should be 400
Then the response header "Content-Type" should be "text/plain; charset=UTF-8"
Then the response body should match string:
"""
The page ranges '2-3' (nativePageRanges) exceeds the page count
"""
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/markdown" endpoint with the following form data and header(s):
| files | testdata/page-1-markdown/index.html | file |

12
test/integration/features/chromium_convert_url.feature
View File

@@ -522,7 +522,17 @@ Feature: /forms/chromium/convert/url
Then the response header "Content-Type" should be "text/plain; charset=UTF-8"
Then the response body should match string:
"""
Chromium does not handle the page ranges 'foo' (nativePageRanges)
Chromium does not handle the page ranges 'foo' (nativePageRanges) syntax
"""
Given I have a static server
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/url" endpoint with the following form data and header(s):
| url | http://host.docker.internal:%d/html/testdata/page-1-html/index.html | field |
| nativePageRanges | 2-3 | field |
Then the response status code should be 400
Then the response header "Content-Type" should be "text/plain; charset=UTF-8"
Then the response body should match string:
"""
The page ranges '2-3' (nativePageRanges) exceeds the page count
"""
Given I have a static server
When I make a "POST" request to Gotenberg at the "/forms/chromium/convert/url" endpoint with the following form data and header(s):