fix(chromium): increase the scope of loading failed errors (#962)

This commit is contained in:
Julien Neuhart
2024-09-07 15:54:01 +02:00
committed by GitHub
parent 300e73f07d
commit a3647fea8a
6 changed files with 60 additions and 31 deletions

View File

@@ -480,7 +480,7 @@ func TestChromiumBrowser_pdf(t *testing.T) {
expectedError: ErrConsoleExceptions,
},
{
scenario: "ErrConnectionRefused",
scenario: "ErrLoadingFailed",
browser: newChromiumBrowser(
browserArguments{
binPath: os.Getenv("CHROMIUM_BIN_PATH"),
@@ -503,7 +503,7 @@ func TestChromiumBrowser_pdf(t *testing.T) {
noDeadline: false,
start: true,
expectError: true,
expectedError: ErrConnectionRefused,
expectedError: ErrLoadingFailed,
},
{
scenario: "clear cache",
@@ -1553,7 +1553,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) {
expectedError: ErrConsoleExceptions,
},
{
scenario: "ErrConnectionRefused",
scenario: "ErrLoadingFailed",
browser: newChromiumBrowser(
browserArguments{
binPath: os.Getenv("CHROMIUM_BIN_PATH"),
@@ -1577,7 +1577,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) {
noDeadline: false,
start: true,
expectError: true,
expectedError: ErrConnectionRefused,
expectedError: ErrLoadingFailed,
},
{
scenario: "clear cache",