adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-14 19:32:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat(chromium): await thenable waitForExpression (#1617)

Browse Source
This commit is contained in:
Niklas
2026-08-14 11:57:29 +02:00
committed by GitHub
parent 6a087cb1f7
commit 90e614afa4
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/modules/chromium/tasks.go
View File

@@ -708,7 +708,15 @@ func waitForExpressionBeforePrintActionFunc(logger *slog.Logger, disableJavaScri
return fmt.Errorf("context done while evaluating '%s': %w", expression, ctx.Err())
case <-ticker.C:
var ok bool
evaluate := chromedp.Evaluate(expression, &ok)
// If the provided expression is a async function (thenable) it will be awaited
// (async () => {
// document.querySelector('#accept').click();
// await new Promise(r => setTimeout(r, 2000));
// return true;
// })()
evaluate := chromedp.Evaluate(expression, &ok, func(p *runtime.EvaluateParams) *runtime.EvaluateParams {
return p.WithAwaitPromise(true)
})
err := evaluate.Do(ctx)
if err != nil {