adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-14 19:32:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(chromium): skip lifecycle waits when waitForExpression or waitForSelector is set"

Browse Source 
This reverts commit 430f95f79f.
This commit is contained in:
Julien Neuhart
2026-04-24 11:19:14 +02:00
parent 430f95f79f
commit 8f711b0f99
4 changed files with 6 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/modules/chromium/browser.go
View File

@@ -317,11 +317,7 @@ func (b *chromiumBrowser) pdf(ctx context.Context, logger *slog.Logger, url, out
disableJavaScriptActionFunc(logger, b.arguments.disableJavaScript),
setCookiesActionFunc(logger, options.Cookies),
userAgentOverride(logger, options.UserAgent),
navigateActionFunc(logger, url, navigateOptions{
SkipNetworkIdleEvent: options.SkipNetworkIdleEvent,
SkipNetworkAlmostIdleEvent: options.SkipNetworkAlmostIdleEvent,
SkipLifecycleEvents: options.WaitForExpression != "" || options.WaitForSelector != "",
}),
navigateActionFunc(logger, url, options.SkipNetworkIdleEvent, options.SkipNetworkAlmostIdleEvent),
hideDefaultWhiteBackgroundActionFunc(logger, options.OmitBackground, options.PrintBackground),
forceExactColorsActionFunc(logger, options.PrintBackground),
emulateMediaTypeActionFunc(logger, options.EmulatedMediaType, options.EmulatedMediaFeatures),
@@ -347,11 +343,7 @@ func (b *chromiumBrowser) screenshot(ctx context.Context, logger *slog.Logger, u
disableJavaScriptActionFunc(logger, b.arguments.disableJavaScript),
setCookiesActionFunc(logger, options.Cookies),
userAgentOverride(logger, options.UserAgent),
navigateActionFunc(logger, url, navigateOptions{
SkipNetworkIdleEvent: options.SkipNetworkIdleEvent,
SkipNetworkAlmostIdleEvent: options.SkipNetworkAlmostIdleEvent,
SkipLifecycleEvents: options.WaitForExpression != "" || options.WaitForSelector != "",
}),
navigateActionFunc(logger, url, options.SkipNetworkIdleEvent, options.SkipNetworkAlmostIdleEvent),
hideDefaultWhiteBackgroundActionFunc(logger, options.OmitBackground, true),
forceExactColorsActionFunc(logger, true),
emulateMediaTypeActionFunc(logger, options.EmulatedMediaType, options.EmulatedMediaFeatures),