minor refactoring of @tbflw work

This commit is contained in:
Julien Neuhart
2019-06-21 13:32:46 +02:00
parent 97eff7f21d
commit 8ca9866440
10 changed files with 33 additions and 34 deletions

View File

@@ -7,15 +7,13 @@ import (
"github.com/mafredri/cdp/devtool"
)
const (
warmupTime = 10 * time.Second
)
const warmupTime = 10 * time.Second
type chrome struct {
manager *processManager
}
// NewChrome retruns a Google Chrome
// NewChrome returns a Google Chrome
// headless process.
func NewChrome(debug bool) Process {
return &chrome{

View File

@@ -87,11 +87,11 @@ func (m *processManager) pm2(p Process, cmdName string) error {
if m.verbose {
processStdErr, err := cmd.StderrPipe()
if err != nil {
return fmt.Errorf("failed getting stderr from '%s': %v", p.Fullname(), err)
return fmt.Errorf("failed getting stderr from %s: %s", p.Fullname(), err)
}
processStdOut, err := cmd.StdoutPipe()
if err != nil {
return fmt.Errorf("failed getting stdout from '%s': %v", p.Fullname(), err)
return fmt.Errorf("failed getting stdout from %s: %s", p.Fullname(), err)
}
readFromPipe := func(name string, reader io.ReadCloser) {
r := bufio.NewReader(reader)
@@ -100,12 +100,12 @@ func (m *processManager) pm2(p Process, cmdName string) error {
line, _, err := r.ReadLine()
if err != nil {
if err != io.EOF {
m.notifyf("error reading from %v for process '%v'", name, p.Fullname())
m.notifyf("error reading from %s for process %s", name, p.Fullname())
}
break
}
if len(line) != 0 {
m.notifyf("%v %v: %s", p.name(), name, string(line))
m.notifyf("%s %s: %s", p.name(), name, string(line))
}
}
}

View File

@@ -4,7 +4,7 @@ type unoconv struct {
manager *processManager
}
// NewUnoconv retruns a unoconv listener
// NewUnoconv returns a unoconv listener
// process.
func NewUnoconv(debug bool) Process {
return &unoconv{