From 81cc4831669eb7889bc3eafcd9fc60b40c0f84ba Mon Sep 17 00:00:00 2001 From: Julien Neuhart Date: Thu, 13 Feb 2025 09:21:38 +0100 Subject: [PATCH] test: fix issues with go 1.24 --- pkg/gotenberg/debug.go | 3 + pkg/gotenberg/debug_test.go | 2 +- pkg/gotenberg/gc_test.go | 2 +- pkg/modules/chromium/browser_test.go | 106 +++++++++--------- pkg/modules/chromium/routes_test.go | 16 +-- .../libreoffice/api/libreoffice_test.go | 32 +++--- 6 files changed, 82 insertions(+), 79 deletions(-) diff --git a/pkg/gotenberg/debug.go b/pkg/gotenberg/debug.go index a89a9b0a..9a83a699 100644 --- a/pkg/gotenberg/debug.go +++ b/pkg/gotenberg/debug.go @@ -2,6 +2,7 @@ package gotenberg import ( "runtime" + "sort" "sync" flag "github.com/spf13/pflag" @@ -42,6 +43,8 @@ func BuildDebug(ctx *Context) { debug.ModulesAdditionalData[ID] = debuggable.Debug() } + sort.Sort(AlphanumericSort(debug.Modules)) + ctx.ParsedFlags().VisitAll(func(f *flag.Flag) { debug.Flags[f.Name] = f.Value.String() }) diff --git a/pkg/gotenberg/debug_test.go b/pkg/gotenberg/debug_test.go index 60406084..5c50fde5 100644 --- a/pkg/gotenberg/debug_test.go +++ b/pkg/gotenberg/debug_test.go @@ -53,8 +53,8 @@ func TestBuildDebug(t *testing.T) { Version: Version, Architecture: runtime.GOARCH, Modules: []string{ - "foo", "bar", + "foo", }, ModulesAdditionalData: map[string]map[string]interface{}{ "bar": { diff --git a/pkg/gotenberg/gc_test.go b/pkg/gotenberg/gc_test.go index 0ed089a5..c8a4c09e 100644 --- a/pkg/gotenberg/gc_test.go +++ b/pkg/gotenberg/gc_test.go @@ -31,7 +31,7 @@ func TestGarbageCollect(t *testing.T) { err := os.MkdirAll(path, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/a_foo_file", path), []byte{1}, 0o755) diff --git a/pkg/modules/chromium/browser_test.go b/pkg/modules/chromium/browser_test.go index a5698eaf..a4636474 100644 --- a/pkg/modules/chromium/browser_test.go +++ b/pkg/modules/chromium/browser_test.go @@ -329,7 +329,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -361,7 +361,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -393,7 +393,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Skip networkIdle event

"), 0o755) @@ -428,7 +428,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidHttpStatusCode

"), 0o755) @@ -461,7 +461,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/style.css", fs.WorkingDirPath()), []byte("body{font-family: Arial, Helvetica, sans-serif;}"), 0o755) @@ -499,7 +499,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -532,7 +532,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } return fs @@ -558,7 +558,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrResourceLoadingFailed

"), 0o755) @@ -592,7 +592,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Clear cache

"), 0o755) @@ -625,7 +625,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Clear cookies

"), 0o755) @@ -658,7 +658,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -692,7 +692,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Set cookies

"), 0o755) @@ -727,7 +727,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

User-Agent override

"), 0o755) @@ -762,7 +762,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Extra HTTP headers

"), 0o755) @@ -816,7 +816,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrOmitBackgroundWithoutPrintBackground

"), 0o755) @@ -849,7 +849,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Hide default white background

"), 0o755) @@ -885,7 +885,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidEmulatedMediaType

"), 0o755) @@ -918,7 +918,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Screen media type

"), 0o755) @@ -953,7 +953,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -988,7 +988,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -1023,7 +1023,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } html := ` @@ -1069,7 +1069,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidEvaluationExpression

"), 0o755) @@ -1104,7 +1104,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } html := ` @@ -1150,7 +1150,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Custom header and footer

"), 0o755) @@ -1185,7 +1185,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Custom header and footer

"), 0o755) @@ -1221,7 +1221,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidPrinterSettings

"), 0o755) @@ -1259,7 +1259,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrPageRangesSyntaxError

"), 0o755) @@ -1292,7 +1292,7 @@ func TestChromiumBrowser_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Default options

"), 0o755) @@ -1491,7 +1491,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -1523,7 +1523,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -1555,7 +1555,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Skip networkIdle event

"), 0o755) @@ -1590,7 +1590,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidHttpStatusCode

"), 0o755) @@ -1623,7 +1623,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/style.css", fs.WorkingDirPath()), []byte("body{font-family: Arial, Helvetica, sans-serif;}"), 0o755) @@ -1661,7 +1661,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -1694,7 +1694,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } return fs @@ -1720,7 +1720,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrResourceLoadingFailed

"), 0o755) @@ -1754,7 +1754,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Clear cache

"), 0o755) @@ -1787,7 +1787,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Clear cookies

"), 0o755) @@ -1820,7 +1820,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -1854,7 +1854,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Set cookies

"), 0o755) @@ -1889,7 +1889,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

User-Agent override

"), 0o755) @@ -1924,7 +1924,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Extra HTTP headers

"), 0o755) @@ -1978,7 +1978,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrOmitBackgroundWithoutPrintBackground

"), 0o755) @@ -2013,7 +2013,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidEmulatedMediaType

"), 0o755) @@ -2046,7 +2046,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Screen media type

"), 0o755) @@ -2081,7 +2081,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -2116,7 +2116,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte(""), 0o755) @@ -2151,7 +2151,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } html := ` @@ -2197,7 +2197,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

ErrInvalidEvaluationExpression

"), 0o755) @@ -2232,7 +2232,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } html := ` @@ -2278,7 +2278,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Default options

"), 0o755) @@ -2321,7 +2321,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Default options

"), 0o755) @@ -2369,7 +2369,7 @@ func TestChromiumBrowser_screenshot(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", fs.WorkingDirPath()), []byte("

Default options

"), 0o755) diff --git a/pkg/modules/chromium/routes_test.go b/pkg/modules/chromium/routes_test.go index 933b833e..552e55ca 100644 --- a/pkg/modules/chromium/routes_test.go +++ b/pkg/modules/chromium/routes_test.go @@ -1052,7 +1052,7 @@ func TestConvertMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1080,7 +1080,7 @@ func TestConvertMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1107,7 +1107,7 @@ func TestConvertMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1142,7 +1142,7 @@ func TestConvertMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1259,7 +1259,7 @@ func TestScreenshotMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1287,7 +1287,7 @@ func TestScreenshotMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1314,7 +1314,7 @@ func TestScreenshotMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) @@ -1349,7 +1349,7 @@ func TestScreenshotMarkdownRoute(t *testing.T) { err := os.MkdirAll(dirPath, 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/index.html", dirPath), []byte("
{{ toHTML \"markdown.md\" }}
"), 0o755) diff --git a/pkg/modules/libreoffice/api/libreoffice_test.go b/pkg/modules/libreoffice/api/libreoffice_test.go index fce85515..348d6c18 100644 --- a/pkg/modules/libreoffice/api/libreoffice_test.go +++ b/pkg/modules/libreoffice/api/libreoffice_test.go @@ -265,7 +265,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Context done"), 0o755) @@ -295,36 +295,36 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } in, err := os.Open("/tests/test/testdata/libreoffice/protected.docx") if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } defer func() { err := in.Close() if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } }() out, err := os.Create(fmt.Sprintf("%s/protected.docx", fs.WorkingDirPath())) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } defer func() { err := out.Close() if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } }() _, err = io.Copy(out, in) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } return fs @@ -348,7 +348,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Context done"), 0o755) @@ -376,7 +376,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Success"), 0o755) @@ -404,7 +404,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Success"), 0o755) @@ -456,7 +456,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Landscape"), 0o755) @@ -485,7 +485,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Landscape"), 0o755) @@ -514,7 +514,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Landscape"), 0o755) @@ -543,7 +543,7 @@ func TestLibreOfficeProcess_pdf(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Landscape"), 0o755) @@ -629,7 +629,7 @@ func TestNonBasicLatinCharactersGuard(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/document.txt", fs.WorkingDirPath()), []byte("Basic latin characters"), 0o755) @@ -650,7 +650,7 @@ func TestNonBasicLatinCharactersGuard(t *testing.T) { err := os.MkdirAll(fs.WorkingDirPath(), 0o755) if err != nil { - t.Fatalf(fmt.Sprintf("expected no error but got: %v", err)) + t.Fatalf("expected no error but got: %v", err) } err = os.WriteFile(fmt.Sprintf("%s/éèßàùä.txt", fs.WorkingDirPath()), []byte("Non-basic latin characters"), 0o755)