adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-13 19:02:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

reducing memory footprint

Browse Source
This commit is contained in:
Julien Neuhart
2019-08-26 10:22:39 +02:00
parent fa94341b60
commit 7cff2e01a4
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
internal/pkg/printer/chrome.go
View File

@@ -83,6 +83,15 @@ func (p chromePrinter) Print(destination string) error {
if err != nil { if err != nil {
return err return err
} }
/*
close the browser context when done.
we're not using the "default" context
as it may timeout before actually closing
the browser context.
see: https://github.com/mafredri/cdp/issues/101#issuecomment-524533670
*/
disposeBrowserContextArgs := target.NewDisposeBrowserContextArgs(newContextTarget.BrowserContextID)
defer devtClient.Target.DisposeBrowserContext(context.Background(), disposeBrowserContextArgs) // nolint: errcheck
// create a new blank target with the new browser context. // create a new blank target with the new browser context.
createTargetArgs := target. createTargetArgs := target.
NewCreateTargetArgs("about:blank"). NewCreateTargetArgs("about:blank").
@@ -101,8 +110,14 @@ func (p chromePrinter) Print(destination string) error {
// create a new CDP Client that uses newContextConn. // create a new CDP Client that uses newContextConn.
targetClient := cdp.NewClient(newContextConn) targetClient := cdp.NewClient(newContextConn)
closeTargetArgs := target.NewCloseTargetArgs(newTarget.TargetID) closeTargetArgs := target.NewCloseTargetArgs(newTarget.TargetID)
// close the target when done. /*
defer targetClient.Target.CloseTarget(ctx, closeTargetArgs) // nolint: errcheck close the target when done.
we're not using the "default" context
as it may timeout before actually closing
the target.
see: https://github.com/mafredri/cdp/issues/101#issuecomment-524533670
*/
defer targetClient.Target.CloseTarget(context.Background(), closeTargetArgs) // nolint: errcheck
// enable all events. // enable all events.
if err := p.enableEvents(ctx, targetClient); err != nil { if err := p.enableEvents(ctx, targetClient); err != nil {
return err return err