From 71f1f3dd223978fe24f5217d1ade0ad3e58d45d8 Mon Sep 17 00:00:00 2001 From: teng Date: Tue, 6 May 2025 16:26:46 +0800 Subject: [PATCH] feat(chromium): change sort of wait delay action and wait expression action (#1186) eg: scroll screen to load all lazy image. --- pkg/modules/chromium/browser.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/modules/chromium/browser.go b/pkg/modules/chromium/browser.go index b0f39466..6bf63ec6 100644 --- a/pkg/modules/chromium/browser.go +++ b/pkg/modules/chromium/browser.go @@ -276,8 +276,8 @@ func (b *chromiumBrowser) pdf(ctx context.Context, logger *zap.Logger, url, outp hideDefaultWhiteBackgroundActionFunc(logger, options.OmitBackground, options.PrintBackground), forceExactColorsActionFunc(logger, options.PrintBackground), emulateMediaTypeActionFunc(logger, options.EmulatedMediaType), - waitDelayBeforePrintActionFunc(logger, b.arguments.disableJavaScript, options.WaitDelay), waitForExpressionBeforePrintActionFunc(logger, b.arguments.disableJavaScript, options.WaitForExpression), + waitDelayBeforePrintActionFunc(logger, b.arguments.disableJavaScript, options.WaitDelay), // PDF specific. printToPdfActionFunc(logger, outputPath, options), }) @@ -299,8 +299,8 @@ func (b *chromiumBrowser) screenshot(ctx context.Context, logger *zap.Logger, ur hideDefaultWhiteBackgroundActionFunc(logger, options.OmitBackground, true), forceExactColorsActionFunc(logger, true), emulateMediaTypeActionFunc(logger, options.EmulatedMediaType), - waitDelayBeforePrintActionFunc(logger, b.arguments.disableJavaScript, options.WaitDelay), waitForExpressionBeforePrintActionFunc(logger, b.arguments.disableJavaScript, options.WaitForExpression), + waitDelayBeforePrintActionFunc(logger, b.arguments.disableJavaScript, options.WaitDelay), // Screenshot specific. setDeviceMetricsOverride(logger, options.Width, options.Height), captureScreenshotActionFunc(logger, outputPath, options),