adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-17 12:42:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-Authored-By: Julien Neuhart <j.neuhart@thecodingmachine.com>
This commit is contained in:
Thomas Bøgh Fangel
2019-06-17 11:29:52 +02:00
committed by GitHub
parent c36c7144cb
commit 6fa48c9222
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/pkg/pm2/pm2.go
View File

@@ -85,7 +85,7 @@ func (m *processManager) pm2(p Process, cmdName string) error {
)
m.notifyf("executing command '%v'", strings.Join(cmd.Args, " "))
if m.verbose {
chromeStdErr, err := cmd.StderrPipe()
processStdErr, err := cmd.StderrPipe()
if err != nil {
return fmt.Errorf("failed getting Chrome stderr: %v", err)
}
@@ -95,7 +95,7 @@ func (m *processManager) pm2(p Process, cmdName string) error {
}
readFromPipe := func(name string, reader io.ReadCloser) {
r := bufio.NewReader(reader)
defer reader.Close()
defer reader.Close() // nolint: errcheck
for {
line, _, err := r.ReadLine()
if err != nil {