From 6ee1932cbfe7a46b3c6691671bbc8f3f7291c371 Mon Sep 17 00:00:00 2001
From: Julien Neuhart <j.neuhart@thecodingmachine.com>
Date: Tue, 11 Dec 2018 14:16:43 +0100
Subject: [PATCH] improving API tests: now verifying response content type and
 status code

---
 internal/app/api/html_test.go     | 5 ++++-
 internal/app/api/markdown_test.go | 5 ++++-
 internal/app/api/merge_test.go    | 5 ++++-
 internal/app/api/office_test.go   | 5 ++++-
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/internal/app/api/html_test.go b/internal/app/api/html_test.go
index 8ee252b9..9df49a96 100644
--- a/internal/app/api/html_test.go
+++ b/internal/app/api/html_test.go
@@ -17,5 +17,8 @@ func TestHTML(t *testing.T) {
 	rec := httptest.NewRecorder()
 	e := echo.New()
 	c := e.NewContext(req, rec)
-	assert.NoError(t, convertHTML(c))
+	if assert.NoError(t, convertHTML(c)) {
+		assert.Equal(t, http.StatusOK, rec.Code)
+		assert.Equal(t, "application/pdf", rec.Header().Get(echo.HeaderContentType))
+	}
 }
diff --git a/internal/app/api/markdown_test.go b/internal/app/api/markdown_test.go
index a399d58a..3a979c99 100644
--- a/internal/app/api/markdown_test.go
+++ b/internal/app/api/markdown_test.go
@@ -17,5 +17,8 @@ func TestMarkdown(t *testing.T) {
 	rec := httptest.NewRecorder()
 	e := echo.New()
 	c := e.NewContext(req, rec)
-	assert.NoError(t, convertMarkdown(c))
+	if assert.NoError(t, convertMarkdown(c)) {
+		assert.Equal(t, http.StatusOK, rec.Code)
+		assert.Equal(t, "application/pdf", rec.Header().Get(echo.HeaderContentType))
+	}
 }
diff --git a/internal/app/api/merge_test.go b/internal/app/api/merge_test.go
index 4d147887..14e49c84 100644
--- a/internal/app/api/merge_test.go
+++ b/internal/app/api/merge_test.go
@@ -17,5 +17,8 @@ func TestMerge(t *testing.T) {
 	rec := httptest.NewRecorder()
 	e := echo.New()
 	c := e.NewContext(req, rec)
-	assert.NoError(t, merge(c))
+	if assert.NoError(t, merge(c)) {
+		assert.Equal(t, http.StatusOK, rec.Code)
+		assert.Equal(t, "application/pdf", rec.Header().Get(echo.HeaderContentType))
+	}
 }
diff --git a/internal/app/api/office_test.go b/internal/app/api/office_test.go
index a46c4c8f..2c85bf55 100644
--- a/internal/app/api/office_test.go
+++ b/internal/app/api/office_test.go
@@ -17,5 +17,8 @@ func TestOffice(t *testing.T) {
 	rec := httptest.NewRecorder()
 	e := echo.New()
 	c := e.NewContext(req, rec)
-	assert.NoError(t, convertOffice(c))
+	if assert.NoError(t, convertOffice(c)) {
+		assert.Equal(t, http.StatusOK, rec.Code)
+		assert.Equal(t, "application/pdf", rec.Header().Get(echo.HeaderContentType))
+	}
 }