improving logging (#5)

* small refactoring of error messages

* (very) small refactoring of structs instantiation

* improving logging with debug messages

* using INFO level as default + changing previous debug message to info message
This commit is contained in:
Julien Neuhart
2018-05-04 17:43:19 +02:00
committed by GitHub
parent 810d35ffbe
commit 2871fb1ffe
30 changed files with 1275 additions and 61 deletions

View File

@@ -15,8 +15,10 @@ const MultipartFormDataContentType ContentType = "multipart/form-data"
type notAuthorizedContentTypeError struct{}
const notAuthorizedContentTypeErrorMessage = "accepted value for 'Content-Type': %s"
func (e *notAuthorizedContentTypeError) Error() string {
return fmt.Sprintf("Accepted value for 'Content-Type': %s", MultipartFormDataContentType)
return fmt.Sprintf(notAuthorizedContentTypeErrorMessage, MultipartFormDataContentType)
}
// CheckAuthorizedContentType checks if the request header header has an authorized content type.

View File

@@ -31,7 +31,8 @@ func TestCheckAuthorizedContentType(t *testing.T) {
func TestNotAuthorizedContentTypeError(t *testing.T) {
err := &notAuthorizedContentTypeError{}
expected := fmt.Sprintf("Accepted value for 'Content-Type': %s", MultipartFormDataContentType)
expected := fmt.Sprintf(notAuthorizedContentTypeErrorMessage, MultipartFormDataContentType)
if err.Error() != expected {
t.Errorf("Error returned a wrong message: got '%s' want '%s'", err.Error(), expected)
}