adalal/gotenberg
1
0
Fork 0
mirror of https://github.com/gotenberg/gotenberg.git synced 2026-08-18 21:22:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(chromium): form field 'failOnConsoleException' does not work if JavaScript is disabled

Browse Source
This commit is contained in:
Julien Neuhart
2021-11-24 16:48:21 +01:00
parent bd5933f4c2
commit 285c43dab7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/modules/chromium/chromium.go
View File

@@ -432,7 +432,7 @@ func (mod Chromium) PDF(ctx context.Context, logger *zap.Logger, URL, outputPath
listenForEventRequestPaused(taskCtx, logger, mod.allowList, mod.denyList) listenForEventRequestPaused(taskCtx, logger, mod.allowList, mod.denyList)
// See https://github.com/gotenberg/gotenberg/issues/262. // See https://github.com/gotenberg/gotenberg/issues/262.
if options.FailOnConsoleExceptions { if options.FailOnConsoleExceptions && !mod.disableJavaScript {
listenForEventExceptionThrown(taskCtx, logger, &consoleExceptions, &consoleExceptionsMu) listenForEventExceptionThrown(taskCtx, logger, &consoleExceptions, &consoleExceptionsMu)
} }